Files
alighasami 3d5eaf9445
Security: Sync from Public / sync-from-public (push) Has been cancelled
Test: Benchmark Nightly / build (push) Has been cancelled
Test: Benchmark Nightly / Notify Cats on failure (push) Has been cancelled
CI: Python / Checks (push) Has been cancelled
Test: Evals Python / Workflow Comparison Python (push) Has been cancelled
Util: Check Docs URLs / check-docs-urls (push) Has been cancelled
Test: Visual Storybook / Cloudflare Pages (push) Has been cancelled
Test: E2E Performance / build-and-test-performance (push) Has been cancelled
Test: Workflows Nightly / Run Workflow Tests (push) Has been cancelled
Util: Cleanup CI Docker Images / Delete stale CI images (push) Has been cancelled
Test: Benchmark Destroy Env / build (push) Has been cancelled
Util: Update Node Popularity / update-popularity (push) Has been cancelled
Test: E2E Coverage Weekly / Coverage Tests (push) Has been cancelled
first commit
2026-03-17 16:22:57 +03:30

598 lines
17 KiB
TypeScript

/* eslint-disable n8n-nodes-base/node-filename-against-convention */
/* eslint-disable @typescript-eslint/unbound-method */
import { ChatOpenAI } from '@langchain/openai';
import { makeN8nLlmFailedAttemptHandler, N8nLlmTracing, getProxyAgent } from '@n8n/ai-utilities';
import { AiConfig } from '@n8n/config';
import { Container } from '@n8n/di';
import { createMockExecuteFunction } from 'n8n-nodes-base/test/nodes/Helpers';
import type { IDataObject, INode, ISupplyDataFunctions } from 'n8n-workflow';
import * as common from '../LMChatOpenAi/common';
import { LmChatOpenAi } from '../LMChatOpenAi/LmChatOpenAi.node';
jest.mock('@langchain/openai');
jest.mock('@n8n/ai-utilities');
jest.mock('../LMChatOpenAi/common');
const MockedChatOpenAI = jest.mocked(ChatOpenAI);
const MockedN8nLlmTracing = jest.mocked(N8nLlmTracing);
const mockedMakeN8nLlmFailedAttemptHandler = jest.mocked(makeN8nLlmFailedAttemptHandler);
const mockedCommon = jest.mocked(common);
const mockedGetProxyAgent = jest.mocked(getProxyAgent);
const { openAiDefaultHeaders: defaultHeaders } = Container.get(AiConfig);
describe('LmChatOpenAi', () => {
let lmChatOpenAi: LmChatOpenAi;
let mockContext: jest.Mocked<ISupplyDataFunctions>;
const mockNode: INode = {
id: '1',
name: 'OpenAI Chat Model',
typeVersion: 1.2,
type: 'n8n-nodes-langchain.lmChatOpenAi',
position: [0, 0],
parameters: {},
};
const setupMockContext = (nodeOverrides: Partial<INode> = {}) => {
const node = { ...mockNode, ...nodeOverrides };
mockContext = createMockExecuteFunction<ISupplyDataFunctions>(
{},
node,
) as jest.Mocked<ISupplyDataFunctions>;
// Setup default mocks
mockContext.getCredentials = jest.fn().mockResolvedValue({
apiKey: 'test-api-key',
});
mockContext.getNode = jest.fn().mockReturnValue(node);
mockContext.getNodeParameter = jest.fn();
// Mock the constructors/functions properly
MockedN8nLlmTracing.mockImplementation(() => ({}) as any);
mockedMakeN8nLlmFailedAttemptHandler.mockReturnValue(jest.fn());
mockedGetProxyAgent.mockReturnValue({} as any);
return mockContext;
};
beforeEach(() => {
lmChatOpenAi = new LmChatOpenAi();
jest.clearAllMocks();
});
afterEach(() => {
jest.clearAllMocks();
});
describe('node description', () => {
it('should have correct node properties', () => {
expect(lmChatOpenAi.description).toMatchObject({
displayName: 'OpenAI Chat Model',
name: 'lmChatOpenAi',
group: ['transform'],
version: [1, 1.1, 1.2, 1.3],
description: 'For advanced usage with an AI chain',
});
});
it('should have correct credentials configuration', () => {
expect(lmChatOpenAi.description.credentials).toEqual([
{
name: 'openAiApi',
required: true,
},
]);
});
it('should have correct output configuration', () => {
expect(lmChatOpenAi.description.outputs).toEqual(['ai_languageModel']);
expect(lmChatOpenAi.description.outputNames).toEqual(['Model']);
});
});
describe('supplyData', () => {
it('should create ChatOpenAI instance with basic configuration (version >= 1.2)', async () => {
const mockContext = setupMockContext({ typeVersion: 1.2 });
// Mock getNodeParameter to handle the proper parameter names for v1.2
mockContext.getNodeParameter = jest.fn().mockImplementation((paramName: string) => {
if (paramName === 'model.value') return 'gpt-4o-mini';
if (paramName === 'options') return {};
return undefined;
});
const result = await lmChatOpenAi.supplyData.call(mockContext, 0);
expect(mockContext.getCredentials).toHaveBeenCalledWith('openAiApi');
expect(mockContext.getNodeParameter).toHaveBeenCalledWith('model.value', 0);
expect(mockContext.getNodeParameter).toHaveBeenCalledWith('options', 0, {});
expect(MockedChatOpenAI).toHaveBeenCalledWith(
expect.objectContaining({
apiKey: 'test-api-key',
model: 'gpt-4o-mini',
maxRetries: 2,
configuration: {
defaultHeaders,
fetchOptions: {
dispatcher: {},
},
},
callbacks: expect.arrayContaining([expect.any(Object)]),
modelKwargs: {},
onFailedAttempt: expect.any(Function),
}),
);
expect(result).toEqual({
response: expect.any(Object),
});
});
it('should create ChatOpenAI instance with basic configuration (version < 1.2)', async () => {
const mockContext = setupMockContext({ typeVersion: 1.1 });
// Mock getNodeParameter to handle the proper parameter names for v1.1
mockContext.getNodeParameter = jest.fn().mockImplementation((paramName: string) => {
if (paramName === 'model') return 'gpt-4o-mini';
if (paramName === 'options') return {};
return undefined;
});
await lmChatOpenAi.supplyData.call(mockContext, 0);
expect(mockContext.getNodeParameter).toHaveBeenCalledWith('model', 0);
expect(mockContext.getNodeParameter).toHaveBeenCalledWith('options', 0, {});
expect(MockedChatOpenAI).toHaveBeenCalledWith(
expect.objectContaining({
apiKey: 'test-api-key',
model: 'gpt-4o-mini',
maxRetries: 2,
configuration: {
defaultHeaders,
fetchOptions: {
dispatcher: {},
},
},
callbacks: expect.arrayContaining([expect.any(Object)]),
modelKwargs: {},
onFailedAttempt: expect.any(Function),
}),
);
});
it('should handle custom baseURL from options', async () => {
const customBaseURL = 'https://custom-api.example.com/v1';
const mockContext = setupMockContext();
mockContext.getNodeParameter = jest.fn().mockImplementation((paramName: string) => {
if (paramName === 'model.value') return 'gpt-4o-mini';
if (paramName === 'options')
return {
baseURL: customBaseURL,
timeout: 30000,
maxRetries: 5,
};
return undefined;
});
await lmChatOpenAi.supplyData.call(mockContext, 0);
expect(MockedChatOpenAI).toHaveBeenCalledWith(
expect.objectContaining({
apiKey: 'test-api-key',
model: 'gpt-4o-mini',
baseURL: customBaseURL,
timeout: 30000,
maxRetries: 5,
configuration: {
baseURL: customBaseURL,
fetchOptions: {
dispatcher: {},
},
defaultHeaders,
},
callbacks: expect.arrayContaining([expect.any(Object)]),
modelKwargs: {},
onFailedAttempt: expect.any(Function),
}),
);
});
it('should handle custom baseURL from credentials', async () => {
const customURL = 'https://custom-openai.example.com/v1';
const mockContext = setupMockContext();
mockContext.getCredentials.mockResolvedValue({
apiKey: 'test-api-key',
url: customURL,
});
mockContext.getNodeParameter = jest.fn().mockImplementation((paramName: string) => {
if (paramName === 'model.value') return 'gpt-4o-mini';
if (paramName === 'options') return {};
return undefined;
});
await lmChatOpenAi.supplyData.call(mockContext, 0);
expect(MockedChatOpenAI).toHaveBeenCalledWith(
expect.objectContaining({
apiKey: 'test-api-key',
model: 'gpt-4o-mini',
maxRetries: 2,
configuration: {
baseURL: customURL,
fetchOptions: {
dispatcher: {},
},
defaultHeaders,
},
callbacks: expect.arrayContaining([expect.any(Object)]),
modelKwargs: {},
onFailedAttempt: expect.any(Function),
}),
);
});
it('should handle custom headers from credentials', async () => {
const mockContext = setupMockContext();
mockContext.getCredentials.mockResolvedValue({
apiKey: 'test-api-key',
header: true,
headerName: 'X-Custom-Header',
headerValue: 'custom-value',
});
mockContext.getNodeParameter = jest.fn().mockImplementation((paramName: string) => {
if (paramName === 'model.value') return 'gpt-4o-mini';
if (paramName === 'options') return {};
return undefined;
});
await lmChatOpenAi.supplyData.call(mockContext, 0);
expect(MockedChatOpenAI).toHaveBeenCalledWith(
expect.objectContaining({
apiKey: 'test-api-key',
model: 'gpt-4o-mini',
maxRetries: 2,
configuration: {
defaultHeaders: {
...defaultHeaders,
'X-Custom-Header': 'custom-value',
},
fetchOptions: {
dispatcher: {},
},
},
callbacks: expect.arrayContaining([expect.any(Object)]),
modelKwargs: {},
onFailedAttempt: expect.any(Function),
}),
);
});
it('should handle all available options v1.2', async () => {
const mockContext = setupMockContext({ typeVersion: 1.2 });
const options = {
frequencyPenalty: 0.5,
maxTokens: 1000,
presencePenalty: 0.3,
temperature: 0.8,
topP: 0.9,
timeout: 45000,
maxRetries: 3,
responseFormat: 'json_object' as const,
reasoningEffort: 'high' as const,
};
mockContext.getNodeParameter = jest.fn().mockImplementation((paramName: string) => {
if (paramName === 'model.value') return 'gpt-4o-mini';
if (paramName === 'options') return options;
return undefined;
});
await lmChatOpenAi.supplyData.call(mockContext, 0);
expect(MockedChatOpenAI).toHaveBeenCalledWith(
expect.objectContaining({
apiKey: 'test-api-key',
model: 'gpt-4o-mini',
frequencyPenalty: 0.5,
maxTokens: 1000,
presencePenalty: 0.3,
temperature: 0.8,
topP: 0.9,
timeout: 45000,
maxRetries: 3,
configuration: {
defaultHeaders,
fetchOptions: {
dispatcher: {},
},
},
callbacks: expect.arrayContaining([expect.any(Object)]),
modelKwargs: {
response_format: { type: 'json_object' },
reasoning_effort: 'high',
},
onFailedAttempt: expect.any(Function),
}),
);
});
it('should only add valid reasoning effort to modelKwargs', async () => {
const mockContext = setupMockContext();
const options = {
reasoningEffort: 'invalid' as 'low' | 'medium' | 'high',
};
mockContext.getNodeParameter = jest.fn().mockImplementation((paramName: string) => {
if (paramName === 'model.value') return 'gpt-4o-mini';
if (paramName === 'options') return options;
return undefined;
});
await lmChatOpenAi.supplyData.call(mockContext, 0);
expect(MockedChatOpenAI).toHaveBeenCalledWith(
expect.objectContaining({
model: 'gpt-4o-mini',
modelKwargs: {}, // Should not include invalid reasoning_effort
}),
);
});
it('should create N8nLlmTracing callback', async () => {
const mockContext = setupMockContext();
mockContext.getNodeParameter = jest.fn().mockImplementation((paramName: string) => {
if (paramName === 'model.value') return 'gpt-4o-mini';
if (paramName === 'options') return {};
return undefined;
});
await lmChatOpenAi.supplyData.call(mockContext, 0);
expect(MockedN8nLlmTracing).toHaveBeenCalledWith(mockContext);
});
it('should create failed attempt handler', async () => {
const mockContext = setupMockContext();
mockContext.getNodeParameter = jest.fn().mockImplementation((paramName: string) => {
if (paramName === 'model.value') return 'gpt-4o-mini';
if (paramName === 'options') return {};
return undefined;
});
await lmChatOpenAi.supplyData.call(mockContext, 0);
expect(mockedMakeN8nLlmFailedAttemptHandler).toHaveBeenCalledWith(
mockContext,
expect.any(Function), // openAiFailedAttemptHandler
);
});
it('should use default values for maxRetries when not provided', async () => {
const mockContext = setupMockContext();
mockContext.getNodeParameter = jest.fn().mockImplementation((paramName: string) => {
if (paramName === 'model.value') return 'gpt-4o-mini';
if (paramName === 'options') return {};
return undefined;
});
await lmChatOpenAi.supplyData.call(mockContext, 0);
// timeout is now controlled at the undici level via fetchOptions dispatcher
expect(MockedChatOpenAI).toHaveBeenCalledWith(
expect.objectContaining({
maxRetries: 2,
}),
);
});
it('should set supportsStrictToolCalling to false for OpenAI-compatible backends', async () => {
const mockContext = setupMockContext();
mockContext.getNodeParameter = jest.fn().mockImplementation((paramName: string) => {
if (paramName === 'model.value') return 'gpt-4o-mini';
if (paramName === 'options') return {};
return undefined;
});
await lmChatOpenAi.supplyData.call(mockContext, 0);
expect(MockedChatOpenAI).toHaveBeenCalledWith(
expect.objectContaining({
supportsStrictToolCalling: false,
}),
);
});
it('should prioritize options.baseURL over credentials.url', async () => {
const optionsBaseURL = 'https://options-api.example.com/v1';
const credentialsURL = 'https://credentials-api.example.com/v1';
const mockContext = setupMockContext();
mockContext.getCredentials.mockResolvedValue({
apiKey: 'test-api-key',
url: credentialsURL,
});
mockContext.getNodeParameter = jest.fn().mockImplementation((paramName: string) => {
if (paramName === 'model.value') return 'gpt-4o-mini';
if (paramName === 'options')
return {
baseURL: optionsBaseURL,
};
return undefined;
});
await lmChatOpenAi.supplyData.call(mockContext, 0);
expect(MockedChatOpenAI).toHaveBeenCalledWith(
expect.objectContaining({
configuration: {
baseURL: optionsBaseURL,
fetchOptions: {
dispatcher: {},
},
defaultHeaders,
},
}),
);
});
it('should handle text response format correctly v1.2', async () => {
const mockContext = setupMockContext({ typeVersion: 1.2 });
const options = {
responseFormat: 'text' as const,
};
mockContext.getNodeParameter = jest.fn().mockImplementation((paramName: string) => {
if (paramName === 'model.value') return 'gpt-4o-mini';
if (paramName === 'options') return options;
return undefined;
});
await lmChatOpenAi.supplyData.call(mockContext, 0);
expect(MockedChatOpenAI).toHaveBeenCalledWith(
expect.objectContaining({
modelKwargs: {
response_format: { type: 'text' },
},
}),
);
});
it('should handle all reasoning effort values correctly', async () => {
const reasoningEffortValues = ['low', 'medium', 'high'] as const;
for (const effort of reasoningEffortValues) {
const mockContext = setupMockContext();
mockContext.getNodeParameter = jest.fn().mockImplementation((paramName: string) => {
if (paramName === 'model.value') return 'gpt-4o-mini';
if (paramName === 'options')
return {
reasoningEffort: effort,
};
return undefined;
});
await lmChatOpenAi.supplyData.call(mockContext, 0);
expect(MockedChatOpenAI).toHaveBeenCalledWith(
expect.objectContaining({
modelKwargs: {
reasoning_effort: effort,
},
}),
);
jest.clearAllMocks();
}
});
});
describe('methods', () => {
beforeEach(() => {
setupMockContext();
});
it('should have searchModels method', () => {
expect(lmChatOpenAi.methods).toEqual({
listSearch: {
searchModels: expect.any(Function),
},
});
});
it('should force Responses API and include additional params for v1.3', async () => {
const mockContext = setupMockContext({ typeVersion: 1.3 });
const options: IDataObject = {
conversationId: 'conv_123',
promptCacheKey: 'cache_key_1',
safetyIdentifier: 'user-42',
serviceTier: 'priority' as const,
topLogprobs: 10,
metadata: '{"team":"ai"}',
textFormat: {
textOptions: [{ type: 'json_object', verbosity: 'high' }],
},
promptConfig: {
promptOptions: [{ promptId: 'p_1', version: '1', variables: '{"name":"n8n"}' }],
},
};
const mockResponsesParams = {
custom: true,
};
mockContext.getNodeParameter = jest.fn().mockImplementation((paramName: string) => {
if (paramName === 'responsesApiEnabled') return true;
if (paramName === 'model.value') return 'gpt-4o-mini';
if (paramName === 'options') return options;
return undefined;
});
mockedCommon.prepareAdditionalResponsesParams = jest
.fn()
.mockReturnValue(mockResponsesParams);
mockedCommon.formatBuiltInTools = jest.fn().mockReturnValue([]);
await lmChatOpenAi.supplyData.call(mockContext, 0);
expect(mockedCommon.prepareAdditionalResponsesParams).toHaveBeenCalledWith(options);
expect(MockedChatOpenAI).toHaveBeenCalledWith(
expect.objectContaining({
useResponsesApi: true,
modelKwargs: mockResponsesParams,
}),
);
});
it('should attach built-in tools to model metadata (v1.3)', async () => {
const mockContext = setupMockContext({ typeVersion: 1.3 });
const builtInTools: IDataObject = {
webSearch: { searchContextSize: 'high', allowedDomains: 'google.com, wikipedia.org' },
fileSearch: { vectorStoreIds: '["vs_1"]', filters: '{}', maxResults: 2 },
codeInterpreter: true,
};
const mockTools = [
{
customTools: true,
},
];
mockContext.getNodeParameter = jest.fn().mockImplementation((paramName: string) => {
if (paramName === 'responsesApiEnabled') return true;
if (paramName === 'model.value') return 'gpt-4o-mini';
if (paramName === 'options') return {};
if (paramName === 'builtInTools') return builtInTools;
return undefined;
});
mockedCommon.formatBuiltInTools = jest.fn().mockReturnValue(mockTools);
await lmChatOpenAi.supplyData.call(mockContext, 0);
expect(mockedCommon.formatBuiltInTools).toHaveBeenCalledWith(builtInTools);
const instance: unknown = MockedChatOpenAI.mock.instances[0];
expect(instance).toBeDefined();
expect((instance as { metadata?: { tools?: unknown } }).metadata).toBeDefined();
expect((instance as { metadata?: { tools?: unknown } }).metadata?.tools).toEqual(mockTools);
});
});
});