Security: Sync from Public / sync-from-public (push) Has been cancelled
Test: Benchmark Nightly / build (push) Has been cancelled
Test: Benchmark Nightly / Notify Cats on failure (push) Has been cancelled
CI: Python / Checks (push) Has been cancelled
Test: Evals Python / Workflow Comparison Python (push) Has been cancelled
Util: Check Docs URLs / check-docs-urls (push) Has been cancelled
Test: Visual Storybook / Cloudflare Pages (push) Has been cancelled
Test: E2E Performance / build-and-test-performance (push) Has been cancelled
Test: Workflows Nightly / Run Workflow Tests (push) Has been cancelled
Util: Cleanup CI Docker Images / Delete stale CI images (push) Has been cancelled
Test: Benchmark Destroy Env / build (push) Has been cancelled
Util: Update Node Popularity / update-popularity (push) Has been cancelled
Test: E2E Coverage Weekly / Coverage Tests (push) Has been cancelled
378 lines
9.7 KiB
TypeScript
378 lines
9.7 KiB
TypeScript
import { Request } from 'mssql';
|
|
import type { IResult } from 'mssql';
|
|
import type mssql from 'mssql';
|
|
import type { IDataObject } from 'n8n-workflow';
|
|
|
|
import {
|
|
configurePool,
|
|
deleteOperation,
|
|
escapeIdentifier,
|
|
escapeTableName,
|
|
executeSqlQueryAndPrepareResults,
|
|
insertOperation,
|
|
mssqlChunk,
|
|
updateOperation,
|
|
} from '../GenericFunctions';
|
|
|
|
describe('MSSQL tests', () => {
|
|
let querySpy: jest.SpyInstance;
|
|
let request: Request;
|
|
|
|
const assertParameters = (parameters: unknown[][] | IDataObject) => {
|
|
if (Array.isArray(parameters)) {
|
|
parameters.forEach((values, rowIndex) => {
|
|
values.forEach((value, index) => {
|
|
const received = (request.parameters[`r${rowIndex}v${index}`] as IDataObject).value;
|
|
expect(received).toEqual(value);
|
|
});
|
|
});
|
|
} else {
|
|
for (const key in parameters) {
|
|
expect((request.parameters[key] as IDataObject).value).toEqual(parameters[key]);
|
|
}
|
|
}
|
|
};
|
|
|
|
beforeEach(() => {
|
|
jest.resetAllMocks();
|
|
querySpy = jest.spyOn(Request.prototype, 'query').mockImplementation(async function (
|
|
this: Request,
|
|
) {
|
|
// eslint-disable-next-line @typescript-eslint/no-this-alias
|
|
request = this;
|
|
return {
|
|
recordsets: [],
|
|
recordset: [],
|
|
output: {},
|
|
rowsAffected: [0],
|
|
} as unknown as IResult<unknown>;
|
|
});
|
|
});
|
|
|
|
it('should perform insert operation', async () => {
|
|
const pool = configurePool({});
|
|
const tables = {
|
|
users: {
|
|
'id, name, age, active': [
|
|
{
|
|
id: 1,
|
|
name: 'Sam',
|
|
age: 31,
|
|
active: false,
|
|
},
|
|
{
|
|
id: 3,
|
|
name: 'Jon',
|
|
age: null,
|
|
active: true,
|
|
},
|
|
{
|
|
id: 4,
|
|
name: undefined,
|
|
age: 25,
|
|
active: false,
|
|
},
|
|
],
|
|
},
|
|
};
|
|
|
|
await insertOperation(tables, pool);
|
|
|
|
expect(querySpy).toHaveBeenCalledTimes(1);
|
|
expect(querySpy).toHaveBeenCalledWith(
|
|
'INSERT INTO [users] ([id], [name], [age], [active]) VALUES (@r0v0, @r0v1, @r0v2, @r0v3), (@r1v0, @r1v1, @r1v2, @r1v3), (@r2v0, @r2v1, @r2v2, @r2v3);',
|
|
);
|
|
assertParameters([
|
|
[1, 'Sam', 31, false],
|
|
[3, 'Jon', null, true],
|
|
[4, null, 25, false],
|
|
]);
|
|
});
|
|
|
|
it('should perform insert operation with escaped identifiers', async () => {
|
|
const pool = configurePool({});
|
|
const tables = {
|
|
"users] set text='asdf' where id=1;": {
|
|
'id, name, age, active]': [
|
|
{
|
|
id: 1,
|
|
name: 'Sam',
|
|
age: 31,
|
|
active: false,
|
|
},
|
|
],
|
|
},
|
|
};
|
|
|
|
await insertOperation(tables, pool);
|
|
|
|
expect(querySpy).toHaveBeenCalledTimes(1);
|
|
expect(querySpy).toHaveBeenCalledWith(
|
|
"INSERT INTO [users]] set text='asdf' where id=1;] ([id], [name], [age], [active]]]) VALUES (@r0v0, @r0v1, @r0v2, @r0v3);",
|
|
);
|
|
assertParameters([[1, 'Sam', 31, false]]);
|
|
});
|
|
|
|
it('should perform update operation', async () => {
|
|
const pool = configurePool({});
|
|
const tables = {
|
|
users: {
|
|
'name, age, active': [
|
|
{
|
|
name: 'Greg',
|
|
age: 43,
|
|
active: 0,
|
|
updateKey: 'id',
|
|
id: 2,
|
|
},
|
|
],
|
|
},
|
|
};
|
|
|
|
await updateOperation(tables, pool);
|
|
|
|
expect(querySpy).toHaveBeenCalledTimes(1);
|
|
expect(querySpy).toHaveBeenCalledWith(
|
|
'UPDATE [users] SET [name] = @v0, [age] = @v1, [active] = @v2 WHERE [id] = @condition;',
|
|
);
|
|
assertParameters({
|
|
v0: 'Greg',
|
|
v1: 43,
|
|
v2: 0,
|
|
condition: 2,
|
|
});
|
|
});
|
|
|
|
it('should perform update operation with escaped identifiers', async () => {
|
|
const pool = configurePool({});
|
|
const tables = {
|
|
"users] set text='asdf' where id=1;": {
|
|
'name, age, active]': [
|
|
{
|
|
name: 'Greg',
|
|
age: 43,
|
|
active: 0,
|
|
updateKey: 'id] -- -',
|
|
id: 2,
|
|
},
|
|
],
|
|
},
|
|
};
|
|
|
|
await updateOperation(tables, pool);
|
|
|
|
expect(querySpy).toHaveBeenCalledTimes(1);
|
|
expect(querySpy).toHaveBeenCalledWith(
|
|
"UPDATE [users]] set text='asdf' where id=1;] SET [name] = @v0, [age] = @v1, [active]]] = @v2 WHERE [id]] -- -] = @condition;",
|
|
);
|
|
});
|
|
|
|
it('should perform update operation with enclosed key', async () => {
|
|
const pool = configurePool({});
|
|
const tables = {
|
|
users: {
|
|
'name, age, active': [
|
|
{
|
|
name: 'Greg',
|
|
age: 43,
|
|
active: 0,
|
|
updateKey: '[id]',
|
|
id: 2,
|
|
},
|
|
],
|
|
},
|
|
};
|
|
|
|
await updateOperation(tables, pool);
|
|
|
|
expect(querySpy).toHaveBeenCalledTimes(1);
|
|
expect(querySpy).toHaveBeenCalledWith(
|
|
'UPDATE [users] SET [name] = @v0, [age] = @v1, [active] = @v2 WHERE [id] = @condition;',
|
|
);
|
|
});
|
|
|
|
it('should perform delete operation', async () => {
|
|
const pool = configurePool({});
|
|
const tables = {
|
|
users: {
|
|
id: [
|
|
{
|
|
json: {
|
|
id: 2,
|
|
},
|
|
pairedItem: {
|
|
item: 0,
|
|
input: undefined,
|
|
},
|
|
},
|
|
],
|
|
},
|
|
};
|
|
|
|
await deleteOperation(tables, pool);
|
|
|
|
expect(querySpy).toHaveBeenCalledTimes(1);
|
|
expect(querySpy).toHaveBeenCalledWith('DELETE FROM [users] WHERE [id] IN (@v0);');
|
|
assertParameters({ v0: 2 });
|
|
});
|
|
|
|
it('should perform delete operation with escaped identifiers', async () => {
|
|
const pool = configurePool({});
|
|
const tables = {
|
|
"users] set text='asdf' where id=1;": {
|
|
'id]': [
|
|
{
|
|
json: {
|
|
id: 2,
|
|
},
|
|
pairedItem: {
|
|
item: 0,
|
|
input: undefined,
|
|
},
|
|
},
|
|
],
|
|
},
|
|
};
|
|
|
|
await deleteOperation(tables, pool);
|
|
|
|
expect(querySpy).toHaveBeenCalledTimes(1);
|
|
expect(querySpy).toHaveBeenCalledWith(
|
|
"DELETE FROM [users]] set text='asdf' where id=1;] WHERE [id]]] IN (@v0);",
|
|
);
|
|
});
|
|
|
|
describe('mssqlChunk', () => {
|
|
it('should chunk insert values correctly', () => {
|
|
const chunks = mssqlChunk(
|
|
new Array(3000)
|
|
.fill(null)
|
|
.map((_, index) => ({ id: index, name: 'John Doe', verified: true })),
|
|
);
|
|
expect(chunks.map((chunk) => chunk.length)).toEqual([699, 699, 699, 699, 204]);
|
|
});
|
|
});
|
|
|
|
describe('executeSqlQueryAndPrepareResults', () => {
|
|
it('should handle SELECT query with single record', async () => {
|
|
querySpy.mockResolvedValueOnce({
|
|
recordsets: [[{ id: 1, name: 'Test' }]] as any,
|
|
recordset: [{ id: 1, name: 'Test', columns: [{ name: 'id' }, { name: 'name' }] }],
|
|
rowsAffected: [1],
|
|
output: {},
|
|
} as unknown as IResult<unknown>);
|
|
|
|
const pool = { request: () => new Request() } as any as mssql.ConnectionPool;
|
|
const result = await executeSqlQueryAndPrepareResults(pool, 'SELECT * FROM users', 0);
|
|
|
|
expect(result).toEqual([
|
|
{
|
|
json: { id: 1, name: 'Test' },
|
|
pairedItem: [{ item: 0 }],
|
|
},
|
|
]);
|
|
expect(querySpy).toHaveBeenCalledWith('SELECT * FROM users');
|
|
});
|
|
|
|
it('should handle SELECT query with multiple records', async () => {
|
|
querySpy.mockResolvedValueOnce({
|
|
recordsets: [[{ id: 1 }], [{ name: 'Test' }]] as unknown,
|
|
rowsAffected: [1, 1],
|
|
output: {},
|
|
} as unknown as IResult<unknown>);
|
|
|
|
const pool = { request: () => new Request() } as any as mssql.ConnectionPool;
|
|
const result = await executeSqlQueryAndPrepareResults(pool, 'SELECT id; SELECT name', 1);
|
|
|
|
expect(result).toEqual([
|
|
{ json: { id: 1 }, pairedItem: [{ item: 1 }] },
|
|
{ json: { name: 'Test' }, pairedItem: [{ item: 1 }] },
|
|
]);
|
|
});
|
|
|
|
it('should handle non-SELECT query', async () => {
|
|
querySpy.mockResolvedValueOnce({
|
|
recordsets: [],
|
|
recordset: [],
|
|
rowsAffected: [5],
|
|
output: {},
|
|
} as unknown as IResult<unknown>);
|
|
|
|
const pool = { request: () => new Request() } as any as mssql.ConnectionPool;
|
|
const result = await executeSqlQueryAndPrepareResults(pool, 'UPDATE users SET active = 1', 2);
|
|
|
|
expect(result).toEqual([
|
|
{
|
|
json: { message: 'Query 1 executed successfully', rowsAffected: 5 },
|
|
pairedItem: [{ item: 2 }],
|
|
},
|
|
]);
|
|
});
|
|
|
|
it('should handle query with no affected rows', async () => {
|
|
querySpy.mockResolvedValueOnce({
|
|
recordsets: [],
|
|
recordset: [],
|
|
rowsAffected: [],
|
|
output: {},
|
|
} as unknown as IResult<unknown>);
|
|
|
|
const pool = { request: () => new Request() } as any as mssql.ConnectionPool;
|
|
const result = await executeSqlQueryAndPrepareResults(
|
|
pool,
|
|
'DELETE FROM users WHERE id = 999',
|
|
3,
|
|
);
|
|
|
|
expect(result).toEqual([
|
|
{
|
|
json: { message: 'Query executed successfully, but no rows were affected' },
|
|
pairedItem: [{ item: 3 }],
|
|
},
|
|
]);
|
|
});
|
|
|
|
it('should throw an error when query fails', async () => {
|
|
const errorMessage = 'Database error';
|
|
querySpy.mockRejectedValueOnce(new Error(errorMessage));
|
|
|
|
const pool = { request: () => new Request() } as any as mssql.ConnectionPool;
|
|
await expect(executeSqlQueryAndPrepareResults(pool, 'INVALID SQL', 4)).rejects.toThrow(
|
|
errorMessage,
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('escapeIdentifier', () => {
|
|
it('keeps outer brackets', () => {
|
|
expect(escapeIdentifier('[test]')).toEqual('[test]');
|
|
});
|
|
|
|
it('escapes content while using outer brackets', () => {
|
|
expect(escapeIdentifier('[test.hello]]')).toEqual('[test.hello]]]');
|
|
});
|
|
|
|
it('escapes content while not using outer brackets', () => {
|
|
expect(escapeIdentifier('test.hello]]')).toEqual('[test.hello]]]]]');
|
|
});
|
|
});
|
|
|
|
describe('escapeTableName', () => {
|
|
it('should escape table name correctly', () => {
|
|
expect(escapeTableName('test')).toEqual('[test]');
|
|
expect(escapeTableName('[test]')).toEqual('[test]');
|
|
expect(escapeTableName('test.test')).toEqual('[test.test]');
|
|
expect(escapeTableName('[test].[test]')).toEqual('[test].[test]');
|
|
expect(escapeTableName('[test]--.ok].[[test]]')).toEqual('[test]]--.ok].[[test]]]');
|
|
expect(escapeTableName("test] SET mytext='1' where id=2; -- -")).toEqual(
|
|
"[test]] SET mytext='1' where id=2; -- -]",
|
|
);
|
|
expect(escapeTableName("[[test] (id,text) values(1,'123'); DROP TABLE users; -- ]")).toEqual(
|
|
"[[test]] (id,text) values(1,'123'); DROP TABLE users; -- ]",
|
|
);
|
|
expect(escapeTableName('schema.[table]')).toEqual('[schema.[table]]]');
|
|
expect(escapeTableName('[schema].table')).toEqual('[[schema]].table]');
|
|
});
|
|
});
|
|
});
|