alighasami/vant
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

[bugfix] Checkbox: should not render label when label is empty (#920)

Browse Source
This commit is contained in:
neverland
2018-04-24 09:51:52 +08:00
committed by GitHub
parent 9d623a6196
commit 86184e090e
10 changed files with 63 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/specs/checkbox.spec.js
+3 -3
View File
@@ -165,7 +165,7 @@ describe('Checkbox', () => {
expect(wrapper.hasClass('van-checkbox')).to.be.true;
const eventStub = sinon.stub(wrapper.vm, '$emit');
const checkboxLabel = wrapper.find('.van-checkbox__label')[0];
const checkboxLabel = wrapper.find('.van-checkbox__icon')[0];
checkboxLabel.trigger('click');
wrapper.update();
@@ -189,7 +189,7 @@ describe('Checkbox', () => {
expect(wrapper.vm.currentValue).to.be.false;
expect(wrapper.vm.isDisabled).to.be.true;
const checkboxLabel = wrapper.find('.van-checkbox__label')[0];
const checkboxLabel = wrapper.find('.van-checkbox__icon')[0];
checkboxLabel.trigger('click');
expect(wrapper.vm.currentValue).to.be.false;
@@ -206,7 +206,7 @@ describe('Checkbox', () => {
expect(wrapper.hasClass('van-checkbox')).to.be.true;
expect(wrapper.vm.currentValue).to.be.false;
const checkboxLabel = wrapper.find('.van-checkbox__label')[0];
const checkboxLabel = wrapper.find('.van-checkbox__icon')[0];
checkboxLabel.trigger('click');
expect(wrapper.vm.currentValue).to.be.false;
test/specs/radio.spec.js
+1 -25
View File
@@ -94,29 +94,6 @@ describe('Radio', () => {
});
});
it('click on a radio label', (done) => {
wrapper = mount(Radio, {
propsData: {
value: '1',
name: '1',
disabled: false
}
});
expect(wrapper.hasClass('van-radio')).to.be.true;
const eventStub = sinon.stub(wrapper.vm, '$emit');
const checkboxLabel = wrapper.find('.van-radio__label')[0];
checkboxLabel.trigger('click');
wrapper.update();
wrapper.vm.$nextTick(() => {
expect(eventStub.calledOnce).to.be.true;
expect(eventStub.calledWith('input'));
done();
});
});
it('click on a disabled radio', () => {
wrapper = mount(Radio, {
propsData: {
@@ -131,8 +108,7 @@ describe('Radio', () => {
expect(wrapper.instance().currentValue).to.equal('1');
expect(wrapper.instance().isDisabled).to.be.true;
const checkboxLabel = wrapper.find('.van-radio__label')[0];
checkboxLabel.trigger('click');
wrapper.trigger('click');
expect(wrapper.instance().currentValue).to.equal('1');
});