[improvement] props default value (#2183)

2018-11-29 22:20:42 +08:00
parent ad5121286b
commit 916dbd9927
31 changed files with 83 additions and 167 deletions
@@ -20,6 +20,7 @@ export default create({
  mixins: [Popup],

  props: {
+    position: String,
    transition: String,
    overlay: {
      type: Boolean,
@@ -28,16 +29,12 @@ export default create({
    closeOnClickOverlay: {
      type: Boolean,
      default: true
-    },
-    position: {
-      type: String,
-      default: ''
    }
  },

  computed: {
    currentTransition() {
-      return this.transition || (this.position === '' ? 'van-fade' : `popup-slide-${this.position}`);
+      return this.transition || (this.position ? `popup-slide-${this.position}` : 'van-fade');
    }
  }
 });