[bugfix] Popup: update overlay style & class (#349)

* fix: Tabbar icon line-height

* [new feature] progress add showPivot prop

* [new feature] TabItem support vue-router

* [new feature] update document header style

* [Doc] add toast english ducoment

* [bugfix] Search box-sizing wrong

* [Doc] update vant-demo respo

* [Doc] translate theme & demo pages

* [Doc] add Internationalization document

* [bugfix] remove unnecessary props

* [fix] optimize clickoutside

* [new feature] optimize find-parent

* [new feature]: change document title accordinng to language

* [new feature] Pagination code review

* [improvement] adjust icon-font unicode

* [improvement] Icon spinner color inherit

* [improvement] icon default width

* [bugfix] DateTimePicker validate date props

* [bugfix] Tab item text ellipsis

* [improvement] optimize single line ellipsis

* [Improvement] optimzie staticClass

* [Improvement] Button: use sfc instread of jsx

* [Improvement] update actionsheet close icon style

* fix: yarn.lock

* fix: icon test cases

* [bugfix] errors during ssr

* [Improvement] SubmitBar add left slot

* [new feature] ImagePreview support manually close

* fix: ImagePreview test case

* [Doc] add switch lang button in mobile

* [bugfix] Popup overlay style update

packages/mixins/popup/Modal.vue

@@ -0,0 +1,30 @@
+<template>
+  <div
+    class="van-modal"
+    :class="className"
+    :style="style"
+    @touchmove.prevent.stop
+    @click="$emit('click', $event)"
+  />
+</template>
+
+<script>
+export default {
+  name: 'van-modal',
+
+  props: {
+    zIndex: Number,
+    className: String,
+    customStyle: Object,
+  },
+
+  computed: {
+    style() {
+      return {
+        zIndex: this.zIndex,
+        ...this.customStyle
+      }
+    }
+  }
+};
+</script>

packages/mixins/popup/index.js

@@ -112,9 +112,10 @@ export default {
           id: this._popupId,
           zIndex: context.plusKeyByOne('zIndex'),
           dom: this.$el,
-          extraClass: this.overlayClass,
-          extraStyle: this.overlayStyle
+          className: this.overlayClass,
+          customStyle: this.overlayStyle
         });
+
         if (this.lockOnScroll) {
           document.body.classList.add('van-overflow-hidden');
         }

packages/mixins/popup/popup-context.js

@@ -2,14 +2,14 @@ const PopupContext = {
   idSeed: 1,
   zIndex: 2000,
   instances: {},
-  modalStack: [],
+  stack: [],
 
   plusKeyByOne(key) {
     return this[key]++;
   },
 
-  get topModal() {
-    return this.modalStack[this.modalStack.length - 1];
+  get top() {
+    return this.stack[this.stack.length - 1];
   }
 };
 

packages/mixins/popup/popup-manager.js

@@ -1,17 +1,22 @@
+import Vue from 'vue';
+import Modal from './Modal';
 import context from './popup-context';
 
+const modalDefaultConfig = {
+  className: '',
+  customStyle: {}
+};
+
 const PopupManager = {
   getModal() {
     let { modal } = context;
 
     if (!modal) {
-      modal = document.createElement('div');
-      modal.classList.add('van-modal');
-      modal.addEventListener('touchmove', event => {
-        event.preventDefault();
-        event.stopPropagation();
+      const ModalConstructor = Vue.extend(Modal);
+      modal = new ModalConstructor({
+        el: document.createElement('div')
       });
-      modal.addEventListener('click', () => {
+      modal.$on('click', () => {
         PopupManager.handleOverlayClick();
       });
 
@@ -23,52 +28,56 @@ const PopupManager = {
 
   // close popup when click modal && closeOnClickOverlay is true
   handleOverlayClick() {
-    const { topModal } = context;
-    if (topModal) {
-      const instance = context.instances[topModal.id];
+    const { top } = context;
+    if (top) {
+      const instance = context.instances[top.id];
       if (instance && instance.closeOnClickOverlay) {
         instance.close();
       }
     }
   },
 
-  openModal({ id, zIndex, dom, extraClass, extraStyle }) {
-    const { modalStack } = context;
-    const exist = modalStack.some(item => item.id === id);
+  openModal(config) {
+    const { id, dom } = config;
+    const exist = context.stack.some(item => item.id === id);
 
     if (!exist) {
-      const modal = this.getModal();
-      if (extraClass) {
-        modal.classList.add(extraClass);
-      }
-      if (extraStyle) {
-        modal.style.cssText = `${modal.style.cssText} ${extraStyle}`;
-      }
-      modal.style.zIndex = zIndex;
-
-      const parentNode = dom && dom.parentNode && dom.parentNode.nodeType !== 11 ? dom.parentNode : document.body;
-      parentNode.appendChild(modal);
-      modalStack.push({ id, zIndex, parentNode });
+      const targetNode = dom && dom.parentNode && dom.parentNode.nodeType !== 11 ? dom.parentNode : document.body;
+      context.stack.push({ id, config, targetNode });
+      this.updateModal();
     };
   },
 
   closeModal(id) {
-    const { modalStack } = context;
+    const { stack } = context;
 
-    if (modalStack.length) {
-      if (context.topModal.id === id) {
-        const modal = this.getModal();
-        modalStack.pop();
-        modal.parentNode.removeChild(modal);
-        if (modalStack.length) {
-          const { topModal } = context;
-          modal.style.zIndex = topModal.zIndex;
-          topModal.parentNode.appendChild(modal);
-        }
+    if (stack.length) {
+      if (context.top.id === id) {
+        stack.pop();
+        this.updateModal();
       } else {
-        context.modalStack = modalStack.filter(item => item.id !== id);
+        context.stack = stack.filter(item => item.id !== id);
       }
     }
+  },
+
+  updateModal() {
+    const modal = this.getModal();
+    const el = modal.$el;
+
+    if (el.parentNode) {
+      el.parentNode.removeChild(el);
+    }
+
+    if (context.top) {
+      const { targetNode, config } = context.top;
+
+      targetNode.appendChild(el);
+      Object.assign(modal, {
+        ...modalDefaultConfig,
+        ...config
+      });
+    }
   }
 };