chore(Icon): improve perf

This commit is contained in:
陈嘉涵
2019-12-29 08:35:57 +08:00
committed by neverland
parent 3731597520
commit dd8559a2aa
4 changed files with 12 additions and 17 deletions
+1
View File
@@ -5,5 +5,6 @@
&__image {
width: 1em;
height: 1em;
object-fit: contain;
}
}
+5 -5
View File
@@ -1,7 +1,6 @@
import { createNamespace, addUnit } from '../utils';
import { inherit } from '../utils/functional';
import Info from '../info';
import Image from '../image';
// Types
import { CreateElement, RenderContext } from 'vue/types';
@@ -43,7 +42,10 @@ function Icon(
return (
<props.tag
class={[props.classPrefix, imageIcon ? '' : `${props.classPrefix}-${name}`]}
class={[
props.classPrefix,
imageIcon ? '' : `${props.classPrefix}-${name}`
]}
style={{
color: props.color,
fontSize: addUnit(props.size)
@@ -51,9 +53,7 @@ function Icon(
{...inherit(ctx, true)}
>
{slots.default && slots.default()}
{imageIcon && (
<Image class={bem('image')} fit="contain" src={name} showLoading={false} />
)}
{imageIcon && <img class={bem('image')} src={name} />}
<Info dot={props.dot} info={props.info} />
</props.tag>
);
@@ -17,17 +17,13 @@ exports[`render icon with builtin icon name 1`] = `
`;
exports[`render icon with local image 1`] = `
<i class="van-icon">
<div class="van-image van-icon__image"><img src="/assets/icon.jpg" class="van-image__img" style="object-fit: contain;"></div>
<!---->
</i>
<i class="van-icon"><img src="/assets/icon.jpg" class="van-icon__image">
<!----></i>
`;
exports[`render icon with url name 1`] = `
<i class="van-icon">
<div class="van-image van-icon__image"><img src="https://img.yzcdn.com/icon.jpg" class="van-image__img" style="object-fit: contain;"></div>
<!---->
</i>
<i class="van-icon"><img src="https://img.yzcdn.com/icon.jpg" class="van-icon__image">
<!----></i>
`;
exports[`size without unit 1`] = `