From 06851e6894dfc5c0c47a13d0ae142b415deb1bfc Mon Sep 17 00:00:00 2001
From: braks <78412429+bcakmakoglu@users.noreply.github.com>
Date: Sat, 19 Aug 2023 00:53:44 +0200
Subject: [PATCH] fix(node-resizer): enforce min/max width/height on nodes

---
 packages/node-resizer/src/NodeResizer.vue   | 56 ++++++++++++++++++++-
 packages/node-resizer/src/ResizeControl.vue | 36 +++++++------
 packages/node-resizer/src/types.ts          |  2 +-
 3 files changed, 72 insertions(+), 22 deletions(-)

diff --git a/packages/node-resizer/src/NodeResizer.vue b/packages/node-resizer/src/NodeResizer.vue
index f847babe..810ad91c 100644
--- a/packages/node-resizer/src/NodeResizer.vue
+++ b/packages/node-resizer/src/NodeResizer.vue
@@ -1,10 +1,13 @@
 <script lang="ts" setup>
 // todo: add plugin to emit resize events via vue flow store; requires plugin API to be added to core
+import { computed, inject, watch } from 'vue'
+import type { NodeDimensionChange } from '@vue-flow/core'
+import { NodeIdInjection, useVueFlow } from '@vue-flow/core'
 import ResizeControl from './ResizeControl.vue'
 import type { ControlLinePosition, ControlPosition, NodeResizerProps, OnResize, OnResizeStart } from './types'
 import { ResizeControlVariant } from './types'
 
-withDefaults(defineProps<NodeResizerProps>(), {
+const props = withDefaults(defineProps<NodeResizerProps>(), {
   isVisible: true,
 })
 
@@ -14,9 +17,58 @@ const emits = defineEmits<{
   (event: 'resizeEnd', resizeEvent: OnResizeStart): void
 }>()
 
+const { findNode, emits: triggerEmits } = useVueFlow()
+
 const handleControls: ControlPosition[] = ['top-left', 'top-right', 'bottom-left', 'bottom-right']
 
 const lineControls: ControlLinePosition[] = ['top', 'right', 'bottom', 'left']
+
+const contextNodeId = inject(NodeIdInjection, null)
+
+const id = computed(() => (typeof props.nodeId === 'string' ? props.nodeId : contextNodeId))
+
+watch(
+  [() => props.minWidth, () => props.minHeight, () => props.maxWidth, () => props.maxHeight],
+  ([minWidth, minHeight, maxWidth, maxHeight]) => {
+    const node = findNode(id.value)
+
+    if (node) {
+      const dimensionChange: NodeDimensionChange = {
+        id: node.id,
+        type: 'dimensions',
+        updateStyle: true,
+        dimensions: {
+          width: node.dimensions.width,
+          height: node.dimensions.height,
+        },
+      }
+
+      if (minWidth && node.dimensions.width < minWidth) {
+        dimensionChange.dimensions!.width = minWidth
+      }
+
+      if (minHeight && node.dimensions.height < minHeight) {
+        dimensionChange.dimensions!.height = minHeight
+      }
+
+      if (maxWidth && node.dimensions.width > maxWidth) {
+        dimensionChange.dimensions!.width = maxWidth
+      }
+
+      if (maxHeight && node.dimensions.height > maxHeight) {
+        dimensionChange.dimensions!.height = maxHeight
+      }
+
+      if (
+        dimensionChange.dimensions!.width !== node.dimensions.width ||
+        dimensionChange.dimensions!.height !== node.dimensions.height
+      ) {
+        triggerEmits.nodesChange([dimensionChange])
+      }
+    }
+  },
+  { flush: 'post', immediate: true },
+)
 </script>
 
 <script lang="ts">
@@ -54,7 +106,7 @@ export default {
       :key="c"
       :class="handleClassName"
       :style="handleStyle"
-      :node-id="nodeId"
+      :node-id="id"
       :position="c"
       :color="color"
       :min-width="minWidth"
diff --git a/packages/node-resizer/src/ResizeControl.vue b/packages/node-resizer/src/ResizeControl.vue
index 51ecb93f..77c8b33f 100644
--- a/packages/node-resizer/src/ResizeControl.vue
+++ b/packages/node-resizer/src/ResizeControl.vue
@@ -1,9 +1,9 @@
 <script lang="ts" setup>
 import type { NodeChange, NodeDimensionChange, NodePositionChange } from '@vue-flow/core'
-import { NodeIdInjection, clamp, useGetPointerPosition, useVueFlow } from '@vue-flow/core'
+import { clamp, useGetPointerPosition, useVueFlow } from '@vue-flow/core'
 import { select } from 'd3-selection'
 import { drag } from 'd3-drag'
-import { computed, inject, ref, watchEffect } from 'vue'
+import { computed, ref, watchEffect } from 'vue'
 import type { OnResize, OnResizeStart, ResizeControlProps, ResizeDragEvent } from './types'
 import { ResizeControlVariant } from './types'
 import { getDirection } from './utils'
@@ -36,22 +36,18 @@ const { findNode, emits: triggerEmits } = useVueFlow()
 
 const getPointerPosition = useGetPointerPosition()
 
-const contextNodeId = inject(NodeIdInjection, null)
-
 const resizeControlRef = ref<HTMLDivElement>()
 
 let startValues: typeof initStartValues = initStartValues
 
 let prevValues: typeof initPrevValues = initPrevValues
 
-const id = computed(() => (typeof props.nodeId === 'string' ? props.nodeId : contextNodeId))
-
 const defaultPosition = computed(() => (props.variant === ResizeControlVariant.Line ? 'right' : 'bottom-right'))
 
 const controlPosition = computed(() => props.position ?? defaultPosition.value)
 
 watchEffect((onCleanup) => {
-  if (!resizeControlRef.value || !id.value) {
+  if (!resizeControlRef.value || !props.nodeId) {
     return
   }
 
@@ -64,7 +60,7 @@ watchEffect((onCleanup) => {
 
   const dragHandler = drag<HTMLDivElement, unknown>()
     .on('start', (event: ResizeDragEvent) => {
-      const node = findNode(id.value!)
+      const node = findNode(props.nodeId)
       const { xSnapped, ySnapped } = getPointerPosition(event)
 
       prevValues = {
@@ -85,7 +81,7 @@ watchEffect((onCleanup) => {
     })
     .on('drag', (event: ResizeDragEvent) => {
       const { xSnapped, ySnapped } = getPointerPosition(event)
-      const node = findNode(id.value!)
+      const node = findNode(props.nodeId)
 
       if (node) {
         const changes: NodeChange[] = []
@@ -168,9 +164,9 @@ watchEffect((onCleanup) => {
           }
         }
 
-        if (isWidthChange || isHeightChange) {
+        if (props.nodeId && (isWidthChange || isHeightChange)) {
           const dimensionChange: NodeDimensionChange = {
-            id: id.value!,
+            id: props.nodeId,
             type: 'dimensions',
             updateStyle: true,
             resizing: true,
@@ -213,15 +209,17 @@ watchEffect((onCleanup) => {
       }
     })
     .on('end', (event: ResizeDragEvent) => {
-      const dimensionChange: NodeDimensionChange = {
-        id: id.value!,
-        type: 'dimensions',
-        resizing: false,
+      if (props.nodeId) {
+        const dimensionChange: NodeDimensionChange = {
+          id: props.nodeId,
+          type: 'dimensions',
+          resizing: false,
+        }
+
+        emits('resizeEnd', { event, params: prevValues })
+
+        triggerEmits.nodesChange([dimensionChange])
       }
-
-      emits('resizeEnd', { event, params: prevValues })
-
-      triggerEmits.nodesChange([dimensionChange])
     })
 
   selection.call(dragHandler)
diff --git a/packages/node-resizer/src/types.ts b/packages/node-resizer/src/types.ts
index 71cad94f..98bafb09 100644
--- a/packages/node-resizer/src/types.ts
+++ b/packages/node-resizer/src/types.ts
@@ -63,7 +63,7 @@ export enum ResizeControlVariant {
 }
 
 export interface ResizeControlProps {
-  nodeId?: string
+  nodeId?: string | null
   color?: string
   minWidth?: number
   minHeight?: number