From 13d3be9c332de90bc3dc7460e7ee099a062f663e Mon Sep 17 00:00:00 2001 From: braks <78412429+bcakmakoglu@users.noreply.github.com> Date: Fri, 12 May 2023 07:58:31 +0200 Subject: [PATCH] chore(core): cleanup unnecessary refs --- .../core/src/components/Edges/EdgeWrapper.ts | 16 ++++++++-------- packages/core/src/composables/useKeyPress.ts | 16 ++++++++-------- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/packages/core/src/components/Edges/EdgeWrapper.ts b/packages/core/src/components/Edges/EdgeWrapper.ts index 1dba5451..2cb4a7b6 100644 --- a/packages/core/src/components/Edges/EdgeWrapper.ts +++ b/packages/core/src/components/Edges/EdgeWrapper.ts @@ -36,9 +36,9 @@ const EdgeWrapper = defineComponent({ const edge = $(useVModel(props, 'edge')) - let mouseOver = $ref(false) + const mouseOver = ref(false) - let updating = $ref(false) + const updating = ref(false) const nodeId = ref('') @@ -120,7 +120,7 @@ const EdgeWrapper = defineComponent({ noPanClassName.value, edgeClass, { - updating: mouseOver, + updating: mouseOver.value, selected: edge.selected, animated: edge.animated, inactive: !props.selectable, @@ -139,7 +139,7 @@ const EdgeWrapper = defineComponent({ 'role': props.focusable ? 'button' : undefined, }, [ - updating + updating.value ? null : h(props.type === false ? getEdgeTypes.value.default : props.type, { id: props.id, @@ -220,11 +220,11 @@ const EdgeWrapper = defineComponent({ } function onEdgeUpdaterMouseEnter() { - mouseOver = true + mouseOver.value = true } function onEdgeUpdaterMouseOut() { - mouseOver = false + mouseOver.value = false } function onEdgeUpdate(event: MouseTouchEvent, connection: Connection) { @@ -233,7 +233,7 @@ const EdgeWrapper = defineComponent({ function onEdgeUpdateEnd(event: MouseTouchEvent) { hooks.emit.updateEnd({ event, edge }) - updating = false + updating.value = false } function handleEdgeUpdater(event: MouseEvent, isSourceHandle: boolean) { @@ -241,7 +241,7 @@ const EdgeWrapper = defineComponent({ return } - updating = true + updating.value = true nodeId.value = isSourceHandle ? edge.target : edge.source handleId.value = (isSourceHandle ? edge.targetHandle : edge.sourceHandle) ?? '' diff --git a/packages/core/src/composables/useKeyPress.ts b/packages/core/src/composables/useKeyPress.ts index f0a502e7..d8c332fb 100644 --- a/packages/core/src/composables/useKeyPress.ts +++ b/packages/core/src/composables/useKeyPress.ts @@ -43,9 +43,9 @@ export default (keyFilter: MaybeComputedRef, onChange?: (keyPr const isPressed = ref(resolveUnref(keyFilter) === true) - const modifierPressed = ref(false) + let modifierPressed = false - const pressedKeys = ref>(new Set()) + const pressedKeys = new Set() watch(isPressed, () => { onChange?.(isPressed.value) @@ -66,16 +66,16 @@ export default (keyFilter: MaybeComputedRef, onChange?: (keyPr } if (Array.isArray(unrefKeyFilter)) { - unrefKeyFilter = createKeyPredicate(unrefKeyFilter, pressedKeys.value) + unrefKeyFilter = createKeyPredicate(unrefKeyFilter, pressedKeys) } if (unrefKeyFilter) { onKeyStroke( unrefKeyFilter, (e) => { - modifierPressed.value = wasModifierPressed(e) + modifierPressed = wasModifierPressed(e) - if (!modifierPressed.value && isInputDOMNode(e)) { + if (!modifierPressed && isInputDOMNode(e)) { return } @@ -90,13 +90,13 @@ export default (keyFilter: MaybeComputedRef, onChange?: (keyPr unrefKeyFilter, (e) => { if (isPressed.value) { - if (!modifierPressed.value && isInputDOMNode(e)) { + if (!modifierPressed && isInputDOMNode(e)) { return } - modifierPressed.value = false + modifierPressed = false - pressedKeys.value.clear() + pressedKeys.clear() isPressed.value = false }