From 325efba85645ca58183a259287a06b3a16dc0727 Mon Sep 17 00:00:00 2001 From: braks <78412429+bcakmakoglu@users.noreply.github.com> Date: Fri, 24 Feb 2023 16:03:38 +0100 Subject: [PATCH] refactor(core): use lifecycle hooks to observe node dimensions Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com> --- .../core/src/components/Nodes/NodeWrapper.vue | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/packages/core/src/components/Nodes/NodeWrapper.vue b/packages/core/src/components/Nodes/NodeWrapper.vue index 959d3006..0d90d485 100644 --- a/packages/core/src/components/Nodes/NodeWrapper.vue +++ b/packages/core/src/components/Nodes/NodeWrapper.vue @@ -92,16 +92,13 @@ onUpdateNodeInternals((updateIds) => { } }) -watchEffect( - (onCleanup) => { - if (!node.hidden && nodeElement.value) { - props.resizeObserver.observe(nodeElement.value as HTMLDivElement) +onMounted(() => { + props.resizeObserver.observe(nodeElement.value as HTMLDivElement) +}) - onCleanup(() => props.resizeObserver.unobserve(nodeElement.value as HTMLDivElement)) - } - }, - { flush: 'post' }, -) +onBeforeUnmount(() => { + props.resizeObserver.unobserve(nodeElement.value as HTMLDivElement) +}) watch( [() => node.type, () => node.sourcePosition, () => node.targetPosition],