From 4effbb00086b29750cffdbb0bd2abceb688804e8 Mon Sep 17 00:00:00 2001
From: braks <78412429+bcakmakoglu@users.noreply.github.com>
Date: Wed, 19 Jun 2024 18:17:57 +0200
Subject: [PATCH] refactor(core): use pointer evts in pane and prevent cancel
 of selection

---
 packages/core/src/container/Pane/Pane.vue     | 130 ++++++++----------
 .../core/src/container/Viewport/Viewport.vue  |   1 +
 2 files changed, 60 insertions(+), 71 deletions(-)

diff --git a/packages/core/src/container/Pane/Pane.vue b/packages/core/src/container/Pane/Pane.vue
index aae5f9b1..e4bf28b3 100644
--- a/packages/core/src/container/Pane/Pane.vue
+++ b/packages/core/src/container/Pane/Pane.vue
@@ -1,14 +1,13 @@
 <script lang="ts" setup>
-import { ref, toRef } from 'vue'
+import { ref, toRef, watch } from 'vue'
 import UserSelection from '../../components/UserSelection/UserSelection.vue'
 import NodesSelection from '../../components/NodesSelection/NodesSelection.vue'
-import type { GraphNode } from '../../types'
-import { SelectionMode } from '../../types'
+import { type GraphNode, SelectionMode } from '../../types'
 import { useKeyPress, useVueFlow } from '../../composables'
 import { getConnectedEdges, getNodesInside } from '../../utils'
 import { getMousePosition } from './utils'
 
-const { isSelecting } = defineProps<{ isSelecting: boolean }>()
+const { isSelecting, selectionKeyPressed } = defineProps<{ isSelecting: boolean; selectionKeyPressed: boolean }>()
 
 const {
   vueFlowRef,
@@ -43,41 +42,44 @@ const containerBounds = ref<DOMRect>()
 
 const hasActiveSelection = toRef(() => elementsSelectable.value && (isSelecting || userSelectionActive.value))
 
-useKeyPress(
-  deleteKeyCode,
-  (keyPressed) => {
-    if (!keyPressed) {
-      return
+// Used to prevent click events when the user lets go of the selectionKey during a selection
+const selectionInProgress = ref(false)
+
+const deleteKeyPressed = useKeyPress(deleteKeyCode, { actInsideInputWithModifier: false })
+
+const multiSelectKeyPressed = useKeyPress(multiSelectionKeyCode)
+
+watch(deleteKeyPressed, (isKeyPressed) => {
+  if (!isKeyPressed) {
+    return
+  }
+
+  const nodesToRemove: GraphNode[] = []
+  for (const node of getNodes.value) {
+    if (!node.selected && node.parentNode && nodesToRemove.some((n) => n.id === node.parentNode)) {
+      nodesToRemove.push(node)
+    } else if (node.selected) {
+      nodesToRemove.push(node)
+    }
+  }
+
+  if (nodesToRemove || getSelectedEdges.value) {
+    if (getSelectedEdges.value.length > 0) {
+      removeEdges(getSelectedEdges.value)
     }
 
-    const nodesToRemove: GraphNode[] = []
-    for (const node of getNodes.value) {
-      if (!node.selected && node.parentNode && nodesToRemove.some((n) => n.id === node.parentNode)) {
-        nodesToRemove.push(node)
-      } else if (node.selected) {
-        nodesToRemove.push(node)
-      }
+    if (nodesToRemove.length > 0) {
+      removeNodes(nodesToRemove)
     }
 
-    if (nodesToRemove || getSelectedEdges.value) {
-      if (getSelectedEdges.value.length > 0) {
-        removeEdges(getSelectedEdges.value)
-      }
+    nodesSelectionActive.value = false
 
-      if (nodesToRemove.length > 0) {
-        removeNodes(nodesToRemove)
-      }
+    removeSelectedElements()
+  }
+})
 
-      nodesSelectionActive.value = false
-
-      removeSelectedElements()
-    }
-  },
-  { actInsideInputWithModifier: false },
-)
-
-useKeyPress(multiSelectionKeyCode, (keyPressed) => {
-  multiSelectionActive.value = keyPressed
+watch(multiSelectKeyPressed, (isKeyPressed) => {
+  multiSelectionActive.value = isKeyPressed
 })
 
 function resetUserSelection() {
@@ -89,7 +91,8 @@ function resetUserSelection() {
 }
 
 function onClick(event: MouseEvent) {
-  if (event.target !== container.value || hasActiveSelection.value) {
+  if (selectionInProgress.value || event.target !== container.value || hasActiveSelection.value) {
+    selectionInProgress.value = false
     return
   }
 
@@ -121,8 +124,9 @@ function onWheel(event: WheelEvent) {
   emits.paneScroll(event)
 }
 
-function onMouseDown(event: MouseEvent) {
-  containerBounds.value = vueFlowRef.value!.getBoundingClientRect()
+function onPointerDown(event: PointerEvent) {
+  containerBounds.value = vueFlowRef.value?.getBoundingClientRect()
+  container.value?.setPointerCapture(event.pointerId)
 
   if (
     !hasActiveSelection.value ||
@@ -153,26 +157,19 @@ function onMouseDown(event: MouseEvent) {
   emits.selectionStart(event)
 }
 
-function onMouseMove(event: MouseEvent) {
+function onPointerMove(event: PointerEvent) {
   if (!hasActiveSelection.value) {
     return emits.paneMouseMove(event)
   }
 
-  if (!isSelecting || !containerBounds.value || !userSelectionRect.value) {
+  if (!containerBounds.value || !userSelectionRect.value) {
     return
   }
 
-  if (!userSelectionActive.value) {
-    userSelectionActive.value = true
-  }
-
-  if (nodesSelectionActive.value) {
-    nodesSelectionActive.value = false
-  }
+  selectionInProgress.value = true
 
   const mousePos = getMousePosition(event, containerBounds.value)
-  const startX = userSelectionRect.value.startX ?? 0
-  const startY = userSelectionRect.value.startY ?? 0
+  const { startX = 0, startY = 0 } = userSelectionRect.value
 
   const nextUserSelectRect = {
     ...userSelectionRect.value,
@@ -187,6 +184,7 @@ function onMouseMove(event: MouseEvent) {
     userSelectionRect.value,
     viewport.value,
     selectionMode.value === SelectionMode.Partial,
+    true,
   )
 
   const selectedEdges = getConnectedEdges(selectedNodes, getEdges.value)
@@ -199,14 +197,12 @@ function onMouseMove(event: MouseEvent) {
   addSelectedElements([...selectedNodes, ...selectedEdges])
 }
 
-function onMouseUp(event: MouseEvent) {
-  if (!hasActiveSelection.value) {
+function onPointerUp(event: PointerEvent) {
+  if (!hasActiveSelection.value || event.button !== 0) {
     return
   }
 
-  if (event.button !== 0) {
-    return
-  }
+  container.value?.releasePointerCapture(event.pointerId)
 
   // We only want to trigger click functions when in selection mode if
   // the user did not move the mouse.
@@ -219,22 +215,15 @@ function onMouseUp(event: MouseEvent) {
   resetUserSelection()
 
   emits.selectionEnd(event)
+
+  // If the user kept holding the selectionKey during the selection,
+  // we need to reset the selectionInProgress, so the next click event is not prevented
+  if (selectionKeyPressed) {
+    selectionInProgress.value = false
+  }
 }
 
-function onMouseLeave(event: MouseEvent) {
-  if (!hasActiveSelection.value) {
-    return emits.paneMouseLeave(event)
-  }
-
-  if (userSelectionActive.value) {
-    nodesSelectionActive.value = prevSelectedNodesCount.value > 0
-    emits.selectionEnd?.(event)
-  }
-
-  resetUserSelection()
-}
-
-function onMouseEnter(event: MouseEvent) {
+function onPointerEnter(event: PointerEvent) {
   if (hasActiveSelection.value) {
     return
   }
@@ -258,11 +247,10 @@ export default {
     @click="onClick"
     @contextmenu="onContextMenu"
     @wheel.passive="onWheel"
-    @mouseenter="onMouseEnter"
-    @mousedown="onMouseDown"
-    @mousemove="onMouseMove"
-    @mouseup="onMouseUp"
-    @mouseleave="onMouseLeave"
+    @pointerenter="onPointerEnter"
+    @pointerdown="onPointerDown"
+    @pointermove="onPointerMove"
+    @pointerup="onPointerUp"
   >
     <slot />
     <UserSelection v-if="userSelectionActive && userSelectionRect" :user-selection-rect="userSelectionRect" />
diff --git a/packages/core/src/container/Viewport/Viewport.vue b/packages/core/src/container/Viewport/Viewport.vue
index bf03dc65..b993402c 100644
--- a/packages/core/src/container/Viewport/Viewport.vue
+++ b/packages/core/src/container/Viewport/Viewport.vue
@@ -403,6 +403,7 @@ export default {
   <div ref="viewportRef" class="vue-flow__viewport vue-flow__container">
     <Pane
       :is-selecting="isSelecting"
+      :selection-key-pressed="selectionKeyPressed"
       :class="{ connecting: !!connectionStartHandle, dragging: paneDragging, draggable: shouldPanOnDrag }"
     >
       <Transform>