From 627cbf65a88d86d60d4bdde71fa8dd7dbc2b66ea Mon Sep 17 00:00:00 2001 From: braks <78412429+bcakmakoglu@users.noreply.github.com> Date: Wed, 17 May 2023 11:10:13 +0200 Subject: [PATCH] refactor(core): remove unnecessary computed var --- packages/core/src/composables/useHandle.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/core/src/composables/useHandle.ts b/packages/core/src/composables/useHandle.ts index ce1eb36a..c1383855 100644 --- a/packages/core/src/composables/useHandle.ts +++ b/packages/core/src/composables/useHandle.ts @@ -24,8 +24,6 @@ export default function useHandle({ onEdgeUpdate, onEdgeUpdateEnd, }: UseHandleProps) { - const isTarget = computed(() => resolveUnref(type) === 'target') - const { vueFlowRef, connectionMode, @@ -51,6 +49,8 @@ export default function useHandle({ let handleDomNode: Element | null = null function handlePointerDown(event: MouseTouchEvent) { + const isTarget = resolveUnref(type) === 'target' + const isMouseTriggered = isMouseEvent(event) // when vue-flow is used inside a shadow root we can't use document @@ -136,7 +136,7 @@ export default function useHandle({ connectionMode.value, resolveUnref(nodeId), resolveUnref(handleId), - isTarget.value ? 'target' : 'source', + isTarget ? 'target' : 'source', isValidConnectionHandler, doc, edges.value, @@ -223,6 +223,8 @@ export default function useHandle({ return } + const isTarget = resolveUnref(type) === 'target' + if (!connectionClickStartHandle.value) { emits.clickConnectStart({ event, nodeId: resolveUnref(nodeId), handleId: resolveUnref(handleId) })