alighasami/vue-flow
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(core): check if starting handle exists

Browse Source
This commit is contained in:
braks
2024-06-06 10:45:38 +02:00
committed by Braks
parent 688f886f9b
commit 660831cc37
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/components/ConnectionLine/index.ts
+4 -3
View File
@@ -45,11 +45,11 @@ const ConnectionLine = defineComponent({
return null return null
} }
const handleId = connectionStartHandle.value.handleId const startHandleId = connectionStartHandle.value.handleId
const handleType = connectionStartHandle.value.type const handleType = connectionStartHandle.value.type
const targetNode = (connectionEndHandle.value?.handleId && findNode(connectionEndHandle.value.nodeId)) || null const targetNode = (connectionEndHandle.value && findNode(connectionEndHandle.value.nodeId)) || null
const toX = (connectionPosition.value.x - viewport.value.x) / viewport.value.zoom const toX = (connectionPosition.value.x - viewport.value.x) / viewport.value.zoom
const toY = (connectionPosition.value.y - viewport.value.y) / viewport.value.zoom const toY = (connectionPosition.value.y - viewport.value.y) / viewport.value.zoom
@@ -65,7 +65,7 @@ const ConnectionLine = defineComponent({
return null return null
} }
const fromHandle = (handleId ? handleBounds.find((d) => d.id === handleId) : handleBounds[0]) ?? null const fromHandle = (startHandleId ? handleBounds.find((d) => d.id === startHandleId) : handleBounds[0]) ?? null
const fromPosition = fromHandle?.position || Position.Top const fromPosition = fromHandle?.position || Position.Top
const { x: fromX, y: fromY } = getHandlePosition( const { x: fromX, y: fromY } = getHandlePosition(
fromPosition, fromPosition,
@@ -73,6 +73,7 @@ const ConnectionLine = defineComponent({
fromHandle, fromHandle,
) )
// todo: this is a bit of a mess, we should refactor this
const toHandle = const toHandle =
(targetNode && (targetNode &&
connectionEndHandle.value?.handleId && connectionEndHandle.value?.handleId &&