tests: update nodes tests

tests/cypress/component/1-store/nodes/addNodes.cy.ts

@@ -22,7 +22,25 @@ describe('Store Action: `addNodes`', () => {
     expect(store.nodes.value).to.have.length(nodes.length + initialNodes.length)
   })
 
-  it('adds nodes to viewpane', () => {
+  it('adds nodes to view', () => {
     cy.get('.vue-flow__node').should('have.length', nodes.length + initialNodes.length)
   })
+
+  it('adds nodes to DOM', () => {
+    cy.get('.vue-flow__node').then((els) => {
+      els.each((index, node) => {
+        const nodeId = node.getAttribute('data-id')
+        const storedNode = store.findNode(nodeId)
+
+        expect(storedNode).to.not.eq(undefined)
+        expect(storedNode?.id).to.eq(nodeId)
+      })
+    })
+  })
+
+  it('does not add invalid nodes', () => {
+    // @ts-expect-error invalid nodes
+    store.addNodes([null, undefined, '', 0, false, true, {}, []])
+    expect(store.nodes.value).to.have.length(nodes.length + initialNodes.length)
+  })
 })

tests/cypress/component/1-store/nodes/addSelectedNodes.cy.ts

@@ -33,14 +33,10 @@ describe('Store Action: `addSelectedNodes`', () => {
 
         if (index < randomNumber) {
           expect(!!storedNode?.selected).to.eq(true)
-          cy.tryAssertion(() => {
-            expect(node).to.have.class('selected')
-          })
+          expect(node).to.have.class('selected')
         } else {
           expect(!!storedNode?.selected).to.eq(false)
-          cy.tryAssertion(() => {
-            expect(node).to.not.have.class('selected')
-          })
+          expect(node).to.not.have.class('selected')
         }
       })
     })

tests/cypress/component/1-store/nodes/findNode.cy.ts

@@ -20,10 +20,27 @@ describe('Store Action: `findNode`', () => {
 
   it('finds node in store', () => {
     const storedNode = store.findNode(nodes[randomIndex].id)
-    expect(storedNode?.id).to.equal(nodes[randomIndex].id)
+
+    if (!storedNode) {
+      throw new Error('Node not found in store')
+    }
+
+    expect(storedNode.id).to.equal(nodes[randomIndex].id)
   })
 
   it('does not find node in store when passed invalid id', () => {
-    expect(store.findNode('-123')).to.equal(undefined)
+    expect(store.findNode('some-invalid-id')).to.equal(undefined)
+  })
+
+  it('does not find node in store when passed undefined', () => {
+    expect(store.findNode(undefined)).to.equal(undefined)
+  })
+
+  it('does not find node in store when passed empty string', () => {
+    expect(store.findNode('')).to.equal(undefined)
+  })
+
+  it('does not find node in store when passed number', () => {
+    expect(store.findNode(123 as any)).to.equal(undefined)
   })
 })

tests/cypress/component/1-store/nodes/removeNodes.cy.ts

@@ -5,7 +5,7 @@ const { nodes, edges } = getElements()
 
 describe('Store Action: `removeNodes`', () => {
   const store = useVueFlow({ id: 'test' })
-  let randomNumber: number
+  let deletedNodes: string[]
 
   beforeEach(() => {
     cy.vueFlow({
@@ -15,18 +15,28 @@ describe('Store Action: `removeNodes`', () => {
   })
 
   beforeEach(() => {
-    randomNumber = Math.floor(Math.random() * nodes.length)
-    store.removeNodes(Array.from({ length: randomNumber }, (_, i) => nodes[i].id))
+    const randomNumber = Math.floor(Math.random() * nodes.length)
+    deletedNodes = Array.from({ length: randomNumber }, (_, i) => nodes[i].id)
+    store.removeNodes(deletedNodes)
   })
 
   it('removes nodes from store', () => {
-    expect(store.nodes.value).to.have.length(nodes.length - randomNumber)
+    expect(store.nodes.value).to.have.length(nodes.length - deletedNodes.length)
   })
 
-  it('removes nodes from viewpane', () => {
-    cy.get('.vue-flow__node').should('have.length', nodes.length - randomNumber)
-    cy.get('.vue-flow__node').each(($el, index) => {
-      expect($el).to.have.attr('data-id', nodes[index + randomNumber].id)
+  it('removes nodes from view', () => {
+    cy.get('.vue-flow__node').should('have.length', nodes.length - deletedNodes.length)
+  })
+
+  it('removes nodes from DOM', () => {
+    cy.get('.vue-flow__node').then((els) => {
+      els.each((index, node) => {
+        const nodeId = node.getAttribute('data-id')
+        const storedNode = store.findNode(nodeId)
+
+        expect(deletedNodes).to.not.include(nodeId)
+        expect(storedNode).to.not.eq(undefined)
+      })
     })
   })
 })

tests/cypress/component/1-store/nodes/removeSelectedNodes.cy.ts

@@ -36,14 +36,10 @@ describe('Store Action: `removeSelectedNodes`', () => {
 
         if (index >= randomNumber2 && index < randomNumber) {
           expect(!!storedNode?.selected).to.eq(true)
-          cy.tryAssertion(() => {
-            expect(node).to.have.class('selected')
-          })
+          expect(node).to.have.class('selected')
         } else {
           expect(!!storedNode?.selected).to.eq(false)
-          cy.tryAssertion(() => {
-            expect(node).to.not.have.class('selected')
-          })
+          expect(node).to.not.have.class('selected')
         }
       })
     })