refactor(core): remove connectedEdges from node mouse events (#1464)

* refactor(core): remove `connectedEdges` from node mouse events

* chore(changeset): add
This commit is contained in:
Braks
2024-06-13 00:04:51 +02:00
parent 0825101ebe
commit 798faf1be4
3 changed files with 17 additions and 15 deletions
+5
View File
@@ -0,0 +1,5 @@
---
"@vue-flow/core": minor
---
Remove `connectedEdges` as arg from NodeMouseEvents
@@ -37,8 +37,6 @@ const NodeWrapper = defineComponent({
compatConfig: { MODE: 3 }, compatConfig: { MODE: 3 },
props: ['id', 'resizeObserver'], props: ['id', 'resizeObserver'],
setup(props: Props) { setup(props: Props) {
provide(NodeId, props.id)
const { const {
id: vueFlowId, id: vueFlowId,
noPanClassName, noPanClassName,
@@ -64,16 +62,17 @@ const NodeWrapper = defineComponent({
nodesFocusable, nodesFocusable,
} = useVueFlow() } = useVueFlow()
const nodeElement = ref<HTMLDivElement | null>(null)
provide(NodeRef, nodeElement)
provide(NodeId, props.id)
const slots = inject(Slots) const slots = inject(Slots)
const instance = getCurrentInstance() const instance = getCurrentInstance()
const updateNodePositions = useUpdateNodePositions() const updateNodePositions = useUpdateNodePositions()
const { node, parentNode, connectedEdges } = useNode(props.id) const { node, parentNode } = useNode(props.id)
const nodeElement = ref<HTMLDivElement | null>(null)
provide(NodeRef, nodeElement)
const isDraggable = toRef(() => (typeof node.draggable === 'undefined' ? nodesDraggable.value : node.draggable)) const isDraggable = toRef(() => (typeof node.draggable === 'undefined' ? nodesDraggable.value : node.draggable))
@@ -333,28 +332,28 @@ const NodeWrapper = defineComponent({
function onMouseEnter(event: MouseEvent) { function onMouseEnter(event: MouseEvent) {
if (!dragging?.value) { if (!dragging?.value) {
emit.mouseEnter({ event, node, connectedEdges: connectedEdges.value }) emit.mouseEnter({ event, node })
} }
} }
function onMouseMove(event: MouseEvent) { function onMouseMove(event: MouseEvent) {
if (!dragging?.value) { if (!dragging?.value) {
emit.mouseMove({ event, node, connectedEdges: connectedEdges.value }) emit.mouseMove({ event, node })
} }
} }
function onMouseLeave(event: MouseEvent) { function onMouseLeave(event: MouseEvent) {
if (!dragging?.value) { if (!dragging?.value) {
emit.mouseLeave({ event, node, connectedEdges: connectedEdges.value }) emit.mouseLeave({ event, node })
} }
} }
function onContextMenu(event: MouseEvent) { function onContextMenu(event: MouseEvent) {
return emit.contextMenu({ event, node, connectedEdges: connectedEdges.value }) return emit.contextMenu({ event, node })
} }
function onDoubleClick(event: MouseEvent) { function onDoubleClick(event: MouseEvent) {
return emit.doubleClick({ event, node, connectedEdges: connectedEdges.value }) return emit.doubleClick({ event, node })
} }
function onSelectNode(event: MouseEvent) { function onSelectNode(event: MouseEvent) {
@@ -370,7 +369,7 @@ const NodeWrapper = defineComponent({
) )
} }
emit.click({ event, node, connectedEdges: connectedEdges.value }) emit.click({ event, node })
} }
function onKeyDown(event: KeyboardEvent) { function onKeyDown(event: KeyboardEvent) {
+1 -3
View File
@@ -1,7 +1,6 @@
import type { EventHookOn, EventHookTrigger } from '@vueuse/core' import type { EventHookOn, EventHookTrigger } from '@vueuse/core'
import type { D3ZoomEvent } from 'd3-zoom' import type { D3ZoomEvent } from 'd3-zoom'
import type { VueFlowError } from '../utils/errors' import type { EventHookExtended, VueFlowError } from '../utils'
import type { EventHookExtended } from '../utils/createExtendedEventHook'
import type { GraphEdge } from './edge' import type { GraphEdge } from './edge'
import type { GraphNode } from './node' import type { GraphNode } from './node'
import type { Connection, OnConnectStartParams } from './connection' import type { Connection, OnConnectStartParams } from './connection'
@@ -14,7 +13,6 @@ export type MouseTouchEvent = MouseEvent | TouchEvent
export interface NodeMouseEvent { export interface NodeMouseEvent {
event: MouseTouchEvent event: MouseTouchEvent
node: GraphNode node: GraphNode
connectedEdges: GraphEdge[]
} }
export interface NodeDragEvent { export interface NodeDragEvent {