From 79e7f3ccdb42bec05a7ac6a45984c535955204b4 Mon Sep 17 00:00:00 2001 From: braks <78412429+bcakmakoglu@users.noreply.github.com> Date: Thu, 23 Feb 2023 16:18:41 +0100 Subject: [PATCH] fix(core): cast zIndex to number in node wrapper Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com> --- packages/core/src/components/Nodes/NodeWrapper.vue | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/packages/core/src/components/Nodes/NodeWrapper.vue b/packages/core/src/components/Nodes/NodeWrapper.vue index 5ede5e8a..2ff64d83 100644 --- a/packages/core/src/components/Nodes/NodeWrapper.vue +++ b/packages/core/src/components/Nodes/NodeWrapper.vue @@ -84,6 +84,8 @@ const getStyle = computed(() => { return styles }) +const zIndex = computed(() => Number(node.zIndex ?? getStyle.value.zIndex ?? 0)) + onUpdateNodeInternals((updateIds) => { if (updateIds.includes(id)) { updateInternals() @@ -122,16 +124,13 @@ watch( () => node.dimensions.width, () => parentNode?.dimensions.height, () => parentNode?.dimensions.width, - () => node.zIndex, + zIndex, ], ([newX, newY, parentX, parentY, parentZ]) => { - let zIndex = isNumber(node.zIndex) ? node.zIndex : 0 - zIndex = isNumber(getStyle.value.zIndex) ? getStyle.value.zIndex : zIndex - const xyzPos = { x: newX, y: newY, - z: (zIndex || 0) + (elevateNodesOnSelect ? (node.selected ? 1000 : 0) : 0), + z: zIndex.value + (elevateNodesOnSelect ? (node.selected ? 1000 : 0) : 0), } if (isNumber(parentX) && isNumber(parentY)) { @@ -270,7 +269,7 @@ export default { getClass, ]" :style="{ - zIndex: node.computedPosition.z ?? 0, + zIndex: node.computedPosition.z ?? zIndex, transform: `translate(${node.computedPosition.x}px,${node.computedPosition.y}px)`, pointerEvents: selectable || draggable ? 'all' : 'none', ...getStyle,