From 7a013771f3d5efec4d23eace5a08fd2fc5ab38b8 Mon Sep 17 00:00:00 2001
From: braks <78412429+bcakmakoglu@users.noreply.github.com>
Date: Wed, 13 Sep 2023 09:56:07 +0200
Subject: [PATCH] feat(core): add source and target node ids to edge remove
 changes

---
 packages/core/src/store/actions.ts | 13 ++++++++-----
 packages/core/src/types/changes.ts |  5 ++++-
 packages/core/src/utils/changes.ts | 11 ++++++++++-
 3 files changed, 22 insertions(+), 7 deletions(-)

diff --git a/packages/core/src/store/actions.ts b/packages/core/src/store/actions.ts
index e59054fd..a6928353 100644
--- a/packages/core/src/store/actions.ts
+++ b/packages/core/src/store/actions.ts
@@ -30,8 +30,9 @@ import {
   applyChanges,
   clamp,
   createAdditionChange,
+  createEdgeRemoveChange,
   createGraphNodes,
-  createRemoveChange,
+  createNodeRemoveChange,
   createSelectionChange,
   getConnectedEdges,
   getDimensions,
@@ -520,7 +521,9 @@ export function useActions(
     function createEdgeRemovalChanges(nodes: Node[]) {
       const connections = getConnectedEdges(nodes, state.edges).filter((edge) => (isDef(edge.deletable) ? edge.deletable : true))
 
-      edgeChanges.push(...connections.map((connection) => createRemoveChange(connection.id)))
+      edgeChanges.push(
+        ...connections.map((connection) => createEdgeRemoveChange(connection.id, connection.source, connection.target)),
+      )
     }
 
     // recursively get all children and if the child is a parent, get those children as well until all nodes have been removed that are children of the current node
@@ -529,7 +532,7 @@ export function useActions(
 
       if (children.length) {
         const childIds = children.map((n) => n.id)
-        nodeChanges.push(...childIds.map((id) => createRemoveChange(id)))
+        nodeChanges.push(...childIds.map((id) => createNodeRemoveChange(id)))
 
         if (removeConnectedEdges) {
           createEdgeRemovalChanges(children)
@@ -552,7 +555,7 @@ export function useActions(
         return
       }
 
-      nodeChanges.push(createRemoveChange(currNode.id))
+      nodeChanges.push(createNodeRemoveChange(currNode.id))
 
       if (removeConnectedEdges) {
         createEdgeRemovalChanges([currNode])
@@ -589,7 +592,7 @@ export function useActions(
         return
       }
 
-      changes.push(createRemoveChange(typeof item === 'string' ? item : item.id))
+      changes.push(createEdgeRemoveChange(typeof item === 'string' ? item : item.id, currEdge.source, currEdge.target))
     })
 
     state.hooks.edgesChange.trigger(changes)
diff --git a/packages/core/src/types/changes.ts b/packages/core/src/types/changes.ts
index aba93d85..c66280aa 100644
--- a/packages/core/src/types/changes.ts
+++ b/packages/core/src/types/changes.ts
@@ -51,7 +51,10 @@ export type NodeChange = NodeDimensionChange | NodePositionChange | NodeSelectio
 
 export type EdgeSelectionChange = NodeSelectionChange
 
-export type EdgeRemoveChange = NodeRemoveChange
+export interface EdgeRemoveChange extends NodeRemoveChange {
+  source: string
+  target: string
+}
 
 export interface EdgeAddChange<Data = ElementData> {
   item: GraphEdge<Data>
diff --git a/packages/core/src/utils/changes.ts b/packages/core/src/utils/changes.ts
index cc5fb3f0..5bb7ef52 100644
--- a/packages/core/src/utils/changes.ts
+++ b/packages/core/src/utils/changes.ts
@@ -228,13 +228,22 @@ export function createAdditionChange<
   }
 }
 
-export function createRemoveChange(id: string): NodeRemoveChange | EdgeRemoveChange {
+export function createNodeRemoveChange(id: string): NodeRemoveChange {
   return {
     id,
     type: 'remove',
   }
 }
 
+export function createEdgeRemoveChange(id: string, source: string, target: string): EdgeRemoveChange {
+  return {
+    id,
+    source,
+    target,
+    type: 'remove',
+  }
+}
+
 export function getSelectionChanges(elements: FlowElements, selectedIds: string[]) {
   return elements.reduce(
     (res, item) => {