From 9e1ba45839f9d3484dd9134326c92177ba486f19 Mon Sep 17 00:00:00 2001
From: braks <78412429+bcakmakoglu@users.noreply.github.com>
Date: Mon, 16 Jan 2023 18:27:57 +0100
Subject: [PATCH] fix(core): check if position is a number and not if it's
 truthy

Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>
---
 packages/core/src/components/Nodes/NodeWrapper.vue        | 6 +++---
 packages/core/src/container/EdgeRenderer/EdgeRenderer.vue | 3 +--
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/packages/core/src/components/Nodes/NodeWrapper.vue b/packages/core/src/components/Nodes/NodeWrapper.vue
index 92e42280..b48cbdcc 100644
--- a/packages/core/src/components/Nodes/NodeWrapper.vue
+++ b/packages/core/src/components/Nodes/NodeWrapper.vue
@@ -127,10 +127,10 @@ watch(
     const xyzPos = {
       x: newX,
       y: newY,
-      z: zIndex + (elevateNodesOnSelect ? (node.selected ? 1000 : 0) : 0),
+      z: (zIndex || 0) + (elevateNodesOnSelect ? (node.selected ? 1000 : 0) : 0),
     }
 
-    if (parentX && parentY) {
+    if (isNumber(parentX) && isNumber(parentY)) {
       node.computedPosition = getXYZPos({ x: parentX, y: parentY, z: parentZ! }, xyzPos)
     } else {
       node.computedPosition = xyzPos
@@ -152,7 +152,7 @@ watch(
 
 // todo: do we need to wait for initialized? Or can we clamp the position immediately?
 until(() => node.initialized)
-  .toBe(true, { flush: 'pre' })
+  .toBe(true)
   .then(updatePosition)
 
 /** this re-calculates the current position, necessary for clamping by a node's extent */
diff --git a/packages/core/src/container/EdgeRenderer/EdgeRenderer.vue b/packages/core/src/container/EdgeRenderer/EdgeRenderer.vue
index 9220b3bf..23405b1a 100644
--- a/packages/core/src/container/EdgeRenderer/EdgeRenderer.vue
+++ b/packages/core/src/container/EdgeRenderer/EdgeRenderer.vue
@@ -53,9 +53,8 @@ const connectionLineVisible = $(
 let groups = $ref<ReturnType<typeof groupEdgesByZLevel>>([])
 
 let stop: WatchStopHandle
-
 onPaneReady(() => {
-  watch(
+  stop = watch(
     [
       $$(getSelectedNodes),
       $$(getEdges),