From a443d38f123f8853f5505412b2ef8b1be1104a75 Mon Sep 17 00:00:00 2001
From: braks <78412429+bcakmakoglu@users.noreply.github.com>
Date: Fri, 7 Oct 2022 12:46:08 +0200
Subject: [PATCH] refactor(edges,store): use connection start handle and remove
 other props from store

---
 .../ConnectionLine/ConnectionLine.vue         | 16 ++++++++-------
 .../vue-flow/src/composables/useHandle.ts     | 14 +++++++------
 .../container/EdgeRenderer/EdgeRenderer.vue   | 20 ++++++++++---------
 packages/vue-flow/src/store/actions.ts        | 12 ++++-------
 packages/vue-flow/src/store/state.ts          |  5 +----
 packages/vue-flow/src/types/store.ts          |  8 ++------
 6 files changed, 35 insertions(+), 40 deletions(-)

diff --git a/packages/vue-flow/src/components/ConnectionLine/ConnectionLine.vue b/packages/vue-flow/src/components/ConnectionLine/ConnectionLine.vue
index a71d71d8..8bf65d91 100644
--- a/packages/vue-flow/src/components/ConnectionLine/ConnectionLine.vue
+++ b/packages/vue-flow/src/components/ConnectionLine/ConnectionLine.vue
@@ -1,6 +1,6 @@
 <script lang="ts" setup>
 import { getBezierPath, getSmoothStepPath } from '../Edges/utils'
-import type { GraphNode, HandleElement, HandleType } from '../../types'
+import type { GraphNode, HandleElement } from '../../types'
 import { ConnectionLineType, Position } from '../../types'
 import { useVueFlow } from '../../composables'
 import { Slots } from '../../context'
@@ -12,12 +12,10 @@ const { sourceNode } = defineProps<{
 
 const {
   getNodes,
-  connectionHandleId,
-  connectionHandleType,
+  connectionStartHandle,
   connectionPosition,
   connectionLineType,
   connectionLineStyle,
-  connectionNodeId,
   connectionLineOptions,
   viewport,
 } = $(useVueFlow())
@@ -26,10 +24,14 @@ const slots = inject(Slots)?.['connection-line']
 
 const hasSlot = slots?.({})
 
+const handleId = connectionStartHandle!.handleId
+const nodeId = connectionStartHandle!.nodeId
+const type = connectionStartHandle!.type
+
 const sourceHandle =
-  connectionHandleId && connectionHandleType
-    ? sourceNode.handleBounds[connectionHandleType as HandleType]?.find((d: HandleElement) => d.id === connectionHandleId)
-    : connectionHandleType && sourceNode.handleBounds[(connectionHandleType as HandleType) ?? 'source']?.[0]
+  handleId && type
+    ? sourceNode.handleBounds[type]?.find((d: HandleElement) => d.id === handleId)
+    : type && sourceNode.handleBounds[type ?? 'source']?.[0]
 
 const sourceHandleX = sourceHandle ? sourceHandle.x + sourceHandle.width / 2 : sourceNode.dimensions.width / 2
 const sourceHandleY = sourceHandle ? sourceHandle.y + sourceHandle.height / 2 : sourceNode.dimensions.height
diff --git a/packages/vue-flow/src/composables/useHandle.ts b/packages/vue-flow/src/composables/useHandle.ts
index b98fc48d..ecc7d271 100644
--- a/packages/vue-flow/src/composables/useHandle.ts
+++ b/packages/vue-flow/src/composables/useHandle.ts
@@ -123,15 +123,17 @@ export default () => {
 
     const containerBounds = vueFlowRef.getBoundingClientRect()
 
-    startConnection({
-      connectionPosition: {
+    startConnection(
+      {
+        nodeId,
+        handleId,
+        type: handleType,
+      },
+      {
         x: event.clientX - containerBounds.left,
         y: event.clientY - containerBounds.top,
       },
-      connectionNodeId: nodeId,
-      connectionHandleId: handleId,
-      connectionHandleType: handleType,
-    })
+    )
 
     emits.connectStart({ event, nodeId, handleId, handleType })
 
diff --git a/packages/vue-flow/src/container/EdgeRenderer/EdgeRenderer.vue b/packages/vue-flow/src/container/EdgeRenderer/EdgeRenderer.vue
index 7df4cb80..81d0cc0d 100644
--- a/packages/vue-flow/src/container/EdgeRenderer/EdgeRenderer.vue
+++ b/packages/vue-flow/src/container/EdgeRenderer/EdgeRenderer.vue
@@ -15,9 +15,8 @@ const {
   connectionMode,
   edgeUpdaterRadius,
   onPaneReady,
-  connectionNodeId,
+  connectionStartHandle,
   nodesConnectable,
-  connectionHandleType,
   edgesUpdatable,
   elementsSelectable,
   getSelectedNodes,
@@ -38,21 +37,24 @@ const updatable = (u?: EdgeUpdatable) => (typeof u === 'undefined' ? edgesUpdata
 const updating = ref<string>()
 
 const sourceNode = $(
-  controlledComputed($$(connectionNodeId), () => {
-    if (connectionNodeId) return getNode(connectionNodeId)
-    return false
-  }),
+  controlledComputed(
+    () => connectionStartHandle?.nodeId,
+    () => {
+      if (connectionStartHandle?.nodeId) return getNode(connectionStartHandle.nodeId)
+      return false
+    },
+  ),
 )
 
 const connectionLineVisible = $(
   controlledComputed(
-    $$(connectionNodeId),
+    () => connectionStartHandle?.nodeId,
     () =>
       !!(
         sourceNode &&
         (typeof sourceNode.connectable === 'undefined' ? nodesConnectable : sourceNode.connectable) &&
-        connectionNodeId &&
-        connectionHandleType
+        connectionStartHandle?.nodeId &&
+        connectionStartHandle?.type
       ),
   ),
 )
diff --git a/packages/vue-flow/src/store/actions.ts b/packages/vue-flow/src/store/actions.ts
index c3efd3a8..1e1af2fa 100644
--- a/packages/vue-flow/src/store/actions.ts
+++ b/packages/vue-flow/src/store/actions.ts
@@ -358,11 +358,9 @@ export default (state: State, getters: ComputedGetters): Actions => {
 
   const applyEdgeChanges: Actions['applyEdgeChanges'] = (changes) => applyChanges(changes, state.edges)
 
-  const startConnection: Actions['startConnection'] = (params) => {
-    state.connectionPosition = params.connectionPosition
-    state.connectionNodeId = params.connectionNodeId
-    state.connectionHandleId = params.connectionHandleId
-    state.connectionHandleType = params.connectionHandleType
+  const startConnection: Actions['startConnection'] = (startHandle, position) => {
+    state.connectionStartHandle = startHandle
+    state.connectionPosition = position
   }
 
   const updateConnection: Actions['updateConnection'] = (position) => {
@@ -371,9 +369,7 @@ export default (state: State, getters: ComputedGetters): Actions => {
 
   const endConnection: Actions['endConnection'] = () => {
     state.connectionPosition = { x: NaN, y: NaN }
-    state.connectionNodeId = null
-    state.connectionHandleId = null
-    state.connectionHandleType = null
+    state.connectionStartHandle = null
   }
 
   const setState: Actions['setState'] = (options) => {
diff --git a/packages/vue-flow/src/store/state.ts b/packages/vue-flow/src/store/state.ts
index 62e45651..d2f043d3 100644
--- a/packages/vue-flow/src/store/state.ts
+++ b/packages/vue-flow/src/store/state.ts
@@ -82,12 +82,9 @@ const defaultState = (): State => ({
     type: ConnectionLineType.Bezier,
     style: {},
   },
-  connectionNodeId: null,
-  connectionHandleId: null,
-  connectionHandleType: null,
-  connectionPosition: { x: NaN, y: NaN },
   connectionMode: ConnectionMode.Loose,
   connectionStartHandle: null,
+  connectionPosition: { x: NaN, y: NaN },
   connectOnClick: true,
 
   snapGrid: [15, 15],
diff --git a/packages/vue-flow/src/types/store.ts b/packages/vue-flow/src/types/store.ts
index 342b0146..df6afcf1 100644
--- a/packages/vue-flow/src/types/store.ts
+++ b/packages/vue-flow/src/types/store.ts
@@ -67,11 +67,6 @@ export interface State extends Omit<FlowOptions, 'id' | 'modelValue'> {
   multiSelectionKeyCode: KeyFilter
   zoomActivationKeyCode: KeyFilter
 
-  // todo: remove these and just use connection start handle
-  connectionNodeId: string | null
-  connectionHandleId: string | null
-  connectionHandleType: HandleType | null
-  connectionPosition: XYPosition
   connectionMode: ConnectionMode
   connectionLineOptions: ConnectionLineOptions
   /** @deprecated use {@link ConnectionLineOptions.type} */
@@ -79,6 +74,7 @@ export interface State extends Omit<FlowOptions, 'id' | 'modelValue'> {
   /** @deprecated use {@link ConnectionLineOptions.style} */
   connectionLineStyle: CSSProperties | null
   connectionStartHandle: StartHandle | null
+  connectionPosition: XYPosition
 
   connectOnClick: boolean
   edgeUpdaterRadius: number
@@ -199,7 +195,7 @@ export interface Actions extends ViewportFunctions {
   /** force update node internal data, if handle bounds are incorrect, you might want to use this */
   updateNodeInternals: UpdateNodeInternals
   /** start a connection */
-  startConnection: (params: StartConnectionParams) => void
+  startConnection: (startHandle: StartHandle, position: XYPosition) => void
   /** update connection position */
   updateConnection: (position: XYPosition) => void
   /** end (or cancel) a connection */