update: Add effect scope to useZoomPanHelper.ts

* Easier cleanup after zoompanhelper has been initialized
This commit is contained in:
Braks
2021-08-17 19:45:26 +02:00
parent 8d8a4a3d1e
commit b8ce50ae3e
+7 -1
View File
@@ -1,5 +1,5 @@
import { zoomIdentity } from 'd3-zoom'; import { zoomIdentity } from 'd3-zoom';
import { computed, inject } from 'vue'; import { computed, effectScope, inject } from 'vue';
import { createEventHook, EventHookOn, until } from '@vueuse/core'; import { createEventHook, EventHookOn, until } from '@vueuse/core';
import { Selection, ZoomBehavior } from 'd3'; import { Selection, ZoomBehavior } from 'd3';
import { getRectOfNodes, pointToRendererPoint, getTransformForBounds } from '../utils/graph'; import { getRectOfNodes, pointToRendererPoint, getTransformForBounds } from '../utils/graph';
@@ -10,6 +10,9 @@ const DEFAULT_PADDING = 0.1;
const useZoomPanHelper = (): { onReady: EventHookOn<ZoomPanHelperFunctions> } => { const useZoomPanHelper = (): { onReady: EventHookOn<ZoomPanHelperFunctions> } => {
const zoomPanHelperEvent = createEventHook<ZoomPanHelperFunctions>(); const zoomPanHelperEvent = createEventHook<ZoomPanHelperFunctions>();
const store = inject<RevueFlowStore>('store')!; const store = inject<RevueFlowStore>('store')!;
const scope = effectScope();
scope.run(() => {
const d3Zoom = computed(() => store.d3Zoom); const d3Zoom = computed(() => store.d3Zoom);
const d3Selection = computed(() => store.d3Selection); const d3Selection = computed(() => store.d3Selection);
@@ -76,7 +79,10 @@ const useZoomPanHelper = (): { onReady: EventHookOn<ZoomPanHelperFunctions> } =>
} else { } else {
throw Error('D3 could not be initialized.'); throw Error('D3 could not be initialized.');
} }
scope.stop();
}); });
});
return { return {
onReady: zoomPanHelperEvent.on onReady: zoomPanHelperEvent.on
}; };