refactor(nodes): remove unnecessary scope

This commit is contained in:
braks
2022-10-07 22:55:38 +02:00
committed by Braks
parent a780813fdb
commit bf7594fdbb
@@ -43,8 +43,6 @@ const nodeElement = ref()
const { emit, on } = useNodeHooks(node, emits) const { emit, on } = useNodeHooks(node, emits)
let scope: ReturnType<typeof effectScope> | undefined = effectScope()
const dragging = useDrag({ const dragging = useDrag({
id, id,
el: nodeElement, el: nodeElement,
@@ -98,19 +96,17 @@ updatePosition(
onMounted(() => { onMounted(() => {
props.resizeObserver.observe(nodeElement.value) props.resizeObserver.observe(nodeElement.value)
})
if (!scope) scope = effectScope() watch(
scope.run(() => {
watch(
[() => node.type, () => node.sourcePosition, () => node.targetPosition], [() => node.type, () => node.sourcePosition, () => node.targetPosition],
() => { () => {
updateNodeDimensions([{ id, nodeElement: nodeElement.value }]) updateNodeDimensions([{ id, nodeElement: nodeElement.value }])
}, },
{ flush: 'post' }, { flush: 'post' },
) )
watch( watch(
[ [
() => node.position.x, () => node.position.x,
() => node.position.y, () => node.position.y,
@@ -132,14 +128,10 @@ onMounted(() => {
updateNodeDimensions([{ id, nodeElement: nodeElement.value }]) updateNodeDimensions([{ id, nodeElement: nodeElement.value }])
}, },
{ flush: 'post' }, { flush: 'post' },
) )
})
})
onBeforeUnmount(() => { onBeforeUnmount(() => {
props.resizeObserver.unobserve(nodeElement.value) props.resizeObserver.unobserve(nodeElement.value)
scope?.stop()
scope = undefined
}) })
const onMouseEnter = (event: MouseEvent) => { const onMouseEnter = (event: MouseEvent) => {