From c0920bfb4d4520d475f3e5e01e3b9e211c888467 Mon Sep 17 00:00:00 2001
From: Braks <78412429+bcakmakoglu@users.noreply.github.com>
Date: Wed, 4 May 2022 20:45:41 +0200
Subject: [PATCH] refactor(edges): edges z-index 0 by default

# What's changed?

* only group edges by z-index when `elevateEdgesOnSelect` is true
* add `elevateEdgesOnSelect` option
---
 .../container/EdgeRenderer/EdgeRenderer.vue   | 157 ++++++++++++------
 .../src/container/VueFlow/VueFlow.vue         |   1 +
 packages/vue-flow/src/store/state.ts          |   1 +
 packages/vue-flow/src/types/flow.ts           |   2 +
 4 files changed, 111 insertions(+), 50 deletions(-)

diff --git a/packages/vue-flow/src/container/EdgeRenderer/EdgeRenderer.vue b/packages/vue-flow/src/container/EdgeRenderer/EdgeRenderer.vue
index 74771d18..a3820166 100644
--- a/packages/vue-flow/src/container/EdgeRenderer/EdgeRenderer.vue
+++ b/packages/vue-flow/src/container/EdgeRenderer/EdgeRenderer.vue
@@ -22,13 +22,14 @@ const {
   edgesUpdatable,
   elementsSelectable,
   getSelectedNodes,
+  nodesSelectionActive,
   getNode,
   getNodes,
   getEdges,
   getEdgeTypes,
-  setState,
   addSelectedEdges,
   noPanClassName,
+  elevateEdgesOnSelect,
 } = $(useVueFlow())
 
 const selectable = (s?: boolean) => (typeof s === 'undefined' ? elementsSelectable : s)
@@ -57,16 +58,22 @@ const connectionLineVisible = $(
 let groups = $ref<ReturnType<typeof groupEdgesByZLevel>>([])
 
 onPaneReady(() => {
-  watch(
-    [$$(getSelectedNodes), $$(getEdges), $$(getNodes)],
+  const stop = watch(
+    [$$(elevateEdgesOnSelect), $$(getSelectedNodes), $$(getEdges), $$(getNodes)],
     () => {
-      nextTick(() => (groups = groupEdgesByZLevel(getEdges, getNode)))
+      if (elevateEdgesOnSelect) {
+        nextTick(() => (groups = groupEdgesByZLevel(getEdges, getNode)))
+      }
     },
     {
       flush: 'post',
       immediate: true,
     },
   )
+
+  onBeforeUnmount(() => {
+    stop()
+  })
 })
 
 const getType = (type?: string, template?: GraphEdge['template']) => {
@@ -96,9 +103,7 @@ const getType = (type?: string, template?: GraphEdge['template']) => {
 const onEdgeClick = (event: MouseEvent, edge: GraphEdge) => {
   const data = { event, edge }
   if (selectable(edge.selectable)) {
-    setState({
-      nodesSelectionActive: false,
-    })
+    $$(nodesSelectionActive).value = false
 
     addSelectedEdges([edge])
   }
@@ -156,49 +161,101 @@ export default {
 </script>
 
 <template>
-  <svg v-for="group of groups" :key="group.level" class="vue-flow__edges vue-flow__container" :style="`z-index: ${group.level}`">
-    <MarkerDefinitions v-if="group.isMaxLevel" :default-color="defaultMarkerColor" />
-    <g>
-      <EdgeWrapper
-        v-for="edge of group.edges"
-        :id="edge.id"
-        :key="edge.id"
-        :type="getType(edge.type, edge.template)"
-        :name="edge.type || 'default'"
-        :source="edge.source"
-        :target="edge.target"
-        :target-handle-id="edge.targetHandle"
-        :source-handle-id="edge.sourceHandle"
-        :source-node="getNode(edge.source)"
-        :target-node="getNode(edge.target)"
-        :label="edge.label"
-        :data="edge.data"
-        :animated="edge.animated"
-        :selectable="selectable(edge.selectable)"
-        :selected="edge.selected"
-        :updatable="updatable(edge.updatable)"
-        :label-style="edge.labelStyle"
-        :label-show-bg="edge.labelShowBg"
-        :label-bg-style="edge.labelBgStyle"
-        :label-bg-padding="edge.labelBgPadding"
-        :label-bg-border-radius="edge.labelBgBorderRadius"
-        :connection-mode="connectionMode"
-        :edge-updater-radius="edgeUpdaterRadius"
-        :marker-end="edge.markerEnd"
-        :marker-start="edge.markerStart"
-        :style="getStyle(edge)"
-        :class="getClass(edge)"
-        @click="(e: MouseEvent) => onEdgeClick(e, edge)"
-        @dbl-click="(e: MouseEvent) => onDoubleClick(e, edge)"
-        @contextmenu="(e: MouseEvent) => onEdgeContextMenu(e, edge)"
-        @mouseenter="(e: MouseEvent) => onEdgeMouseEnter(e, edge)"
-        @mousemove="(e: MouseEvent) => onEdgeMouseMove(e, edge)"
-        @mouseleave="(e: MouseEvent) => onEdgeMouseLeave(e, edge)"
-        @source-mousedown="(e: MouseEvent) => onEdgeUpdaterSourceMouseDown(e, edge)"
-        @target-mousedown="(e: MouseEvent) => onEdgeUpdaterTargetMouseDown(e, edge)"
-      />
-    </g>
-  </svg>
+  <template v-if="elevateEdgesOnSelect">
+    <svg
+      v-for="group of groups"
+      :key="group.level"
+      class="vue-flow__edges vue-flow__container"
+      :style="`z-index: ${group.level}`"
+    >
+      <MarkerDefinitions v-if="group.isMaxLevel" :default-color="defaultMarkerColor" />
+      <g>
+        <EdgeWrapper
+          v-for="edge of group.edges"
+          :id="edge.id"
+          :key="edge.id"
+          :type="getType(edge.type, edge.template)"
+          :name="edge.type || 'default'"
+          :source="edge.source"
+          :target="edge.target"
+          :target-handle-id="edge.targetHandle"
+          :source-handle-id="edge.sourceHandle"
+          :source-node="getNode(edge.source)"
+          :target-node="getNode(edge.target)"
+          :label="edge.label"
+          :data="edge.data"
+          :animated="edge.animated"
+          :selectable="selectable(edge.selectable)"
+          :selected="edge.selected"
+          :updatable="updatable(edge.updatable)"
+          :label-style="edge.labelStyle"
+          :label-show-bg="edge.labelShowBg"
+          :label-bg-style="edge.labelBgStyle"
+          :label-bg-padding="edge.labelBgPadding"
+          :label-bg-border-radius="edge.labelBgBorderRadius"
+          :connection-mode="connectionMode"
+          :edge-updater-radius="edgeUpdaterRadius"
+          :marker-end="edge.markerEnd"
+          :marker-start="edge.markerStart"
+          :style="getStyle(edge)"
+          :class="getClass(edge)"
+          @click="onEdgeClick($event, edge)"
+          @dbl-click="onDoubleClick($event, edge)"
+          @contextmenu="onEdgeContextMenu($event, edge)"
+          @mouseenter="onEdgeMouseEnter($event, edge)"
+          @mousemove="onEdgeMouseMove($event, edge)"
+          @mouseleave="onEdgeMouseLeave($event, edge)"
+          @source-mousedown="onEdgeUpdaterSourceMouseDown($event, edge)"
+          @target-mousedown="onEdgeUpdaterTargetMouseDown($event, edge)"
+        />
+      </g>
+    </svg>
+  </template>
+  <template v-else>
+    <svg class="vue-flow__edges vue-flow__container">
+      <MarkerDefinitions :default-color="defaultMarkerColor" />
+      <g>
+        <EdgeWrapper
+          v-for="edge of getEdges"
+          :id="edge.id"
+          :key="edge.id"
+          :type="getType(edge.type, edge.template)"
+          :name="edge.type || 'default'"
+          :source="edge.source"
+          :target="edge.target"
+          :target-handle-id="edge.targetHandle"
+          :source-handle-id="edge.sourceHandle"
+          :source-node="getNode(edge.source)"
+          :target-node="getNode(edge.target)"
+          :label="edge.label"
+          :data="edge.data"
+          :animated="edge.animated"
+          :selectable="selectable(edge.selectable)"
+          :selected="edge.selected"
+          :updatable="updatable(edge.updatable)"
+          :label-style="edge.labelStyle"
+          :label-show-bg="edge.labelShowBg"
+          :label-bg-style="edge.labelBgStyle"
+          :label-bg-padding="edge.labelBgPadding"
+          :label-bg-border-radius="edge.labelBgBorderRadius"
+          :connection-mode="connectionMode"
+          :edge-updater-radius="edgeUpdaterRadius"
+          :marker-end="edge.markerEnd"
+          :marker-start="edge.markerStart"
+          :style="getStyle(edge)"
+          :class="getClass(edge)"
+          @click="onEdgeClick($event, edge)"
+          @dbl-click="onDoubleClick($event, edge)"
+          @contextmenu="onEdgeContextMenu($event, edge)"
+          @mouseenter="onEdgeMouseEnter($event, edge)"
+          @mousemove="onEdgeMouseMove($event, edge)"
+          @mouseleave="onEdgeMouseLeave($event, edge)"
+          @source-mousedown="onEdgeUpdaterSourceMouseDown($event, edge)"
+          @target-mousedown="onEdgeUpdaterTargetMouseDown($event, edge)"
+        />
+      </g>
+    </svg>
+  </template>
   <svg v-if="connectionLineVisible && !!sourceNode" class="vue-flow__edges vue-flow__connectionline vue-flow__container">
     <ConnectionLine :source-node="sourceNode" />
   </svg>
diff --git a/packages/vue-flow/src/container/VueFlow/VueFlow.vue b/packages/vue-flow/src/container/VueFlow/VueFlow.vue
index 9e099351..7423989a 100644
--- a/packages/vue-flow/src/container/VueFlow/VueFlow.vue
+++ b/packages/vue-flow/src/container/VueFlow/VueFlow.vue
@@ -37,6 +37,7 @@ const props = withDefaults(defineProps<FlowProps>(), {
   connectOnClick: undefined,
   connectionLineStyle: undefined,
   autoConnect: undefined,
+  elevateEdgesOnSelect: undefined,
 })
 
 const emit = defineEmits<{
diff --git a/packages/vue-flow/src/store/state.ts b/packages/vue-flow/src/store/state.ts
index 8e5bc587..4359781d 100644
--- a/packages/vue-flow/src/store/state.ts
+++ b/packages/vue-flow/src/store/state.ts
@@ -108,6 +108,7 @@ const defaultState = (): State => ({
   noWheelClassName: 'nowheel',
   noPanClassName: 'nopan',
   defaultEdgeOptions: undefined,
+  elevateEdgesOnSelect: false,
 
   vueFlowVersion: typeof __VUE_FLOW_VERSION__ !== 'undefined' ? __VUE_FLOW_VERSION__ : '-',
 })
diff --git a/packages/vue-flow/src/types/flow.ts b/packages/vue-flow/src/types/flow.ts
index 726ee3da..d5f9d0a7 100644
--- a/packages/vue-flow/src/types/flow.ts
+++ b/packages/vue-flow/src/types/flow.ts
@@ -129,6 +129,8 @@ export interface FlowProps {
   noPanClassName?: string
   /** does not work for the `addEdge` utility! */
   defaultEdgeOptions?: DefaultEdgeOptions
+  /** elevates edges when selected and applies z-Index to put them above their nodes */
+  elevateEdgesOnSelect?: boolean
 }
 
 export type FlowOptions = FlowProps