From c31deb897dc0c82e645d881926f207b31069bdfb Mon Sep 17 00:00:00 2001
From: bcakmakoglu <78412429+bcakmakoglu@users.noreply.github.com>
Date: Tue, 8 Mar 2022 16:34:50 +0100
Subject: [PATCH] update(edges): filter edges of hidden nodes

* we don't want to show edges that go seemingly nowhere

Signed-off-by: bcakmakoglu <78412429+bcakmakoglu@users.noreply.github.com>
---
 src/container/EdgeRenderer/EdgeRenderer.vue | 5 +----
 src/store/getters.ts                        | 5 ++++-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/container/EdgeRenderer/EdgeRenderer.vue b/src/container/EdgeRenderer/EdgeRenderer.vue
index 021f73e3..366f06d8 100644
--- a/src/container/EdgeRenderer/EdgeRenderer.vue
+++ b/src/container/EdgeRenderer/EdgeRenderer.vue
@@ -32,10 +32,7 @@ const connectionLineVisible = controlledComputed(
       store.connectionHandleType
     ),
 )
-const groups = controlledComputed(
-  () => store.getEdges,
-  () => groupEdgesByZLevel(store.getEdges, store.getNodes),
-)
+const groups = computed(() => groupEdgesByZLevel(store.getEdges, store.getNodes))
 </script>
 <script lang="ts">
 export default {
diff --git a/src/store/getters.ts b/src/store/getters.ts
index 6327fe1b..1f8c5eee 100644
--- a/src/store/getters.ts
+++ b/src/store/getters.ts
@@ -44,7 +44,8 @@ export default (state: State): ComputedGetters => {
 
   const getEdges = computed<GraphEdge[]>(() => {
     if (state.paneReady && state.dimensions.width && state.dimensions.height) {
-      if (!state.onlyRenderVisibleElements) return state.edges.filter((e) => !e.hidden)
+      if (!state.onlyRenderVisibleElements)
+        return state.edges.filter((e) => !e.hidden && !e.targetNode.hidden && !e.sourceNode.hidden)
       else
         return state.edges.filter(
           (e) =>
@@ -53,6 +54,8 @@ export default (state: State): ComputedGetters => {
             e.sourceNode.dimensions.height &&
             e.targetNode.dimensions.width &&
             e.targetNode.dimensions.height &&
+            !e.targetNode.hidden &&
+            !e.sourceNode.hidden &&
             isEdgeVisible({
               sourcePos: e.sourceNode.computedPosition || { x: 0, y: 0 },
               targetPos: e.targetNode.computedPosition || { x: 0, y: 0 },