alighasami/vue-flow
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(core): replace until watcher with onMounted in handle cmp (#1488)

Browse Source
This commit is contained in:
Braks
2024-07-01 09:44:55 +02:00
parent 04524d27fd
commit cf32d59074
1 changed files with 29 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/components/Handle/Handle.vue
+8 -5
View File
@@ -1,6 +1,5 @@
<script lang="ts" setup> <script lang="ts" setup>
import { until } from '@vueuse/core' import { computed, onMounted, onUnmounted, ref, toRef } from 'vue'
import { computed, onUnmounted, ref, toRef } from 'vue'
import type { HandleProps } from '../../types' import type { HandleProps } from '../../types'
import { Position } from '../../types' import { Position } from '../../types'
import { useHandle, useNode, useVueFlow } from '../../composables' import { useHandle, useNode, useVueFlow } from '../../composables'
@@ -97,9 +96,13 @@ const isConnectable = computed(() => {
// todo: remove this and have users handle this themselves using `updateNodeInternals` // todo: remove this and have users handle this themselves using `updateNodeInternals`
// set up handle bounds if they don't exist yet and the node has been initialized (i.e. the handle was added after the node has already been mounted) // set up handle bounds if they don't exist yet and the node has been initialized (i.e. the handle was added after the node has already been mounted)
until(() => !!node.dimensions.width && !!node.dimensions.height) onMounted(() => {
.toBe(true, { flush: 'post' }) // if the node isn't initialized yet, we can't set up the handle bounds
.then(() => { // the handle bounds will be automatically set up when the node is initialized (`updateNodeDimensions`)
if (!node.dimensions.width || !node.dimensions.height) {
return
}
const existingBounds = node.handleBounds[type.value]?.find((b) => b.id === handleId) const existingBounds = node.handleBounds[type.value]?.find((b) => b.id === handleId)
if (!vueFlowRef.value || existingBounds) { if (!vueFlowRef.value || existingBounds) {