From d001d802b5922f013f9e9ac21d691d7d27da032e Mon Sep 17 00:00:00 2001
From: braks <78412429+bcakmakoglu@users.noreply.github.com>
Date: Thu, 1 Feb 2024 11:52:37 +0100
Subject: [PATCH] refactor(core,viewport): replace watchEffect with
 onMounted/onBeforeUnmount

---
 packages/core/src/composables/useResizeHandler.ts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/packages/core/src/composables/useResizeHandler.ts b/packages/core/src/composables/useResizeHandler.ts
index af644427..8e9defdf 100644
--- a/packages/core/src/composables/useResizeHandler.ts
+++ b/packages/core/src/composables/useResizeHandler.ts
@@ -1,5 +1,5 @@
 import type { Ref } from 'vue'
-import { watchEffect } from 'vue'
+import { onBeforeUnmount, onMounted } from 'vue'
 import { ErrorCode, VueFlowError, getDimensions } from '../utils'
 import { useVueFlow } from './useVueFlow'
 import { useWindow } from './useWindow'
@@ -11,7 +11,7 @@ export function useResizeHandler(viewportEl: Ref<HTMLDivElement | null>): void {
 
   let resizeObserver: ResizeObserver
 
-  watchEffect((onCleanup) => {
+  onMounted(() => {
     const rendererNode = viewportEl.value
 
     const updateDimensions = () => {
@@ -25,7 +25,7 @@ export function useResizeHandler(viewportEl: Ref<HTMLDivElement | null>): void {
         emits.error(new VueFlowError(ErrorCode.MISSING_VIEWPORT_DIMENSIONS))
       }
 
-      dimensions.value = size
+      dimensions.value = { width: size.width || 500, height: size.height || 500 }
     }
 
     updateDimensions()
@@ -36,7 +36,7 @@ export function useResizeHandler(viewportEl: Ref<HTMLDivElement | null>): void {
       resizeObserver.observe(rendererNode)
     }
 
-    onCleanup(() => {
+    onBeforeUnmount(() => {
       window.removeEventListener('resize', updateDimensions)
 
       if (resizeObserver && rendererNode) {