refactor(flow): remove defaults for props

* defaults are set by store
* use watcher immediate trigger only if prop exists

Signed-off-by: Braks <78412429+bcakmakoglu@users.noreply.github.com>
This commit is contained in:
Braks
2021-12-20 19:29:52 +01:00
parent fbe62b9ab9
commit dcbe9865e9
2 changed files with 47 additions and 46 deletions
+15 -14
View File
@@ -6,20 +6,21 @@ import type { FlowProps } from '../../types/flow'
import useWatch from './watch' import useWatch from './watch'
const props = withDefaults(defineProps<FlowProps>(), { const props = withDefaults(defineProps<FlowProps>(), {
snapToGrid: false, snapToGrid: undefined,
onlyRenderVisibleElements: false, onlyRenderVisibleElements: undefined,
edgesUpdatable: false, edgesUpdatable: undefined,
nodesConnectable: true, nodesConnectable: undefined,
nodesDraggable: true, nodesDraggable: undefined,
elementsSelectable: true, elementsSelectable: undefined,
selectNodesOnDrag: true, selectNodesOnDrag: undefined,
preventScrolling: true, preventScrolling: undefined,
zoomOnScroll: true, zoomOnScroll: undefined,
zoomOnPinch: true, zoomOnPinch: undefined,
zoomOnDoubleClick: true, zoomOnDoubleClick: undefined,
panOnScroll: false, panOnScroll: undefined,
paneMoveable: true, paneMoveable: undefined,
applyDefault: true, applyDefault: undefined,
fitViewOnInit: undefined,
}) })
const emit = defineEmits([...Object.keys(createHooks()), 'update:modelValue', 'update:elements', 'update:edges', 'update:nodes']) const emit = defineEmits([...Object.keys(createHooks()), 'update:modelValue', 'update:elements', 'update:edges', 'update:nodes'])
+32 -32
View File
@@ -52,161 +52,161 @@ export default (
watch( watch(
() => props.maxZoom, () => props.maxZoom,
(v) => isDef(v) && store.setMaxZoom(v), (v) => isDef(v) && store.setMaxZoom(v),
{ immediate: true }, { immediate: isDef(props.maxZoom) },
) )
watch( watch(
() => props.minZoom, () => props.minZoom,
(v) => isDef(v) && store.setMinZoom(v), (v) => isDef(v) && store.setMinZoom(v),
{ immediate: true }, { immediate: isDef(props.minZoom) },
) )
watch( watch(
() => props.edgesUpdatable, () => props.edgesUpdatable,
(v) => isDef(v) && (store.edgesUpdatable = v), (v) => isDef(v) && (store.edgesUpdatable = v),
{ immediate: true }, { immediate: isDef(props.edgesUpdatable) },
) )
watch( watch(
() => props.elementsSelectable, () => props.elementsSelectable,
(v) => isDef(v) && (store.elementsSelectable = v), (v) => isDef(v) && (store.elementsSelectable = v),
{ immediate: true }, { immediate: isDef(props.elementsSelectable) },
) )
watch( watch(
() => props.nodesDraggable, () => props.nodesDraggable,
(v) => isDef(v) && (store.nodesDraggable = v), (v) => isDef(v) && (store.nodesDraggable = v),
{ immediate: true }, { immediate: isDef(props.nodesDraggable) },
) )
watch( watch(
() => props.nodesConnectable, () => props.nodesConnectable,
(v) => isDef(v) && (store.nodesConnectable = v), (v) => isDef(v) && (store.nodesConnectable = v),
{ immediate: true }, { immediate: isDef(props.nodesConnectable) },
) )
watch( watch(
() => props.onlyRenderVisibleElements, () => props.onlyRenderVisibleElements,
(v) => isDef(v) && (store.onlyRenderVisibleElements = v), (v) => isDef(v) && (store.onlyRenderVisibleElements = v),
{ immediate: true }, { immediate: isDef(props.onlyRenderVisibleElements) },
) )
watch( watch(
() => props.snapToGrid, () => props.snapToGrid,
(v) => isDef(v) && (store.snapToGrid = v), (v) => isDef(v) && (store.snapToGrid = v),
{ immediate: true }, { immediate: isDef(props.snapToGrid) },
) )
watch( watch(
() => props.snapGrid, () => props.snapGrid,
(v) => isDef(v) && (store.snapGrid = v), (v) => isDef(v) && (store.snapGrid = v),
{ immediate: true }, { immediate: isDef(props.snapGrid) },
) )
watch( watch(
() => props.paneMoveable, () => props.paneMoveable,
(v) => isDef(v) && (store.paneMoveable = v), (v) => isDef(v) && (store.paneMoveable = v),
{ immediate: true }, { immediate: isDef(props.paneMoveable) },
) )
watch( watch(
() => props.panOnScroll, () => props.panOnScroll,
(v) => isDef(v) && (store.panOnScroll = v), (v) => isDef(v) && (store.panOnScroll = v),
{ immediate: true }, { immediate: isDef(props.panOnScroll) },
) )
watch( watch(
() => props.panOnScrollMode, () => props.panOnScrollMode,
(v) => isDef(v) && (store.panOnScrollMode = v), (v) => isDef(v) && (store.panOnScrollMode = v),
{ immediate: true }, { immediate: isDef(props.panOnScrollMode) },
) )
watch( watch(
() => props.panOnScrollSpeed, () => props.panOnScrollSpeed,
(v) => isDef(v) && (store.panOnScrollSpeed = v), (v) => isDef(v) && (store.panOnScrollSpeed = v),
{ immediate: true }, { immediate: isDef(props.panOnScrollSpeed) },
) )
watch( watch(
() => props.zoomOnPinch, () => props.zoomOnPinch,
(v) => isDef(v) && (store.zoomOnPinch = v), (v) => isDef(v) && (store.zoomOnPinch = v),
{ immediate: true }, { immediate: isDef(props.zoomOnPinch) },
) )
watch( watch(
() => props.zoomOnDoubleClick, () => props.zoomOnDoubleClick,
(v) => isDef(v) && (store.zoomOnDoubleClick = v), (v) => isDef(v) && (store.zoomOnDoubleClick = v),
{ immediate: true }, { immediate: isDef(props.zoomOnDoubleClick) },
) )
watch( watch(
() => props.zoomOnScroll, () => props.zoomOnScroll,
(v) => isDef(v) && (store.zoomOnScroll = v), (v) => isDef(v) && (store.zoomOnScroll = v),
{ immediate: true }, { immediate: isDef(props.zoomOnScroll) },
) )
watch( watch(
() => props.deleteKeyCode, () => props.deleteKeyCode,
(v) => isDef(v) && (store.deleteKeyCode = v), (v) => isDef(v) && (store.deleteKeyCode = v),
{ immediate: true }, { immediate: isDef(props.deleteKeyCode) },
) )
watch( watch(
() => props.zoomActivationKeyCode, () => props.zoomActivationKeyCode,
(v) => isDef(v) && (store.zoomActivationKeyCode = v), (v) => isDef(v) && (store.zoomActivationKeyCode = v),
{ immediate: true }, { immediate: isDef(props.zoomActivationKeyCode) },
) )
watch( watch(
() => props.selectionKeyCode, () => props.selectionKeyCode,
(v) => isDef(v) && (store.selectionKeyCode = v), (v) => isDef(v) && (store.selectionKeyCode = v),
{ immediate: true }, { immediate: isDef(props.selectionKeyCode) },
) )
watch( watch(
() => props.multiSelectionKeyCode, () => props.multiSelectionKeyCode,
(v) => isDef(v) && (store.multiSelectionKeyCode = v), (v) => isDef(v) && (store.multiSelectionKeyCode = v),
{ immediate: true }, { immediate: isDef(props.multiSelectionKeyCode) },
) )
watch( watch(
() => props.connectionLineStyle, () => props.connectionLineStyle,
(v) => isDef(v) && (store.connectionLineStyle = v), (v) => isDef(v) && (store.connectionLineStyle = v),
{ immediate: true }, { immediate: isDef(props.connectionLineStyle) },
) )
watch( watch(
() => props.connectionMode, () => props.connectionMode,
(v) => isDef(v) && (store.connectionMode = v), (v) => isDef(v) && (store.connectionMode = v),
{ immediate: true }, { immediate: isDef(props.connectionMode) },
) )
watch( watch(
() => props.connectionLineType, () => props.connectionLineType,
(v) => isDef(v) && (store.connectionLineType = v), (v) => isDef(v) && (store.connectionLineType = v),
{ immediate: true }, { immediate: isDef(props.connectionLineType) },
) )
watch( watch(
() => props.defaultMarkerColor, () => props.defaultMarkerColor,
(v) => isDef(v) && (store.defaultMarkerColor = v), (v) => isDef(v) && (store.defaultMarkerColor = v),
{ immediate: true }, { immediate: isDef(props.defaultMarkerColor) },
) )
watch( watch(
() => props.defaultPosition, () => props.defaultPosition,
(v) => isDef(v) && (store.defaultPosition = v), (v) => isDef(v) && (store.defaultPosition = v),
{ immediate: true }, { immediate: isDef(props.defaultPosition) },
) )
watch( watch(
() => props.defaultZoom, () => props.defaultZoom,
(v) => isDef(v) && (store.defaultZoom = v), (v) => isDef(v) && (store.defaultZoom = v),
{ immediate: true }, { immediate: isDef(props.defaultZoom) },
) )
watch( watch(
() => props.translateExtent, () => props.translateExtent,
(v) => isDef(v) && (store.translateExtent = v), (v) => isDef(v) && (store.translateExtent = v),
{ immediate: true }, { immediate: isDef(props.translateExtent) },
) )
watch( watch(
() => props.nodeExtent, () => props.nodeExtent,
(v) => isDef(v) && (store.nodeExtent = v), (v) => isDef(v) && (store.nodeExtent = v),
{ immediate: true }, { immediate: isDef(props.nodeExtent) },
) )
watch( watch(
() => props.selectNodesOnDrag, () => props.selectNodesOnDrag,
(v) => isDef(v) && (store.selectNodesOnDrag = v), (v) => isDef(v) && (store.selectNodesOnDrag = v),
{ immediate: true }, { immediate: isDef(props.selectNodesOnDrag) },
) )
watch( watch(
() => props.edgeUpdaterRadius, () => props.edgeUpdaterRadius,
(v) => isDef(v) && (store.edgeUpdaterRadius = v), (v) => isDef(v) && (store.edgeUpdaterRadius = v),
{ immediate: true }, { immediate: isDef(props.edgeUpdaterRadius) },
) )
watch( watch(
() => props.applyDefault, () => props.applyDefault,
(v) => isDef(v) && (store.applyDefault = v), (v) => isDef(v) && (store.applyDefault = v),
{ immediate: true }, { immediate: isDef(props.applyDefault) },
) )
watch( watch(
() => props.fitViewOnInit, () => props.fitViewOnInit,
(v) => isDef(v) && (store.fitViewOnInit = v), (v) => isDef(v) && (store.fitViewOnInit = v),
{ immediate: true }, { immediate: isDef(props.fitViewOnInit) },
) )
} }