From f2f3e70ebe559ead80feaad7012d7985951c8c9e Mon Sep 17 00:00:00 2001
From: braks <78412429+bcakmakoglu@users.noreply.github.com>
Date: Sun, 5 Feb 2023 22:07:59 +0100
Subject: [PATCH] fix(core): ios connection error

Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>
---
 packages/core/src/composables/useHandle.ts | 50 ++++++++++------------
 packages/core/src/utils/handle.ts          |  3 +-
 2 files changed, 23 insertions(+), 30 deletions(-)

diff --git a/packages/core/src/composables/useHandle.ts b/packages/core/src/composables/useHandle.ts
index 07a28b06..cb022c8d 100644
--- a/packages/core/src/composables/useHandle.ts
+++ b/packages/core/src/composables/useHandle.ts
@@ -47,6 +47,9 @@ export default function useHandle({
     edges,
   } = useVueFlow()
 
+  let connection: Connection | null = null
+  let isValid = false
+
   function handlePointerDown(event: MouseEvent | TouchEvent) {
     const isMouseTriggered = isMouseEvent(event)
 
@@ -126,7 +129,7 @@ export default function useHandle({
           autoPanStarted = true
         }
 
-        const { connection, handleDomNode, isValid } = isValidHandle(
+        const { handleDomNode, ...result } = isValidHandle(
           event,
           prevClosestHandle,
           connectionMode.value,
@@ -140,7 +143,7 @@ export default function useHandle({
         )
 
         updateConnection(
-          prevClosestHandle && isValid
+          prevClosestHandle && result.isValid
             ? rendererPointToPoint(
                 {
                   x: prevClosestHandle.x,
@@ -151,40 +154,26 @@ export default function useHandle({
             : connectionPosition,
         )
 
-        if (!prevClosestHandle) {
-          return resetRecentHandle(prevActiveHandle)
-        }
+        if (!prevClosestHandle) return resetRecentHandle(prevActiveHandle)
 
-        if (connection.source !== connection.target && handleDomNode) {
+        connection = result.connection
+        isValid = result.isValid
+
+        if (result.connection.source !== result.connection.target && handleDomNode) {
           resetRecentHandle(prevActiveHandle)
+
           prevActiveHandle = handleDomNode
-          handleDomNode.classList.add('vue-flow__handle-connecting')
+
+          handleDomNode.classList.add('connecting', 'vue-flow__handle-connecting')
+          handleDomNode.classList.toggle('valid', isValid)
           handleDomNode.classList.toggle('vue-flow__handle-valid', isValid)
         }
       }
 
       function onPointerUp(event: MouseEvent | TouchEvent) {
-        cancelAnimationFrame(autoPanId)
-        autoPanStarted = false
-
-        if (prevClosestHandle) {
-          const { connection, isValid } = isValidHandle(
-            event,
-            prevClosestHandle,
-            connectionMode.value,
-            nodeId,
-            handleId,
-            isTarget ? 'target' : 'source',
-            validConnectFunc,
-            doc,
-            edges.value,
-            findNode,
-          )
-
-          if (isValid) {
-            if (!onEdgeUpdate) emits.connect({ ...(defaultEdgeOptions?.value || {}), ...connection })
-            else onEdgeUpdate(connection)
-          }
+        if (connection && isValid) {
+          if (!onEdgeUpdate) emits.connect({ ...(defaultEdgeOptions?.value || {}), ...connection })
+          else onEdgeUpdate(connection)
         }
 
         emits.connectEnd(event)
@@ -193,8 +182,13 @@ export default function useHandle({
 
         resetRecentHandle(prevActiveHandle)
 
+        cancelAnimationFrame(autoPanId)
         endConnection(event)
 
+        autoPanStarted = false
+        isValid = false
+        connection = null
+
         doc.removeEventListener('mousemove', onPointerMove as EventListener)
         doc.removeEventListener('mouseup', onPointerUp as EventListener)
 
diff --git a/packages/core/src/utils/handle.ts b/packages/core/src/utils/handle.ts
index 4af31c19..ac401925 100644
--- a/packages/core/src/utils/handle.ts
+++ b/packages/core/src/utils/handle.ts
@@ -19,8 +19,7 @@ export interface ConnectionHandle {
 }
 
 export function resetRecentHandle(handleDomNode: Element): void {
-  handleDomNode?.classList.remove('vue-flow__handle-valid')
-  handleDomNode?.classList.remove('vue-flow__handle-connecting')
+  handleDomNode?.classList.remove('valid', 'connecting', 'vue-flow__handle-valid', 'vue-flow__handle-connecting')
 }
 
 // this functions collects all handles and adds an absolute position