feat: only trigger a pane 'click' if there is no movement.

This commit is contained in:
Jack Fishwick
2022-11-22 10:55:06 +00:00
parent 86a0d7b5ba
commit 00282c2cb4
@@ -117,7 +117,13 @@ const UserSelection = memo(({ isSelectionMode, onClick, onContextMenu, onWheel,
setUserSelectionRect(nextUserSelectRect); setUserSelectionRect(nextUserSelectRect);
}; };
const onMouseUp = () => { const onMouseUp = (event: React.MouseEvent) => {
// We only want to trigger click functions when in selection mode if
// the user did not move the mouse.
if (!userSelectionActive && userSelectionRect) {
onClick?.(event);
}
store.setState({ nodesSelectionActive: prevSelectedNodesCount.current > 0 }); store.setState({ nodesSelectionActive: prevSelectedNodesCount.current > 0 });
resetUserSelection(); resetUserSelection();
@@ -131,7 +137,6 @@ const UserSelection = memo(({ isSelectionMode, onClick, onContextMenu, onWheel,
const eventHandlers = const eventHandlers =
elementsSelectable && (isSelectionMode || userSelectionActive) elementsSelectable && (isSelectionMode || userSelectionActive)
? { ? {
onClick,
onContextMenu, onContextMenu,
onWheel, onWheel,
onMouseDown, onMouseDown,