alighasami/xyflow
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #4510 from bcakmakoglu/fix/handle-connectable

Browse Source 
fix(svelte): rename `isConnectable` to `handleConnectable`
This commit is contained in:
Moritz Klack
2024-08-06 09:39:55 +02:00
committed by GitHub
parent 69f53c0eff 12313a5b01
commit 0d07f9fb0e
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.changeset/curly-llamas-obey.md
+5
View File
@@ -0,0 +1,5 @@
---
'@xyflow/svelte': patch
---
Rename `isConnectable` prop locally to `isConnectableProp` to avoid naming collision with derived value of `isConnectable` in `<Handle>` component.
packages/svelte/src/lib/components/Handle/Handle.svelte
+4 -2
View File
@@ -21,7 +21,6 @@
export let type: $$Props['type'] = 'source'; export let type: $$Props['type'] = 'source';
export let position: $$Props['position'] = Position.Top; export let position: $$Props['position'] = Position.Top;
export let style: $$Props['style'] = undefined; export let style: $$Props['style'] = undefined;
export let isConnectable: $$Props['isConnectable'] = undefined;
export let isValidConnection: $$Props['isValidConnection'] = undefined; export let isValidConnection: $$Props['isValidConnection'] = undefined;
export let onconnect: $$Props['onconnect'] = undefined; export let onconnect: $$Props['onconnect'] = undefined;
export let ondisconnect: $$Props['ondisconnect'] = undefined; export let ondisconnect: $$Props['ondisconnect'] = undefined;
@@ -29,13 +28,16 @@
// export let isConnectableStart: $$Props['isConnectableStart'] = undefined; // export let isConnectableStart: $$Props['isConnectableStart'] = undefined;
// export let isConnectableEnd: $$Props['isConnectableEnd'] = undefined; // export let isConnectableEnd: $$Props['isConnectableEnd'] = undefined;
let isConnectableProp: $$Props['isConnectable'] = undefined;
export { isConnectableProp as isConnectable }
let className: $$Props['class'] = undefined; let className: $$Props['class'] = undefined;
export { className as class }; export { className as class };
$: isTarget = type === 'target'; $: isTarget = type === 'target';
const nodeId = getContext<string>('svelteflow__node_id'); const nodeId = getContext<string>('svelteflow__node_id');
const connectable = getContext<Writable<boolean>>('svelteflow__node_connectable'); const connectable = getContext<Writable<boolean>>('svelteflow__node_connectable');
$: isConnectable = isConnectable !== undefined ? isConnectable : $connectable; $: isConnectable = isConnectableProp !== undefined ? isConnectableProp : $connectable;
$: handleId = id || null; $: handleId = id || null;