Merge pull request #5370 from xyflow/fix/xyhandle-end-events

Fix/xyhandle end events

.changeset/strong-snails-melt.md

@@ -0,0 +1,5 @@
+---
+'@xyflow/system': patch
+---
+
+Only fire connection end events if connection was started

packages/system/src/xyhandle/XYHandle.ts

@@ -112,6 +112,7 @@ function onPointerDown(
   };
 
   function startConnection() {
+    connectionStarted = true;
     updateConnection(previousConnection);
     onConnectStart?.(event, { nodeId, handleId, handleType });
   }
@@ -132,8 +133,6 @@ function onPointerDown(
       }
 
       startConnection();
-
-      connectionStarted = nextConnectionStarted;
     }
 
     if (!getFromHandle() || !fromHandle) {
@@ -208,6 +207,7 @@ function onPointerDown(
   }
 
   function onPointerUp(event: MouseEvent | TouchEvent) {
+    if (connectionStarted) {
       if ((closestHandle || handleDomNode) && connection && isValid) {
         onConnect?.(connection);
       }
@@ -222,11 +222,13 @@ function onPointerDown(
         ...connectionState,
         toPosition: previousConnection.toHandle ? previousConnection.toPosition : null,
       };
+
       onConnectEnd?.(event, finalConnectionState);
 
       if (edgeUpdaterType) {
         onReconnectEnd?.(event, finalConnectionState);
       }
+    }
 
     cancelConnection();
     cancelAnimationFrame(autoPanId);