From 761a8a0876a7ba18acf2fa7d2393a128fa7478fb Mon Sep 17 00:00:00 2001 From: moklick Date: Wed, 20 Aug 2025 15:02:29 +0200 Subject: [PATCH 1/2] chore(types): remove dangerouslySetInnerHTML from domAttributes #5470 --- packages/react/src/types/edges.ts | 5 ++++- packages/react/src/types/nodes.ts | 1 + packages/svelte/src/lib/types/edges.ts | 2 +- packages/svelte/src/lib/types/nodes.ts | 1 + 4 files changed, 7 insertions(+), 2 deletions(-) diff --git a/packages/react/src/types/edges.ts b/packages/react/src/types/edges.ts index 2489fb12..f2b3db0d 100644 --- a/packages/react/src/types/edges.ts +++ b/packages/react/src/types/edges.ts @@ -72,7 +72,10 @@ export type Edge< /** * General escape hatch for adding custom attributes to the edge's DOM element. */ - domAttributes?: Omit, 'id' | 'style' | 'className' | 'role' | 'aria-label'>; + domAttributes?: Omit< + SVGAttributes, + 'id' | 'style' | 'className' | 'role' | 'aria-label' | 'dangerouslySetInnerHTML' + >; }; type SmoothStepEdge = Record> = Edge< diff --git a/packages/react/src/types/nodes.ts b/packages/react/src/types/nodes.ts index fce71470..dbd321e2 100644 --- a/packages/react/src/types/nodes.ts +++ b/packages/react/src/types/nodes.ts @@ -36,6 +36,7 @@ export type Node< | 'role' | 'aria-label' | 'defaultValue' + | 'dangerouslySetInnerHTML' | keyof DOMAttributes >; }; diff --git a/packages/svelte/src/lib/types/edges.ts b/packages/svelte/src/lib/types/edges.ts index 8b38797e..01e69ed3 100644 --- a/packages/svelte/src/lib/types/edges.ts +++ b/packages/svelte/src/lib/types/edges.ts @@ -35,7 +35,7 @@ export type Edge< */ domAttributes?: Omit< SVGAttributes, - 'id' | 'style' | 'class' | 'role' | 'aria-label' + 'id' | 'style' | 'class' | 'role' | 'aria-label' | 'dangerouslySetInnerHTML' >; }; diff --git a/packages/svelte/src/lib/types/nodes.ts b/packages/svelte/src/lib/types/nodes.ts index 69f2063f..7088e2ea 100644 --- a/packages/svelte/src/lib/types/nodes.ts +++ b/packages/svelte/src/lib/types/nodes.ts @@ -38,6 +38,7 @@ export type Node< | 'draggable' | 'role' | 'aria-label' + | 'dangerouslySetInnerHTML' | keyof DOMAttributes >; }; From 372c493a2f2008fd9eca7b00cece642d4335ed60 Mon Sep 17 00:00:00 2001 From: moklick Date: Wed, 20 Aug 2025 15:03:34 +0200 Subject: [PATCH 2/2] chore(changeset): add --- .changeset/curly-ants-deny.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changeset/curly-ants-deny.md diff --git a/.changeset/curly-ants-deny.md b/.changeset/curly-ants-deny.md new file mode 100644 index 00000000..fc1cab01 --- /dev/null +++ b/.changeset/curly-ants-deny.md @@ -0,0 +1,6 @@ +--- +'@xyflow/react': patch +'@xyflow/svelte': patch +--- + +Remove dangerouslySetInnerHTML from domAttributes