From f739c7fae129e143acf3765c0e768000f04c2b8e Mon Sep 17 00:00:00 2001 From: Svilen Ivanov <92510182+svilen-ivanov-kubit@users.noreply.github.com> Date: Thu, 30 Oct 2025 16:04:40 +0200 Subject: [PATCH 01/17] Avoid modifying node.measured object, create copy instead When working with immutable `node` data, modifying in-place `node.measured` properties is not allowed. Since we perform a shallow copy, we need to create a new `measured` object to populate `width` and `height` --- packages/react/src/utils/changes.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react/src/utils/changes.ts b/packages/react/src/utils/changes.ts index f2d9bdd3..422832f2 100644 --- a/packages/react/src/utils/changes.ts +++ b/packages/react/src/utils/changes.ts @@ -125,7 +125,7 @@ function applyChange(change: any, element: any): any { case 'dimensions': { if (typeof change.dimensions !== 'undefined') { - element.measured ??= {}; + element.measured = {}; element.measured.width = change.dimensions.width; element.measured.height = change.dimensions.height; From 8598b6bc2a9d052b12d5215706382da0aa84827b Mon Sep 17 00:00:00 2001 From: Adam Krebs Date: Tue, 11 Nov 2025 18:53:21 -0500 Subject: [PATCH 02/17] Allow getEdgeId to be overridden --- .changeset/custom-edge-id-generator.md | 5 +++ packages/system/src/utils/edges/general.ts | 37 +++++++++++++++++++--- 2 files changed, 38 insertions(+), 4 deletions(-) create mode 100644 .changeset/custom-edge-id-generator.md diff --git a/.changeset/custom-edge-id-generator.md b/.changeset/custom-edge-id-generator.md new file mode 100644 index 00000000..65947b75 --- /dev/null +++ b/.changeset/custom-edge-id-generator.md @@ -0,0 +1,5 @@ +--- +'@xyflow/system': minor +--- + +Allow custom `getEdgeId` function in `addEdge` and `reconnectEdge`. You can now pass a custom edge ID generator via the options parameter, enabling custom edge ID schemes. Closes #5180. diff --git a/packages/system/src/utils/edges/general.ts b/packages/system/src/utils/edges/general.ts index 58139394..515a285a 100644 --- a/packages/system/src/utils/edges/general.ts +++ b/packages/system/src/utils/edges/general.ts @@ -84,7 +84,19 @@ export function isEdgeVisible({ sourceNode, targetNode, width, height, transform return getOverlappingArea(viewRect, boxToRect(edgeBox)) > 0; } -const getEdgeId = ({ source, sourceHandle, target, targetHandle }: Connection | EdgeBase): string => +/** + * Type for a custom edge ID generator function. + * @public + */ +export type GetEdgeId = (params: Connection | EdgeBase) => string; + +/** + * The default edge ID generator function. Generates an ID based on the source, target, and handles. + * @public + * @param params - The connection or edge to generate an ID for. + * @returns The generated edge ID. + */ +export const getEdgeId = ({ source, sourceHandle, target, targetHandle }: Connection | EdgeBase): string => `xy-edge__${source}${sourceHandle || ''}-${target}${targetHandle || ''}`; const connectionExists = (edge: EdgeBase, edges: EdgeBase[]) => { @@ -97,11 +109,19 @@ const connectionExists = (edge: EdgeBase, edges: EdgeBase[]) => { ); }; +export type AddEdgeOptions = { + /** + * Custom function to generate edge IDs. If not provided, the default `getEdgeId` function is used. + */ + getEdgeId?: GetEdgeId; +}; + /** * This util is a convenience function to add a new Edge to an array of edges. It also performs some validation to make sure you don't add an invalid edge or duplicate an existing one. * @public * @param edgeParams - Either an `Edge` or a `Connection` you want to add. * @param edges - The array of all current edges. + * @param options - Optional configuration object. * @returns A new array of edges with the new edge added. * * @remarks If an edge with the same `target` and `source` already exists (and the same @@ -111,7 +131,8 @@ const connectionExists = (edge: EdgeBase, edges: EdgeBase[]) => { */ export const addEdge = ( edgeParams: EdgeType | Connection, - edges: EdgeType[] + edges: EdgeType[], + options: AddEdgeOptions = {} ): EdgeType[] => { if (!edgeParams.source || !edgeParams.target) { devWarn('006', errorMessages['error006']()); @@ -119,13 +140,15 @@ export const addEdge = ( return edges; } + const edgeIdGenerator = options.getEdgeId || getEdgeId; + let edge: EdgeType; if (isEdgeBase(edgeParams)) { edge = { ...edgeParams }; } else { edge = { ...edgeParams, - id: getEdgeId(edgeParams), + id: edgeIdGenerator(edgeParams), } as EdgeType; } @@ -150,6 +173,10 @@ export type ReconnectEdgeOptions = { * @default true */ shouldReplaceId?: boolean; + /** + * Custom function to generate edge IDs. If not provided, the default `getEdgeId` function is used. + */ + getEdgeId?: GetEdgeId; }; /** @@ -190,10 +217,12 @@ export const reconnectEdge = ( return edges; } + const edgeIdGenerator = options.getEdgeId || getEdgeId; + // Remove old edge and create the new edge with parameters of old edge. const edge = { ...rest, - id: options.shouldReplaceId ? getEdgeId(newConnection) : oldEdgeId, + id: options.shouldReplaceId ? edgeIdGenerator(newConnection) : oldEdgeId, source: newConnection.source, target: newConnection.target, sourceHandle: newConnection.sourceHandle, From cb2db9f2d223944d7710a0fc17cd9954be77f2c0 Mon Sep 17 00:00:00 2001 From: moklick Date: Wed, 12 Nov 2025 15:50:20 +0100 Subject: [PATCH 03/17] chore(reactflow): paneClickDistance default 1 --- packages/react/src/container/ReactFlow/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react/src/container/ReactFlow/index.tsx b/packages/react/src/container/ReactFlow/index.tsx index bd20242f..f01af831 100644 --- a/packages/react/src/container/ReactFlow/index.tsx +++ b/packages/react/src/container/ReactFlow/index.tsx @@ -104,7 +104,7 @@ function ReactFlow( onPaneMouseLeave, onPaneScroll, onPaneContextMenu, - paneClickDistance = 0, + paneClickDistance = 1, nodeClickDistance = 0, children, onReconnect, From c1304dba7a20bb8d74c7aceb23cd80b56e4c0482 Mon Sep 17 00:00:00 2001 From: moklick Date: Wed, 12 Nov 2025 15:51:03 +0100 Subject: [PATCH 04/17] chore(changesets): add --- .changeset/serious-peaches-fry.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/serious-peaches-fry.md diff --git a/.changeset/serious-peaches-fry.md b/.changeset/serious-peaches-fry.md new file mode 100644 index 00000000..2978ec99 --- /dev/null +++ b/.changeset/serious-peaches-fry.md @@ -0,0 +1,5 @@ +--- +'@xyflow/react': patch +--- + +Set `paneClickDistance` default value to `1`. From 26940018a805033bd6c0a46409616f4ae1b19a39 Mon Sep 17 00:00:00 2001 From: moklick Date: Thu, 13 Nov 2025 09:52:18 +0100 Subject: [PATCH 05/17] chore(changesets): update --- .changeset/sharp-toys-cheer.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.changeset/sharp-toys-cheer.md b/.changeset/sharp-toys-cheer.md index 885eebcc..36bbcdfc 100644 --- a/.changeset/sharp-toys-cheer.md +++ b/.changeset/sharp-toys-cheer.md @@ -1,6 +1,6 @@ --- -'@xyflow/react': minor -'@xyflow/svelte': minor +'@xyflow/react': patch +'@xyflow/svelte': patch '@xyflow/system': patch --- From 12c516d5f2c7b99849733fab031be02f788657fe Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Thu, 13 Nov 2025 08:53:39 +0000 Subject: [PATCH 06/17] chore(packages): bump --- .changeset/dirty-readers-hide.md | 5 ----- .changeset/plenty-lobsters-thank.md | 5 ----- .changeset/serious-peaches-fry.md | 5 ----- .changeset/sharp-toys-cheer.md | 7 ------- packages/react/CHANGELOG.md | 11 +++++++++++ packages/react/package.json | 2 +- packages/svelte/CHANGELOG.md | 13 +++++++++++++ packages/svelte/package.json | 2 +- packages/system/CHANGELOG.md | 6 ++++++ packages/system/package.json | 2 +- 10 files changed, 33 insertions(+), 25 deletions(-) delete mode 100644 .changeset/dirty-readers-hide.md delete mode 100644 .changeset/plenty-lobsters-thank.md delete mode 100644 .changeset/serious-peaches-fry.md delete mode 100644 .changeset/sharp-toys-cheer.md diff --git a/.changeset/dirty-readers-hide.md b/.changeset/dirty-readers-hide.md deleted file mode 100644 index 2ee6e044..00000000 --- a/.changeset/dirty-readers-hide.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@xyflow/svelte': patch ---- - -Fix onPaneClick always firing when moving the viewport diff --git a/.changeset/plenty-lobsters-thank.md b/.changeset/plenty-lobsters-thank.md deleted file mode 100644 index 49779920..00000000 --- a/.changeset/plenty-lobsters-thank.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@xyflow/svelte': patch ---- - -Fix wrong positions when resizing nodes with a non-default node-origin diff --git a/.changeset/serious-peaches-fry.md b/.changeset/serious-peaches-fry.md deleted file mode 100644 index 2978ec99..00000000 --- a/.changeset/serious-peaches-fry.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@xyflow/react': patch ---- - -Set `paneClickDistance` default value to `1`. diff --git a/.changeset/sharp-toys-cheer.md b/.changeset/sharp-toys-cheer.md deleted file mode 100644 index 36bbcdfc..00000000 --- a/.changeset/sharp-toys-cheer.md +++ /dev/null @@ -1,7 +0,0 @@ ---- -'@xyflow/react': patch -'@xyflow/svelte': patch -'@xyflow/system': patch ---- - -Pass current pointer position to connection diff --git a/packages/react/CHANGELOG.md b/packages/react/CHANGELOG.md index 700256b5..9197dd9f 100644 --- a/packages/react/CHANGELOG.md +++ b/packages/react/CHANGELOG.md @@ -1,5 +1,16 @@ # @xyflow/react +## 12.9.3 + +### Patch Changes + +- [#5621](https://github.com/xyflow/xyflow/pull/5621) [`c1304dba7`](https://github.com/xyflow/xyflow/commit/c1304dba7a20bb8d74c7aceb23cd80b56e4c0482) Thanks [@moklick](https://github.com/moklick)! - Set `paneClickDistance` default value to `1`. + +- [#5578](https://github.com/xyflow/xyflow/pull/5578) [`00bcb9f5f`](https://github.com/xyflow/xyflow/commit/00bcb9f5f45f49814b9ac19b3f55cfe069ee3773) Thanks [@peterkogo](https://github.com/peterkogo)! - Pass current pointer position to connection + +- Updated dependencies [[`00bcb9f5f`](https://github.com/xyflow/xyflow/commit/00bcb9f5f45f49814b9ac19b3f55cfe069ee3773)]: + - @xyflow/system@0.0.73 + ## 12.9.2 ### Patch Changes diff --git a/packages/react/package.json b/packages/react/package.json index 18074467..0514e3b4 100644 --- a/packages/react/package.json +++ b/packages/react/package.json @@ -1,6 +1,6 @@ { "name": "@xyflow/react", - "version": "12.9.2", + "version": "12.9.3", "description": "React Flow - A highly customizable React library for building node-based editors and interactive flow charts.", "keywords": [ "react", diff --git a/packages/svelte/CHANGELOG.md b/packages/svelte/CHANGELOG.md index fc6877d6..5cfe8b02 100644 --- a/packages/svelte/CHANGELOG.md +++ b/packages/svelte/CHANGELOG.md @@ -1,5 +1,18 @@ # @xyflow/svelte +## 1.4.2 + +### Patch Changes + +- [#5603](https://github.com/xyflow/xyflow/pull/5603) [`17a175791`](https://github.com/xyflow/xyflow/commit/17a175791b2420b32d55a8fcbbb35649862b85cf) Thanks [@peterkogo](https://github.com/peterkogo)! - Fix onPaneClick always firing when moving the viewport + +- [#5615](https://github.com/xyflow/xyflow/pull/5615) [`8b35c77eb`](https://github.com/xyflow/xyflow/commit/8b35c77ebe5a4f6cba33c597d94eba1ead64fdfc) Thanks [@peterkogo](https://github.com/peterkogo)! - Fix wrong positions when resizing nodes with a non-default node-origin + +- [#5578](https://github.com/xyflow/xyflow/pull/5578) [`00bcb9f5f`](https://github.com/xyflow/xyflow/commit/00bcb9f5f45f49814b9ac19b3f55cfe069ee3773) Thanks [@peterkogo](https://github.com/peterkogo)! - Pass current pointer position to connection + +- Updated dependencies [[`00bcb9f5f`](https://github.com/xyflow/xyflow/commit/00bcb9f5f45f49814b9ac19b3f55cfe069ee3773)]: + - @xyflow/system@0.0.73 + ## 1.4.1 ### Patch Changes diff --git a/packages/svelte/package.json b/packages/svelte/package.json index f78663de..c2dd3ba6 100644 --- a/packages/svelte/package.json +++ b/packages/svelte/package.json @@ -1,6 +1,6 @@ { "name": "@xyflow/svelte", - "version": "1.4.1", + "version": "1.4.2", "description": "Svelte Flow - A highly customizable Svelte library for building node-based editors, workflow systems, diagrams and more.", "keywords": [ "svelte", diff --git a/packages/system/CHANGELOG.md b/packages/system/CHANGELOG.md index ea065959..5bbc621e 100644 --- a/packages/system/CHANGELOG.md +++ b/packages/system/CHANGELOG.md @@ -1,5 +1,11 @@ # @xyflow/system +## 0.0.73 + +### Patch Changes + +- [#5578](https://github.com/xyflow/xyflow/pull/5578) [`00bcb9f5f`](https://github.com/xyflow/xyflow/commit/00bcb9f5f45f49814b9ac19b3f55cfe069ee3773) Thanks [@peterkogo](https://github.com/peterkogo)! - Pass current pointer position to connection + ## 0.0.72 ### Patch Changes diff --git a/packages/system/package.json b/packages/system/package.json index 55b2e164..6ee8e327 100644 --- a/packages/system/package.json +++ b/packages/system/package.json @@ -1,6 +1,6 @@ { "name": "@xyflow/system", - "version": "0.0.72", + "version": "0.0.73", "description": "xyflow core system that powers React Flow and Svelte Flow.", "keywords": [ "node-based UI", From 5161cf327991d690b69700ff506c9b8a27841bc4 Mon Sep 17 00:00:00 2001 From: Alaric Baraou Date: Mon, 17 Nov 2025 01:10:00 +0900 Subject: [PATCH 07/17] prevent re-render on every store update by using shallow in FlowRendererComponent useStore --- packages/react/src/container/FlowRenderer/index.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/react/src/container/FlowRenderer/index.tsx b/packages/react/src/container/FlowRenderer/index.tsx index d5083d80..5ab094ea 100644 --- a/packages/react/src/container/FlowRenderer/index.tsx +++ b/packages/react/src/container/FlowRenderer/index.tsx @@ -8,6 +8,7 @@ import { ZoomPane } from '../ZoomPane'; import { Pane } from '../Pane'; import { NodesSelection } from '../../components/NodesSelection'; import type { ReactFlowState, Node } from '../../types'; +import { shallow } from 'zustand/shallow'; export type FlowRendererProps = Omit< GraphViewProps, @@ -72,7 +73,7 @@ function FlowRendererComponent({ onViewportChange, isControlledViewport, }: FlowRendererProps) { - const { nodesSelectionActive, userSelectionActive } = useStore(selector); + const { nodesSelectionActive, userSelectionActive } = useStore(selector, shallow); const selectionKeyPressed = useKeyPress(selectionKeyCode, { target: win }); const panActivationKeyPressed = useKeyPress(panActivationKeyCode, { target: win }); From fb4d081364b8c6d00bf09ed6dca008f4b40c7e35 Mon Sep 17 00:00:00 2001 From: Stephan Eggermont Date: Sun, 16 Nov 2025 19:31:47 +0100 Subject: [PATCH 08/17] Typo README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 3ed80c4b..116e99c7 100644 --- a/README.md +++ b/README.md @@ -156,7 +156,7 @@ For releasing packages we are using [changesets](https://github.com/changesets/c 1. create PRs for new features, updates and fixes (with a changeset if relevant for changelog) 2. merge into main -3. changset creates a PR that bumps all packages based on the changesets +3. changeset creates a PR that bumps all packages based on the changesets 4. merge changeset PR if you want to release to Github and npm ## Built by [xyflow](https://xyflow.com) From 9030fab2df8285fdfb649bda6e1e885dfd228d45 Mon Sep 17 00:00:00 2001 From: moklick Date: Mon, 17 Nov 2025 10:08:43 +0100 Subject: [PATCH 09/17] chore(changesets): add --- .changeset/curly-snails-do.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/curly-snails-do.md diff --git a/.changeset/curly-snails-do.md b/.changeset/curly-snails-do.md new file mode 100644 index 00000000..5560b33b --- /dev/null +++ b/.changeset/curly-snails-do.md @@ -0,0 +1,5 @@ +--- +'@xyflow/react': patch +--- + +Prevent unnecessary re-render in `FlowRenderer` From 0102be3babc11ed1a5fdb883393bfdaa9bfbef45 Mon Sep 17 00:00:00 2001 From: moklick Date: Mon, 17 Nov 2025 10:15:42 +0100 Subject: [PATCH 10/17] chore(flow-renderer): cleanup imports --- packages/react/src/container/FlowRenderer/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react/src/container/FlowRenderer/index.tsx b/packages/react/src/container/FlowRenderer/index.tsx index 5ab094ea..2198ce5e 100644 --- a/packages/react/src/container/FlowRenderer/index.tsx +++ b/packages/react/src/container/FlowRenderer/index.tsx @@ -1,4 +1,5 @@ import { memo, type ReactNode } from 'react'; +import { shallow } from 'zustand/shallow'; import { useStore } from '../../hooks/useStore'; import { useGlobalKeyHandler } from '../../hooks/useGlobalKeyHandler'; @@ -8,7 +9,6 @@ import { ZoomPane } from '../ZoomPane'; import { Pane } from '../Pane'; import { NodesSelection } from '../../components/NodesSelection'; import type { ReactFlowState, Node } from '../../types'; -import { shallow } from 'zustand/shallow'; export type FlowRendererProps = Omit< GraphViewProps, From 99453f0993fdaceed3888ecb2e334bcb0e14eb2f Mon Sep 17 00:00:00 2001 From: Tornado Softwares Date: Tue, 18 Nov 2025 16:24:11 +0100 Subject: [PATCH 11/17] Fix #5633 --- packages/react/src/store/index.ts | 15 +++++++++++---- packages/svelte/src/lib/store/index.ts | 13 +++++++++++-- packages/system/src/xyhandle/XYHandle.ts | 7 +++++-- 3 files changed, 27 insertions(+), 8 deletions(-) diff --git a/packages/react/src/store/index.ts b/packages/react/src/store/index.ts index 3254bdfa..baef953c 100644 --- a/packages/react/src/store/index.ts +++ b/packages/react/src/store/index.ts @@ -14,6 +14,8 @@ import { NodeOrigin, CoordinateExtent, fitViewport, + getHandlePosition, + Position, } from '@xyflow/system'; import { applyEdgeChanges, applyNodeChanges, createSelectionChange, getSelectionChanges } from '../utils/changes'; @@ -176,7 +178,7 @@ const createStore = ({ updateNodePositions: (nodeDragItems, dragging = false) => { const parentExpandChildren: ParentExpandChild[] = []; const changes = []; - const { nodeLookup, triggerNodeChanges } = get(); + const { nodeLookup, triggerNodeChanges, connection, updateConnection } = get(); for (const [id, dragItem] of nodeDragItems) { // we are using the nodelookup to be sure to use the current expandParent and parentId value @@ -188,13 +190,18 @@ const createStore = ({ type: 'position', position: expandParent ? { - x: Math.max(0, dragItem.position.x), - y: Math.max(0, dragItem.position.y), - } + x: Math.max(0, dragItem.position.x), + y: Math.max(0, dragItem.position.y), + } : dragItem.position, dragging, }; + if (node && connection.inProgress && connection.fromNode.id == node.id) { + const updatedFrom = getHandlePosition(node, connection.fromHandle, Position.Left, true); + updateConnection({...connection,from: updatedFrom}) + } + if (expandParent && node.parentId) { parentExpandChildren.push({ id, diff --git a/packages/svelte/src/lib/store/index.ts b/packages/svelte/src/lib/store/index.ts index 798e87d8..4619a27e 100644 --- a/packages/svelte/src/lib/store/index.ts +++ b/packages/svelte/src/lib/store/index.ts @@ -15,7 +15,9 @@ import { updateAbsolutePositions, snapPosition, calculateNodePosition, - type SetCenterOptions + type SetCenterOptions, + getHandlePosition, + Position } from '@xyflow/system'; import type { EdgeTypes, NodeTypes, Node, Edge, FitViewOptions } from '$lib/types'; @@ -50,7 +52,14 @@ export function createStore { - store.nodes = store.nodes.map((node) => { + store.nodes = store.nodes.map((node) => { + if (store.connection.inProgress && store.connection.fromNode.id === node.id) { + + store.connection = { + ...store.connection, + from: getHandlePosition(store.nodeLookup.get(node.id), store.connection.fromHandle, Position.Left, true) + }; + } const dragItem = nodeDragItems.get(node.id); return dragItem ? { ...node, position: dragItem.position, dragging } : node; }); diff --git a/packages/system/src/xyhandle/XYHandle.ts b/packages/system/src/xyhandle/XYHandle.ts index 2e714e8b..40d04dff 100644 --- a/packages/system/src/xyhandle/XYHandle.ts +++ b/packages/system/src/xyhandle/XYHandle.ts @@ -171,10 +171,13 @@ function onPointerDown( resultHandleDomNode = result.handleDomNode; connection = result.connection; isValid = isConnectionValid(!!closestHandle, result.isValid); + + const fromNodeInternal = nodeLookup.get(nodeId)!; + const from = getHandlePosition(fromNodeInternal, fromHandle, Position.Left, true); - const newConnection: ConnectionInProgress = { - // from stays the same + const newConnection: ConnectionInProgress = { ...previousConnection, + from, isValid, to: result.toHandle && isValid From 9f7884b1bfd43dae1da81bf30af8eddad226d51e Mon Sep 17 00:00:00 2001 From: Moritz Klack Date: Tue, 25 Nov 2025 10:42:15 +0100 Subject: [PATCH 12/17] Update custom-edge-id-generator.md --- .changeset/custom-edge-id-generator.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/custom-edge-id-generator.md b/.changeset/custom-edge-id-generator.md index 65947b75..9b2e1bb8 100644 --- a/.changeset/custom-edge-id-generator.md +++ b/.changeset/custom-edge-id-generator.md @@ -2,4 +2,4 @@ '@xyflow/system': minor --- -Allow custom `getEdgeId` function in `addEdge` and `reconnectEdge`. You can now pass a custom edge ID generator via the options parameter, enabling custom edge ID schemes. Closes #5180. +Allow custom `getEdgeId` function in `addEdge` and `reconnectEdge` options to enable custom edge ID schemes. From 487c3470f997fd405fea1cc55013a3c88bf7e116 Mon Sep 17 00:00:00 2001 From: Moritz Klack Date: Tue, 25 Nov 2025 10:42:49 +0100 Subject: [PATCH 13/17] Change version from minor to patch for custom edge ID Allow custom `getEdgeId` function in `addEdge` and `reconnectEdge` options to enable custom edge ID schemes. --- .changeset/custom-edge-id-generator.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/custom-edge-id-generator.md b/.changeset/custom-edge-id-generator.md index 9b2e1bb8..439d729c 100644 --- a/.changeset/custom-edge-id-generator.md +++ b/.changeset/custom-edge-id-generator.md @@ -1,5 +1,5 @@ --- -'@xyflow/system': minor +'@xyflow/system': patch --- Allow custom `getEdgeId` function in `addEdge` and `reconnectEdge` options to enable custom edge ID schemes. From f617616dc9e9647c99c48fdb38a090c2d46390a2 Mon Sep 17 00:00:00 2001 From: moklick Date: Tue, 25 Nov 2025 11:01:27 +0100 Subject: [PATCH 14/17] chore(xyhandle): cleanup --- packages/react/src/store/index.ts | 10 +++++----- packages/svelte/src/lib/store/index.ts | 14 ++++++++------ packages/system/src/xyhandle/XYHandle.ts | 16 +++++++++------- 3 files changed, 22 insertions(+), 18 deletions(-) diff --git a/packages/react/src/store/index.ts b/packages/react/src/store/index.ts index baef953c..d6ff3b60 100644 --- a/packages/react/src/store/index.ts +++ b/packages/react/src/store/index.ts @@ -190,16 +190,16 @@ const createStore = ({ type: 'position', position: expandParent ? { - x: Math.max(0, dragItem.position.x), - y: Math.max(0, dragItem.position.y), - } + x: Math.max(0, dragItem.position.x), + y: Math.max(0, dragItem.position.y), + } : dragItem.position, dragging, }; - if (node && connection.inProgress && connection.fromNode.id == node.id) { + if (node && connection.inProgress && connection.fromNode.id === node.id) { const updatedFrom = getHandlePosition(node, connection.fromHandle, Position.Left, true); - updateConnection({...connection,from: updatedFrom}) + updateConnection({ ...connection, from: updatedFrom }); } if (expandParent && node.parentId) { diff --git a/packages/svelte/src/lib/store/index.ts b/packages/svelte/src/lib/store/index.ts index 4619a27e..30bcafc1 100644 --- a/packages/svelte/src/lib/store/index.ts +++ b/packages/svelte/src/lib/store/index.ts @@ -52,13 +52,15 @@ export function createStore { - store.nodes = store.nodes.map((node) => { + store.nodes = store.nodes.map((node) => { if (store.connection.inProgress && store.connection.fromNode.id === node.id) { - - store.connection = { - ...store.connection, - from: getHandlePosition(store.nodeLookup.get(node.id), store.connection.fromHandle, Position.Left, true) - }; + const internalNode = store.nodeLookup.get(node.id); + if (internalNode) { + store.connection = { + ...store.connection, + from: getHandlePosition(internalNode, store.connection.fromHandle, Position.Left, true) + }; + } } const dragItem = nodeDragItems.get(node.id); return dragItem ? { ...node, position: dragItem.position, dragging } : node; diff --git a/packages/system/src/xyhandle/XYHandle.ts b/packages/system/src/xyhandle/XYHandle.ts index 40d04dff..b8edf767 100644 --- a/packages/system/src/xyhandle/XYHandle.ts +++ b/packages/system/src/xyhandle/XYHandle.ts @@ -93,8 +93,8 @@ function onPointerDown( position: fromHandleInternal.position, }; - const fromNodeInternal = nodeLookup.get(nodeId)!; - const from = getHandlePosition(fromNodeInternal, fromHandle, Position.Left, true); + const fromInternalNode = nodeLookup.get(nodeId)!; + const from = getHandlePosition(fromInternalNode, fromHandle, Position.Left, true); let previousConnection: ConnectionInProgress = { inProgress: true, @@ -103,7 +103,7 @@ function onPointerDown( from, fromHandle, fromPosition: fromHandle.position, - fromNode: fromNodeInternal, + fromNode: fromInternalNode, to: position, toHandle: null, @@ -171,11 +171,13 @@ function onPointerDown( resultHandleDomNode = result.handleDomNode; connection = result.connection; isValid = isConnectionValid(!!closestHandle, result.isValid); - - const fromNodeInternal = nodeLookup.get(nodeId)!; - const from = getHandlePosition(fromNodeInternal, fromHandle, Position.Left, true); - const newConnection: ConnectionInProgress = { + const fromInternalNode = nodeLookup.get(nodeId); + const from = fromInternalNode + ? getHandlePosition(fromInternalNode, fromHandle, Position.Left, true) + : previousConnection.from; + + const newConnection: ConnectionInProgress = { ...previousConnection, from, isValid, From 2d7fa40e2684a0fcdd4eca7800ccf2c34338e549 Mon Sep 17 00:00:00 2001 From: moklick Date: Tue, 25 Nov 2025 11:04:35 +0100 Subject: [PATCH 15/17] chore(changesets): add --- .changeset/young-roses-shout.md | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 .changeset/young-roses-shout.md diff --git a/.changeset/young-roses-shout.md b/.changeset/young-roses-shout.md new file mode 100644 index 00000000..f1f6a888 --- /dev/null +++ b/.changeset/young-roses-shout.md @@ -0,0 +1,7 @@ +--- +'@xyflow/react': patch +'@xyflow/svelte': patch +'@xyflow/system': patch +--- + +Update an ongoing connection when user moves node with keyboard. From f858cbb404ccb3ddcaf55563aec73f85e44d58bf Mon Sep 17 00:00:00 2001 From: moklick Date: Tue, 25 Nov 2025 12:34:49 +0100 Subject: [PATCH 16/17] chore(apply-changes): cleanup) --- packages/react/src/utils/changes.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/react/src/utils/changes.ts b/packages/react/src/utils/changes.ts index 422832f2..de05236a 100644 --- a/packages/react/src/utils/changes.ts +++ b/packages/react/src/utils/changes.ts @@ -125,9 +125,9 @@ function applyChange(change: any, element: any): any { case 'dimensions': { if (typeof change.dimensions !== 'undefined') { - element.measured = {}; - element.measured.width = change.dimensions.width; - element.measured.height = change.dimensions.height; + element.measured = { + ...change.dimensions, + }; if (change.setAttributes) { if (change.setAttributes === true || change.setAttributes === 'width') { From 38dbf41c464550cc803b946a4ad1f46982385a03 Mon Sep 17 00:00:00 2001 From: moklick Date: Tue, 25 Nov 2025 12:35:50 +0100 Subject: [PATCH 17/17] chore(changesets): add --- .changeset/dry-seahorses-deliver.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/dry-seahorses-deliver.md diff --git a/.changeset/dry-seahorses-deliver.md b/.changeset/dry-seahorses-deliver.md new file mode 100644 index 00000000..1125ea3e --- /dev/null +++ b/.changeset/dry-seahorses-deliver.md @@ -0,0 +1,5 @@ +--- +'@xyflow/react': patch +--- + +Always create a new measured object in apply changes.