alighasami/xyflow
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #5682 from artemtam/main

Browse Source 
Prevent unnecessary updates when selectNodesOnDrag = false
This commit is contained in:
Moritz Klack
2026-02-02 12:21:12 +01:00
committed by GitHub
parent 3f93f828ec 89062ef506
commit 39ff6e94b5
2 changed files with 27 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/friendly-grapes-lay.md Normal file
View File

@@ -0,0 +1,5 @@
---
'@xyflow/react': patch
---
Prevent unnecessary updates when selectNodesOnDrag = false

27
packages/react/src/store/index.ts
View File

@@ -304,8 +304,16 @@ const createStore = ({
const { edges: storeEdges, nodes: storeNodes, nodeLookup, triggerNodeChanges, triggerEdgeChanges } = get();
const nodesToUnselect = nodes ? nodes : storeNodes;
const edgesToUnselect = edges ? edges : storeEdges;
const nodeChanges = nodesToUnselect.map((n) => {
const internalNode = nodeLookup.get(n.id);
const nodeChanges: NodeSelectionChange[] = [];
for (const node of nodesToUnselect) {
if (!node.selected) {
continue; // skip changing nodes that are not selected
}
const internalNode = nodeLookup.get(node.id);
if (internalNode) {
/*
* we need to unselect the internal node that was selected previously before we
@@ -314,9 +322,18 @@ const createStore = ({
internalNode.selected = false;
}
return createSelectionChange(n.id, false);
});
const edgeChanges = edgesToUnselect.map((edge) => createSelectionChange(edge.id, false));
nodeChanges.push(createSelectionChange(node.id, false));
}
const edgeChanges: EdgeSelectionChange[] = [];
for (const edge of edgesToUnselect) {
if (!edge.selected) {
continue; // skip changing edges that are not selected
}
edgeChanges.push(createSelectionChange(edge.id, false));
}
triggerNodeChanges(nodeChanges);
triggerEdgeChanges(edgeChanges);