From 5e96fa08edd5c911cdd20461b750a630a2573c0e Mon Sep 17 00:00:00 2001 From: moklick Date: Mon, 24 Jun 2024 12:57:52 +0200 Subject: [PATCH 1/2] chore(tsconfig): update moduleResolution --- examples/react/tsconfig.json | 2 +- tooling/tsconfig/base.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/react/tsconfig.json b/examples/react/tsconfig.json index 3b8a70ac..8ea25518 100644 --- a/examples/react/tsconfig.json +++ b/examples/react/tsconfig.json @@ -10,7 +10,7 @@ "strict": true, "forceConsistentCasingInFileNames": true, "module": "ESNext", - "moduleResolution": "Node16", + "moduleResolution": "node16", "resolveJsonModule": true, "isolatedModules": true, "noEmit": true, diff --git a/tooling/tsconfig/base.json b/tooling/tsconfig/base.json index ae8348e4..76ab90a4 100644 --- a/tooling/tsconfig/base.json +++ b/tooling/tsconfig/base.json @@ -10,7 +10,7 @@ "forceConsistentCasingInFileNames": true, "inlineSources": false, "isolatedModules": true, - "moduleResolution": "node", + "moduleResolution": "bundler", "noFallthroughCasesInSwitch": true, "noImplicitAny": true, "noImplicitReturns": false, From e179324264691b4e336262b52dcb346b4a1f101c Mon Sep 17 00:00:00 2001 From: moklick Date: Wed, 26 Jun 2024 16:59:38 +0200 Subject: [PATCH 2/2] chore(connection-line): variable name --- packages/react/src/components/ConnectionLine/index.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react/src/components/ConnectionLine/index.tsx b/packages/react/src/components/ConnectionLine/index.tsx index f79bfe24..56acd9ac 100644 --- a/packages/react/src/components/ConnectionLine/index.tsx +++ b/packages/react/src/components/ConnectionLine/index.tsx @@ -154,9 +154,9 @@ const selector = (s: ReactFlowState) => ({ export function ConnectionLineWrapper({ containerStyle, style, type, component }: ConnectionLineWrapperProps) { const { nodeId, handleType, nodesConnectable, width, height, isValid } = useStore(selector, shallow); - const isIncorrect = !(nodeId && handleType && width && nodesConnectable); + const renderConnectionLine = !!(nodeId && handleType && width && nodesConnectable); - if (isIncorrect) { + if (!renderConnectionLine) { return null; }