refactor(nested-nodes): zIndex

This commit is contained in:
moklick
2021-10-20 19:26:22 +02:00
parent 9350884836
commit 450cb90e67
3 changed files with 107 additions and 103 deletions
+2 -1
View File
@@ -48,6 +48,7 @@ export default (NodeComponent: ComponentType<NodeComponentProps>) => {
isDragging, isDragging,
resizeObserver, resizeObserver,
dragHandle, dragHandle,
zIndex,
}: WrapNodeProps) => { }: WrapNodeProps) => {
const { const {
addSelectedElements, addSelectedElements,
@@ -63,7 +64,7 @@ export default (NodeComponent: ComponentType<NodeComponentProps>) => {
const nodeStyle: CSSProperties = useMemo( const nodeStyle: CSSProperties = useMemo(
() => ({ () => ({
zIndex: isSelected ? 10 : 3, zIndex: isSelected ? zIndex + 1 : zIndex,
transform: `translate(${xPos}px,${yPos}px)`, transform: `translate(${xPos}px,${yPos}px)`,
pointerEvents: pointerEvents:
isSelectable || isDraggable || onClick || onMouseEnter || onMouseMove || onMouseLeave ? 'all' : 'none', isSelectable || isDraggable || onClick || onMouseEnter || onMouseMove || onMouseLeave ? 'all' : 'none',
+16 -14
View File
@@ -39,10 +39,10 @@ interface NodesProps extends NodeRendererProps {
nodesDraggable: boolean; nodesDraggable: boolean;
nodesConnectable: boolean; nodesConnectable: boolean;
elementsSelectable: boolean; elementsSelectable: boolean;
recursionDepth: number;
} }
const Nodes = memo( function Nodes({
({
nodes = [], nodes = [],
isDraggable, isDraggable,
resizeObserver, resizeObserver,
@@ -52,11 +52,10 @@ const Nodes = memo(
nodesDraggable, nodesDraggable,
nodesConnectable, nodesConnectable,
elementsSelectable, elementsSelectable,
recursionDepth,
...props ...props
}: NodesProps) => { }: NodesProps): any {
return ( return nodes.map((node) => {
<>
{nodes.map((node) => {
const nodeType = node.type || 'default'; const nodeType = node.type || 'default';
if (!props.nodeTypes[nodeType]) { if (!props.nodeTypes[nodeType]) {
@@ -75,9 +74,10 @@ const Nodes = memo(
node.height !== null && node.height !== null &&
typeof node.width !== 'undefined' && typeof node.width !== 'undefined' &&
typeof node.height !== 'undefined'; typeof node.height !== 'undefined';
let childRect;
if (node.childNodes) { if (node.childNodes) {
const childRect = getRectOfNodes(node.childNodes); childRect = getRectOfNodes(node.childNodes);
node.position = node.isDragging node.position = node.isDragging
? node.position ? node.position
: { x: Math.round(childRect.x) - 10, y: Math.round(childRect.y) - 10 }; : { x: Math.round(childRect.x) - 10, y: Math.round(childRect.y) - 10 };
@@ -123,9 +123,10 @@ const Nodes = memo(
isConnectable={isConnectable} isConnectable={isConnectable}
resizeObserver={resizeObserver} resizeObserver={resizeObserver}
dragHandle={node.dragHandle} dragHandle={node.dragHandle}
zIndex={3 + recursionDepth}
/> />
{node.childNodes && ( {node.childNodes && (
<Nodes <MemoizedNodes
nodes={node.childNodes} nodes={node.childNodes}
snapToGrid={snapToGrid} snapToGrid={snapToGrid}
snapGrid={snapGrid} snapGrid={snapGrid}
@@ -134,16 +135,16 @@ const Nodes = memo(
resizeObserver={resizeObserver} resizeObserver={resizeObserver}
elementsSelectable={elementsSelectable} elementsSelectable={elementsSelectable}
scale={scale} scale={scale}
recursionDepth={recursionDepth + 1}
{...props} {...props}
/> />
)} )}
</Fragment> </Fragment>
); );
})} });
</> }
);
} const MemoizedNodes = memo(Nodes);
);
const NodeRenderer = (props: NodeRendererProps) => { const NodeRenderer = (props: NodeRendererProps) => {
const { const {
@@ -191,7 +192,7 @@ const NodeRenderer = (props: NodeRendererProps) => {
return ( return (
<div className="react-flow__nodes" style={transformStyle}> <div className="react-flow__nodes" style={transformStyle}>
<Nodes <MemoizedNodes
nodes={nodes} nodes={nodes}
snapToGrid={snapToGrid} snapToGrid={snapToGrid}
snapGrid={snapGrid} snapGrid={snapGrid}
@@ -200,6 +201,7 @@ const NodeRenderer = (props: NodeRendererProps) => {
resizeObserver={resizeObserver} resizeObserver={resizeObserver}
elementsSelectable={elementsSelectable} elementsSelectable={elementsSelectable}
scale={transform[2]} scale={transform[2]}
recursionDepth={0}
{...props} {...props}
/> />
</div> </div>
+1
View File
@@ -300,6 +300,7 @@ export interface WrapNodeProps<T = any> {
isDragging?: boolean; isDragging?: boolean;
resizeObserver: ResizeObserver | null; resizeObserver: ResizeObserver | null;
dragHandle?: string; dragHandle?: string;
zIndex: number;
} }
export type FitViewParams = { export type FitViewParams = {