From 45c407755f184c877739e45fed3fc0b5abee5535 Mon Sep 17 00:00:00 2001 From: Jack Fishwick Date: Fri, 23 Sep 2022 16:06:24 +0100 Subject: [PATCH] feat: only click when not moved. --- packages/core/src/components/UserSelection/index.tsx | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/core/src/components/UserSelection/index.tsx b/packages/core/src/components/UserSelection/index.tsx index b39f10ab..65cb1d2d 100644 --- a/packages/core/src/components/UserSelection/index.tsx +++ b/packages/core/src/components/UserSelection/index.tsx @@ -130,8 +130,13 @@ const UserSelection = memo(({ selectionKeyPressed, onClick, onContextMenu, onWhe setUserSelectionRect(nextUserSelectRect); }; - const onMouseUp = () => { + const onMouseUp = (event: React.MouseEvent) => { store.setState({ nodesSelectionActive: prevSelectedNodesCount.current > 0 }); + + if (!store.getState().userSelectionActive) { + onClick?.(event); + } + resetUserSelection(); }; @@ -147,7 +152,6 @@ const UserSelection = memo(({ selectionKeyPressed, onClick, onContextMenu, onWhe onMouseMove={onMouseMove} onMouseUp={onMouseUp} onMouseLeave={onMouseLeave} - onClick={onClick} onContextMenu={onContextMenu} onWheel={onWheel} >