chore(store): cleanup

packages/react/src/store/initialState.ts

@@ -25,7 +25,10 @@ const getInitialState = ({
 } = {}): ReactFlowStore => {
   const nodeLookup = new Map();
   const connectionLookup = updateConnectionLookup(new Map(), edges);
-  const nextNodes = adoptUserProvidedNodes(nodes, nodeLookup, { nodeOrigin: [0, 0], elevateNodesOnSelect: false });
+  const nextNodes = adoptUserProvidedNodes(nodes, nodeLookup, {
+    nodeOrigin: [0, 0],
+    elevateNodesOnSelect: false,
+  });
 
   let transform: Transform = [0, 0, 1];
 

packages/svelte/src/lib/store/utils.ts

@@ -11,8 +11,6 @@ import {
   updateConnectionLookup,
   type Viewport,
   type PanZoomInstance,
-  type Viewport,
-  type PanZoomInstance,
   type ConnectionLookup
 } from '@xyflow/system';
 

packages/system/src/types/nodes.ts

@@ -43,7 +43,7 @@ export type NodeBase<T = any, U extends string | undefined = string | undefined>
     /** Holds a reference to the original node object provided by the user
      * (which may lack some fields, like `computed` or `[internalSymbol]`. Used
      * as an optimization to avoid certain operations. */
-    userProvidedNode: WeakRef<NodeBase>;
+    userProvidedNode: NodeBase<T, U>;
   };
 };
 

packages/system/src/utils/store.ts

@@ -80,7 +80,10 @@ export function adoptUserProvidedNodes<NodeType extends NodeBase>(
 
   const nextNodes = nodes.map((n) => {
     const currentStoreNode = tmpLookup.get(n.id);
-    if (n === currentStoreNode?.[internalsSymbol]?.userProvidedNode.deref()) return currentStoreNode;
+    if (n === currentStoreNode?.[internalsSymbol]?.userProvidedNode) {
+      nodeLookup.set(n.id, currentStoreNode);
+      return currentStoreNode;
+    }
 
     const node: NodeType = {
       ...options.defaults,
@@ -103,7 +106,7 @@ export function adoptUserProvidedNodes<NodeType extends NodeBase>(
       value: {
         handleBounds: currInternals?.handleBounds,
         z,
-        userProvidedNode: new WeakRef(n),
+        userProvidedNode: n,
       },
     });
 
@@ -144,14 +147,14 @@ function calculateXYZPosition<NodeType extends NodeBase>(
   );
 }
 
-export function updateNodeDimensions(
+export function updateNodeDimensions<NodeType extends NodeBase>(
   updates: Map<string, NodeDimensionUpdate>,
-  nodes: NodeBase[],
+  nodes: NodeType[],
-  nodeLookup: Map<string, NodeBase>,
+  nodeLookup: Map<string, NodeType>,
   domNode: HTMLElement | null,
   nodeOrigin?: NodeOrigin,
   onUpdate?: (id: string, dimensions: Dimensions) => void
-): NodeBase[] | null {
+): NodeType[] | null {
   const viewportNode = domNode?.querySelector('.xyflow__viewport');
 
   if (!viewportNode) {