Cleanup of cond. statements by leveraging d3.drag.filter for handleSelector in useDrag
This commit is contained in:
+6
-11
@@ -71,16 +71,11 @@ function useDrag({
|
|||||||
if (nodeRef?.current) {
|
if (nodeRef?.current) {
|
||||||
const selection = select(nodeRef.current);
|
const selection = select(nodeRef.current);
|
||||||
|
|
||||||
let isDragAllowedBySelector = true;
|
|
||||||
if (disabled) {
|
if (disabled) {
|
||||||
selection.on('.drag', null);
|
selection.on('.drag', null);
|
||||||
} else {
|
} else {
|
||||||
const dragHandler = drag()
|
const dragHandler = drag()
|
||||||
.on('start', (event: UseDragEvent) => {
|
.on('start', (event: UseDragEvent) => {
|
||||||
if (handleSelector) {
|
|
||||||
isDragAllowedBySelector = selectorExistsTargetToNode(event.sourceEvent.target, handleSelector, nodeRef);
|
|
||||||
}
|
|
||||||
if (isDragAllowedBySelector) {
|
|
||||||
const { transform, nodeInternals } = store.getState();
|
const { transform, nodeInternals } = store.getState();
|
||||||
const offset = getOffset(event, nodeRef);
|
const offset = getOffset(event, nodeRef);
|
||||||
parentPos.current = getParentNodePosition(nodeInternals, nodeId);
|
parentPos.current = getParentNodePosition(nodeInternals, nodeId);
|
||||||
@@ -91,10 +86,8 @@ function useDrag({
|
|||||||
};
|
};
|
||||||
|
|
||||||
onStart(event);
|
onStart(event);
|
||||||
}
|
|
||||||
})
|
})
|
||||||
.on('drag', (event: UseDragEvent) => {
|
.on('drag', (event: UseDragEvent) => {
|
||||||
if (isDragAllowedBySelector) {
|
|
||||||
const { transform, snapGrid, snapToGrid } = store.getState();
|
const { transform, snapGrid, snapToGrid } = store.getState();
|
||||||
const pos = pointToRendererPoint(
|
const pos = pointToRendererPoint(
|
||||||
{
|
{
|
||||||
@@ -117,16 +110,18 @@ function useDrag({
|
|||||||
dx: pos.x,
|
dx: pos.x,
|
||||||
dy: pos.y,
|
dy: pos.y,
|
||||||
});
|
});
|
||||||
}
|
|
||||||
|
|
||||||
event.on('end', (event) => {
|
event.on('end', (event) => {
|
||||||
if (isDragAllowedBySelector) {
|
|
||||||
onStop(event);
|
onStop(event);
|
||||||
}
|
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
})
|
})
|
||||||
.filter((event: any) => !event.ctrlKey && !event.button && !event.target.className.includes(noDragClassName));
|
.filter((event: any) => {
|
||||||
|
const filter = !event.ctrlKey && !event.button && !event.target.className.includes(noDragClassName);
|
||||||
|
return handleSelector
|
||||||
|
? selectorExistsTargetToNode(event.target, handleSelector, nodeRef) && filter
|
||||||
|
: filter;
|
||||||
|
});
|
||||||
|
|
||||||
selection.call(dragHandler);
|
selection.call(dragHandler);
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user