alighasami/xyflow
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

extract magic numbers

Browse Source
This commit is contained in:
peterkogo
2025-10-16 15:12:36 +02:00
parent fb94327c10
commit 5f9013bb67
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/system/src/utils/store.ts
+6 -3
View File
@@ -30,6 +30,9 @@ import {
import { getNodePositionWithOrigin } from './graph'; import { getNodePositionWithOrigin } from './graph';
import { ParentExpandChild } from './types'; import { ParentExpandChild } from './types';
const SELECTED_NODE_Z = 1000;
const ROOT_PARENT_Z_INCREMENT = 10;
const defaultOptions = { const defaultOptions = {
nodeOrigin: [0, 0] as NodeOrigin, nodeOrigin: [0, 0] as NodeOrigin,
nodeExtent: infiniteExtent, nodeExtent: infiniteExtent,
@@ -123,7 +126,7 @@ export function adoptUserNodes<NodeType extends NodeBase>(
let rootParentIndex = { i: -1 }; let rootParentIndex = { i: -1 };
let nodesInitialized = nodes.length > 0; let nodesInitialized = nodes.length > 0;
const tmpLookup = new Map(nodeLookup); const tmpLookup = new Map(nodeLookup);
const selectedNodeZ: number = _options?.elevateNodesOnSelect ? 1000 : 0; const selectedNodeZ: number = _options?.elevateNodesOnSelect ? SELECTED_NODE_Z : 0;
nodeLookup.clear(); nodeLookup.clear();
parentLookup.clear(); parentLookup.clear();
@@ -217,7 +220,7 @@ function updateChildNode<NodeType extends NodeBase>(
// We just want to set the rootParentIndex for the first child // We just want to set the rootParentIndex for the first child
if (rootParentIndex && !parentNode.parentId && parentNode.internals.rootParentIndex === undefined) { if (rootParentIndex && !parentNode.parentId && parentNode.internals.rootParentIndex === undefined) {
parentNode.internals.rootParentIndex = ++rootParentIndex.i; parentNode.internals.rootParentIndex = ++rootParentIndex.i;
parentNode.internals.z = parentNode.internals.z + rootParentIndex.i * 10; parentNode.internals.z = parentNode.internals.z + rootParentIndex.i * ROOT_PARENT_Z_INCREMENT;
} }
// But we need to update rootParentIndex.i also when parent has not been updated // But we need to update rootParentIndex.i also when parent has not been updated
@@ -225,7 +228,7 @@ function updateChildNode<NodeType extends NodeBase>(
rootParentIndex.i = parentNode.internals.rootParentIndex; rootParentIndex.i = parentNode.internals.rootParentIndex;
} }
const selectedNodeZ = elevateNodesOnSelect ? 1000 : 0; const selectedNodeZ = elevateNodesOnSelect ? SELECTED_NODE_Z : 0;
const { x, y, z } = calculateChildXYZ(node, parentNode, nodeOrigin, nodeExtent, selectedNodeZ); const { x, y, z } = calculateChildXYZ(node, parentNode, nodeOrigin, nodeExtent, selectedNodeZ);
const { positionAbsolute } = node.internals; const { positionAbsolute } = node.internals;
const positionChanged = x !== positionAbsolute.x || y !== positionAbsolute.y; const positionChanged = x !== positionAbsolute.x || y !== positionAbsolute.y;