From 68f7d6c9a3d1b6c7b825bb2a84cd9829c4c86cea Mon Sep 17 00:00:00 2001 From: moklick Date: Tue, 4 Jun 2024 14:40:38 +0200 Subject: [PATCH] chore(svelte): cleanup internal nodes and edges --- .../edges/BezierEdgeInternal.svelte | 22 ++----------- .../edges/SmoothStepEdgeInternal.svelte | 22 ++----------- .../components/edges/StepEdgeInternal.svelte | 22 ++----------- .../edges/StraightEdgeInternal.svelte | 26 ++------------- .../lib/components/nodes/DefaultNode.svelte | 27 ++------------- .../src/lib/components/nodes/GroupNode.svelte | 33 ++----------------- .../src/lib/components/nodes/InputNode.svelte | 29 ++-------------- .../lib/components/nodes/OutputNode.svelte | 29 ++-------------- 8 files changed, 16 insertions(+), 194 deletions(-) diff --git a/packages/svelte/src/lib/components/edges/BezierEdgeInternal.svelte b/packages/svelte/src/lib/components/edges/BezierEdgeInternal.svelte index 3f6c13e7..967698d5 100644 --- a/packages/svelte/src/lib/components/edges/BezierEdgeInternal.svelte +++ b/packages/svelte/src/lib/components/edges/BezierEdgeInternal.svelte @@ -6,16 +6,8 @@ type $$Props = EdgeProps; - // these props are not used in this edge, but passed to every custom edge component - export let id: $$Props['id'] = ''; - export let source: $$Props['source'] = ''; - export let target: $$Props['target'] = ''; - export let type: $$Props['type'] = 'default'; - export let animated: $$Props['animated'] = undefined; - export let selected: $$Props['selected'] = undefined; export let label: $$Props['label'] = undefined; export let labelStyle: $$Props['labelStyle'] = undefined; - export let data: $$Props['data'] = undefined; export let style: $$Props['style'] = undefined; export let markerStart: $$Props['markerStart'] = undefined; export let markerEnd: $$Props['markerEnd'] = undefined; @@ -24,12 +16,10 @@ export let sourceX: $$Props['sourceX']; export let sourceY: $$Props['sourceY']; export let sourcePosition: $$Props['sourcePosition']; - export let sourceHandleId: $$Props['sourceHandleId'] = undefined; export let targetX: $$Props['targetX']; export let targetY: $$Props['targetY']; export let targetPosition: $$Props['targetPosition']; - export let targetHandleId: $$Props['targetHandleId'] = undefined; $: [path, labelX, labelY] = getBezierPath({ sourceX, @@ -40,16 +30,8 @@ targetPosition }); - // hopefully with Svelte5, we don't need this kind of workaround anymore - id; - source; - target; - type; - animated; - selected; - data; - sourceHandleId; - targetHandleId; + // this is a workaround for suppressing the warning about unused props + $$restProps; diff --git a/packages/svelte/src/lib/components/nodes/GroupNode.svelte b/packages/svelte/src/lib/components/nodes/GroupNode.svelte index d22e0412..b5a202ea 100644 --- a/packages/svelte/src/lib/components/nodes/GroupNode.svelte +++ b/packages/svelte/src/lib/components/nodes/GroupNode.svelte @@ -3,35 +3,6 @@ interface $$Props extends NodeProps {} - // unused props - we need to list them here in order to prevent warnings - export let id: $$Props['id'] = ''; - export let width: $$Props['width'] = undefined; - export let height: $$Props['height'] = undefined; - export let data: $$Props['data'] = {}; - export let selected: $$Props['selected'] = undefined; - export let sourcePosition: $$Props['sourcePosition'] = undefined; - export let targetPosition: $$Props['targetPosition'] = undefined; - export let type: $$Props['type'] = undefined; - export let dragging: $$Props['dragging'] = false; - export let dragHandle: $$Props['dragHandle'] = undefined; - export let positionAbsoluteX: $$Props['positionAbsoluteX'] = 0; - export let positionAbsoluteY: $$Props['positionAbsoluteY'] = 0; - export let isConnectable: $$Props['isConnectable']; - export let zIndex: $$Props['zIndex']; - - // @todo: there must be a better way to do this - id; - width; - height; - data; - selected; - sourcePosition; - targetPosition; - type; - zIndex; - dragging; - dragHandle; - positionAbsoluteX; - positionAbsoluteY; - isConnectable; + // this is a workaround for suppressing the warning about unused props + $$restProps; diff --git a/packages/svelte/src/lib/components/nodes/InputNode.svelte b/packages/svelte/src/lib/components/nodes/InputNode.svelte index 3b8296c5..72b3a2dd 100644 --- a/packages/svelte/src/lib/components/nodes/InputNode.svelte +++ b/packages/svelte/src/lib/components/nodes/InputNode.svelte @@ -9,33 +9,8 @@ export let data: $$Props['data'] = { label: 'Node' }; export let sourcePosition: $$Props['sourcePosition'] = Position.Bottom; - // unused props - we need to list them here in order to prevent warnings - export let id: $$Props['id'] = ''; - export let width: $$Props['width'] = undefined; - export let height: $$Props['height'] = undefined; - export let selected: $$Props['selected'] = undefined; - export let targetPosition: $$Props['targetPosition'] = undefined; - export let type: $$Props['type'] = undefined; - export let dragging: $$Props['dragging'] = false; - export let dragHandle: $$Props['dragHandle'] = undefined; - export let positionAbsoluteX: $$Props['positionAbsoluteX'] = 0; - export let positionAbsoluteY: $$Props['positionAbsoluteY'] = 0; - export let isConnectable: $$Props['isConnectable']; - export let zIndex: $$Props['zIndex']; - - // @todo: there must be a better way to do this - id; - width; - height; - selected; - targetPosition; - type; - zIndex; - dragging; - dragHandle; - positionAbsoluteX; - positionAbsoluteY; - isConnectable; + // this is a workaround for suppressing the warning about unused props + $$restProps; {data?.label} diff --git a/packages/svelte/src/lib/components/nodes/OutputNode.svelte b/packages/svelte/src/lib/components/nodes/OutputNode.svelte index 692aaf76..bf7d2068 100644 --- a/packages/svelte/src/lib/components/nodes/OutputNode.svelte +++ b/packages/svelte/src/lib/components/nodes/OutputNode.svelte @@ -9,33 +9,8 @@ export let data: $$Props['data'] = { label: 'Node' }; export let targetPosition: $$Props['targetPosition'] = Position.Top; - // unused props - we need to list them here in order to prevent warnings - export let id: $$Props['id'] = ''; - export let width: $$Props['width'] = undefined; - export let height: $$Props['height'] = undefined; - export let selected: $$Props['selected'] = undefined; - export let sourcePosition: $$Props['sourcePosition'] = undefined; - export let type: $$Props['type'] = undefined; - export let dragging: $$Props['dragging'] = false; - export let dragHandle: $$Props['dragHandle'] = undefined; - export let positionAbsoluteX: $$Props['positionAbsoluteX'] = 0; - export let positionAbsoluteY: $$Props['positionAbsoluteY'] = 0; - export let isConnectable: $$Props['isConnectable']; - export let zIndex: $$Props['zIndex']; - - // @todo: there must be a better way to do this - id; - width; - height; - selected; - sourcePosition; - type; - zIndex; - dragging; - dragHandle; - positionAbsoluteX; - positionAbsoluteY; - isConnectable; + // this is a workaround for suppressing the warning about unused props + $$restProps; {data?.label}