Merge pull request #1692 from wbkd/feat/interaction-classnames

Feat/interaction classnames
This commit is contained in:
Christopher Möller
2021-11-18 18:05:08 +01:00
committed by GitHub
9 changed files with 73 additions and 18 deletions
+4 -1
View File
@@ -50,6 +50,8 @@ export default (NodeComponent: ComponentType<NodeProps>) => {
dragHandle, dragHandle,
zIndex, zIndex,
isParent, isParent,
noPanClassName,
noDragClassName,
}: WrapNodeProps) => { }: WrapNodeProps) => {
const { const {
addSelectedElements, addSelectedElements,
@@ -217,6 +219,7 @@ export default (NodeComponent: ComponentType<NodeProps>) => {
const nodeClasses = cc([ const nodeClasses = cc([
'react-flow__node', 'react-flow__node',
`react-flow__node-${type}`, `react-flow__node-${type}`,
noPanClassName,
className, className,
{ {
selected, selected,
@@ -232,7 +235,7 @@ export default (NodeComponent: ComponentType<NodeProps>) => {
onStop={onDragStop} onStop={onDragStop}
scale={scale} scale={scale}
disabled={!isDraggable} disabled={!isDraggable}
cancel=".nodrag" cancel={`.${noDragClassName}`}
nodeRef={nodeElement} nodeRef={nodeElement}
grid={grid} grid={grid}
enableUserSelectHack={false} enableUserSelectHack={false}
+4 -1
View File
@@ -5,6 +5,7 @@
import React, { useMemo, useCallback, useRef, MouseEvent } from 'react'; import React, { useMemo, useCallback, useRef, MouseEvent } from 'react';
import ReactDraggable, { DraggableData } from 'react-draggable'; import ReactDraggable, { DraggableData } from 'react-draggable';
import cc from 'classcat';
import { useStore } from '../../store'; import { useStore } from '../../store';
import { Node, ReactFlowState } from '../../types'; import { Node, ReactFlowState } from '../../types';
@@ -14,6 +15,7 @@ export interface NodesSelectionProps {
onSelectionDrag?: (event: MouseEvent, nodes: Node[]) => void; onSelectionDrag?: (event: MouseEvent, nodes: Node[]) => void;
onSelectionDragStop?: (event: MouseEvent, nodes: Node[]) => void; onSelectionDragStop?: (event: MouseEvent, nodes: Node[]) => void;
onSelectionContextMenu?: (event: MouseEvent, nodes: Node[]) => void; onSelectionContextMenu?: (event: MouseEvent, nodes: Node[]) => void;
noPanClassName?: string;
} }
// @TODO: work with nodeInternals instead of converting it to an array // @TODO: work with nodeInternals instead of converting it to an array
const selector = (s: ReactFlowState) => ({ const selector = (s: ReactFlowState) => ({
@@ -33,6 +35,7 @@ export default ({
onSelectionDrag, onSelectionDrag,
onSelectionDragStop, onSelectionDragStop,
onSelectionContextMenu, onSelectionContextMenu,
noPanClassName,
}: NodesSelectionProps) => { }: NodesSelectionProps) => {
const { transform, selectedNodesBbox, selectionActive, selectedNodes, snapToGrid, snapGrid, updateNodePosition } = const { transform, selectedNodesBbox, selectionActive, selectedNodes, snapToGrid, snapGrid, updateNodePosition } =
useStore(selector); useStore(selector);
@@ -105,7 +108,7 @@ export default ({
} }
return ( return (
<div className="react-flow__nodesselection react-flow__container" style={style}> <div className={cc(['react-flow__nodesselection', 'react-flow__container', noPanClassName])} style={style}>
<ReactDraggable <ReactDraggable
scale={tScale} scale={tScale}
grid={grid} grid={grid}
+6 -1
View File
@@ -1,5 +1,6 @@
import React, { memo, CSSProperties, useCallback } from 'react'; import React, { memo, CSSProperties, useCallback } from 'react';
import shallow from 'zustand/shallow'; import shallow from 'zustand/shallow';
import cc from 'classcat';
import { useStore } from '../../store'; import { useStore } from '../../store';
import ConnectionLine from '../../components/ConnectionLine/index'; import ConnectionLine from '../../components/ConnectionLine/index';
@@ -35,6 +36,7 @@ interface EdgeRendererProps {
onEdgeUpdateStart?: (event: React.MouseEvent, edge: Edge) => void; onEdgeUpdateStart?: (event: React.MouseEvent, edge: Edge) => void;
onEdgeUpdateEnd?: (event: MouseEvent, edge: Edge) => void; onEdgeUpdateEnd?: (event: MouseEvent, edge: Edge) => void;
edgeUpdaterRadius?: number; edgeUpdaterRadius?: number;
noPanClassName?: string;
} }
interface EdgeWrapperProps { interface EdgeWrapperProps {
@@ -63,6 +65,7 @@ interface EdgeWrapperProps {
targetNodeX?: number; targetNodeX?: number;
targetNodeY?: number; targetNodeY?: number;
targetNodeHandleBounds?: NodeHandleBounds; targetNodeHandleBounds?: NodeHandleBounds;
noPanClassName?: string;
} }
const Edge = memo( const Edge = memo(
@@ -92,6 +95,7 @@ const Edge = memo(
targetNodeX, targetNodeX,
targetNodeY, targetNodeY,
targetNodeHandleBounds, targetNodeHandleBounds,
noPanClassName,
}: EdgeWrapperProps) => { }: EdgeWrapperProps) => {
const sourceHandleId = edge.sourceHandle || null; const sourceHandleId = edge.sourceHandle || null;
const targetHandleId = edge.targetHandle || null; const targetHandleId = edge.targetHandle || null;
@@ -163,7 +167,7 @@ const Edge = memo(
<EdgeComponent <EdgeComponent
key={edge.id} key={edge.id}
id={edge.id} id={edge.id}
className={edge.className} className={cc([edge.className, noPanClassName])}
type={edgeType} type={edgeType}
data={edge.data} data={edge.data}
onClick={onEdgeClick} onClick={onEdgeClick}
@@ -283,6 +287,7 @@ const EdgeRenderer = (props: EdgeRendererProps) => {
onEdgeUpdate={props.onEdgeUpdate} onEdgeUpdate={props.onEdgeUpdate}
edgeTypes={props.edgeTypes} edgeTypes={props.edgeTypes}
connectionMode={connectionMode} connectionMode={connectionMode}
noPanClassName={props.noPanClassName}
/> />
); );
})} })}
+5
View File
@@ -59,6 +59,8 @@ const FlowRenderer = ({
onSelectionDrag, onSelectionDrag,
onSelectionDragStop, onSelectionDragStop,
onSelectionContextMenu, onSelectionContextMenu,
noWheelClassName,
noPanClassName,
}: FlowRendererProps) => { }: FlowRendererProps) => {
const { unsetNodesSelection, resetSelectedElements, nodesSelectionActive } = useStore(selector, shallow); const { unsetNodesSelection, resetSelectedElements, nodesSelectionActive } = useStore(selector, shallow);
@@ -107,6 +109,8 @@ const FlowRenderer = ({
defaultZoom={defaultZoom} defaultZoom={defaultZoom}
zoomActivationKeyCode={zoomActivationKeyCode} zoomActivationKeyCode={zoomActivationKeyCode}
preventScrolling={preventScrolling} preventScrolling={preventScrolling}
noWheelClassName={noWheelClassName}
noPanClassName={noPanClassName}
> >
{children} {children}
<UserSelection selectionKeyPressed={selectionKeyPressed} /> <UserSelection selectionKeyPressed={selectionKeyPressed} />
@@ -116,6 +120,7 @@ const FlowRenderer = ({
onSelectionDrag={onSelectionDrag} onSelectionDrag={onSelectionDrag}
onSelectionDragStop={onSelectionDragStop} onSelectionDragStop={onSelectionDragStop}
onSelectionContextMenu={onSelectionContextMenu} onSelectionContextMenu={onSelectionContextMenu}
noPanClassName={noPanClassName}
/> />
)} )}
<div <div
+12
View File
@@ -20,6 +20,9 @@ export interface GraphViewProps extends Omit<ReactFlowProps, 'onSelectionChange'
defaultPosition: [number, number]; defaultPosition: [number, number];
defaultMarkerColor: string; defaultMarkerColor: string;
selectNodesOnDrag: boolean; selectNodesOnDrag: boolean;
noDragClassName: string;
noWheelClassName: string;
noPanClassName: string;
} }
const GraphView = ({ const GraphView = ({
@@ -76,6 +79,9 @@ const GraphView = ({
edgeUpdaterRadius, edgeUpdaterRadius,
onEdgeUpdateStart, onEdgeUpdateStart,
onEdgeUpdateEnd, onEdgeUpdateEnd,
noDragClassName,
noWheelClassName,
noPanClassName,
}: GraphViewProps) => { }: GraphViewProps) => {
useOnLoadHandler(onLoad); useOnLoadHandler(onLoad);
@@ -106,6 +112,9 @@ const GraphView = ({
onSelectionDragStop={onSelectionDragStop} onSelectionDragStop={onSelectionDragStop}
onSelectionContextMenu={onSelectionContextMenu} onSelectionContextMenu={onSelectionContextMenu}
preventScrolling={preventScrolling} preventScrolling={preventScrolling}
noDragClassName={noDragClassName}
noWheelClassName={noWheelClassName}
noPanClassName={noPanClassName}
> >
<Viewport> <Viewport>
<EdgeRenderer <EdgeRenderer
@@ -125,6 +134,7 @@ const GraphView = ({
onEdgeUpdateEnd={onEdgeUpdateEnd} onEdgeUpdateEnd={onEdgeUpdateEnd}
edgeUpdaterRadius={edgeUpdaterRadius} edgeUpdaterRadius={edgeUpdaterRadius}
defaultMarkerColor={defaultMarkerColor} defaultMarkerColor={defaultMarkerColor}
noPanClassName={noPanClassName}
/> />
<NodeRenderer <NodeRenderer
nodeTypes={nodeTypes} nodeTypes={nodeTypes}
@@ -139,6 +149,8 @@ const GraphView = ({
onNodeDragStart={onNodeDragStart} onNodeDragStart={onNodeDragStart}
selectNodesOnDrag={selectNodesOnDrag} selectNodesOnDrag={selectNodesOnDrag}
onlyRenderVisibleElements={onlyRenderVisibleElements} onlyRenderVisibleElements={onlyRenderVisibleElements}
noPanClassName={noPanClassName}
noDragClassName={noDragClassName}
/> />
</Viewport> </Viewport>
</FlowRenderer> </FlowRenderer>
+4
View File
@@ -17,6 +17,8 @@ interface NodeRendererProps {
onNodeDrag?: (event: MouseEvent, node: Node) => void; onNodeDrag?: (event: MouseEvent, node: Node) => void;
onNodeDragStop?: (event: MouseEvent, node: Node) => void; onNodeDragStop?: (event: MouseEvent, node: Node) => void;
onlyRenderVisibleElements: boolean; onlyRenderVisibleElements: boolean;
noPanClassName: string;
noDragClassName: string;
} }
const selector = (s: ReactFlowState) => ({ const selector = (s: ReactFlowState) => ({
@@ -113,6 +115,8 @@ const NodeRenderer = (props: NodeRendererProps) => {
dragHandle={node.dragHandle} dragHandle={node.dragHandle}
zIndex={internals?.z || 0} zIndex={internals?.z || 0}
isParent={!!internals?.isParent} isParent={!!internals?.isParent}
noDragClassName={props.noDragClassName}
noPanClassName={props.noPanClassName}
/> />
); );
})} })}
+11 -1
View File
@@ -5,6 +5,7 @@ import React, {
MouseEvent as ReactMouseEvent, MouseEvent as ReactMouseEvent,
WheelEvent, WheelEvent,
forwardRef, forwardRef,
FunctionComponent,
} from 'react'; } from 'react';
import cc from 'classcat'; import cc from 'classcat';
@@ -129,6 +130,9 @@ export interface ReactFlowProps extends Omit<HTMLAttributes<HTMLDivElement>, 'on
onEdgeUpdateStart?: (event: ReactMouseEvent, edge: Edge) => void; onEdgeUpdateStart?: (event: ReactMouseEvent, edge: Edge) => void;
onEdgeUpdateEnd?: (event: MouseEvent, edge: Edge) => void; onEdgeUpdateEnd?: (event: MouseEvent, edge: Edge) => void;
edgeUpdaterRadius?: number; edgeUpdaterRadius?: number;
noDragClassName?: string;
noWheelClassName?: string;
noPanClassName?: string;
} }
export type ReactFlowRefType = HTMLDivElement; export type ReactFlowRefType = HTMLDivElement;
@@ -136,7 +140,7 @@ export type ReactFlowRefType = HTMLDivElement;
const initSnapGrid: [number, number] = [15, 15]; const initSnapGrid: [number, number] = [15, 15];
const initDefaultPosition: [number, number] = [0, 0]; const initDefaultPosition: [number, number] = [0, 0];
const ReactFlow = forwardRef<ReactFlowRefType, ReactFlowProps>( const ReactFlow: FunctionComponent<ReactFlowProps> = forwardRef<ReactFlowRefType, ReactFlowProps>(
( (
{ {
nodes = [], nodes = [],
@@ -212,6 +216,9 @@ const ReactFlow = forwardRef<ReactFlowRefType, ReactFlowProps>(
edgeUpdaterRadius = 10, edgeUpdaterRadius = 10,
onNodesChange, onNodesChange,
onEdgesChange, onEdgesChange,
noDragClassName = 'nodrag',
noWheelClassName = 'nowheel',
noPanClassName = 'nopan',
...rest ...rest
}, },
ref ref
@@ -276,6 +283,9 @@ const ReactFlow = forwardRef<ReactFlowRefType, ReactFlowProps>(
onEdgeUpdateEnd={onEdgeUpdateEnd} onEdgeUpdateEnd={onEdgeUpdateEnd}
edgeUpdaterRadius={edgeUpdaterRadius} edgeUpdaterRadius={edgeUpdaterRadius}
defaultMarkerColor={defaultMarkerColor} defaultMarkerColor={defaultMarkerColor}
noDragClassName={noDragClassName}
noWheelClassName={noWheelClassName}
noPanClassName={noPanClassName}
/> />
<StoreUpdater <StoreUpdater
nodes={nodes} nodes={nodes}
+25 -14
View File
@@ -27,6 +27,8 @@ interface ZoomPaneProps {
zoomActivationKeyCode?: KeyCode; zoomActivationKeyCode?: KeyCode;
preventScrolling?: boolean; preventScrolling?: boolean;
children: ReactNode; children: ReactNode;
noWheelClassName: string;
noPanClassName: string;
} }
const viewChanged = (prevTransform: FlowTransform, eventTransform: any): boolean => const viewChanged = (prevTransform: FlowTransform, eventTransform: any): boolean =>
@@ -40,7 +42,7 @@ const eventToFlowTransform = (eventTransform: any): FlowTransform => ({
zoom: eventTransform.k, zoom: eventTransform.k,
}); });
const hasNoWheelClass = (event: any) => event.target.closest('.nowheel'); const isWrappedWithClass = (event: any, className: string | undefined) => event.target.closest(`.${className}`);
const selector = (s: ReactFlowState) => ({ const selector = (s: ReactFlowState) => ({
d3Zoom: s.d3Zoom, d3Zoom: s.d3Zoom,
@@ -69,6 +71,8 @@ const ZoomPane = ({
zoomActivationKeyCode, zoomActivationKeyCode,
preventScrolling = true, preventScrolling = true,
children, children,
noWheelClassName,
noPanClassName,
}: ZoomPaneProps) => { }: ZoomPaneProps) => {
const store = useStoreApi(); const store = useStoreApi();
const zoomPane = useRef<HTMLDivElement>(null); const zoomPane = useRef<HTMLDivElement>(null);
@@ -106,7 +110,7 @@ const ZoomPane = ({
if (panOnScroll && !zoomActivationKeyPressed) { if (panOnScroll && !zoomActivationKeyPressed) {
d3Selection d3Selection
.on('wheel', (event: any) => { .on('wheel', (event: any) => {
if (hasNoWheelClass(event)) { if (isWrappedWithClass(event, noWheelClassName)) {
return false; return false;
} }
event.preventDefault(); event.preventDefault();
@@ -140,7 +144,7 @@ const ZoomPane = ({
} else if (typeof d3ZoomHandler !== 'undefined') { } else if (typeof d3ZoomHandler !== 'undefined') {
d3Selection d3Selection
.on('wheel', (event: any) => { .on('wheel', (event: any) => {
if (!preventScrolling || hasNoWheelClass(event)) { if (!preventScrolling || isWrappedWithClass(event, noWheelClassName)) {
return null; return null;
} }
@@ -158,6 +162,7 @@ const ZoomPane = ({
zoomActivationKeyPressed, zoomActivationKeyPressed,
zoomOnPinch, zoomOnPinch,
preventScrolling, preventScrolling,
noWheelClassName,
]); ]);
useEffect(() => { useEffect(() => {
@@ -230,22 +235,28 @@ const ZoomPane = ({
return false; return false;
} }
if (hasNoWheelClass(event) && event.type === 'wheel') { // if the target element is inside the nowheel class, we prevent zooming
if (isWrappedWithClass(event, noWheelClassName) && event.type === 'wheel') {
return false;
}
// if the target element is inside the nopan class, we prevent panning
if (isWrappedWithClass(event, noPanClassName) && event.type !== 'wheel') {
return false; return false;
} }
// when the target element is a node, we still allow zooming // when the target element is a node, we still allow zooming
if ( // if (
(event.target.closest('.react-flow__node') || event.target.closest('.react-flow__edge')) && // (event.target.closest('.react-flow__node') || event.target.closest('.react-flow__edge')) &&
event.type !== 'wheel' // event.type !== 'wheel'
) { // ) {
return false; // return false;
} // }
// when the target element is a node selection, we still allow zooming // // when the target element is a node selection, we still allow zooming
if (event.target.closest('.react-flow__nodesselection') && event.type !== 'wheel') { // if (event.target.closest('.react-flow__nodesselection') && event.type !== 'wheel') {
return false; // return false;
} // }
if (!zoomOnPinch && event.ctrlKey && event.type === 'wheel') { if (!zoomOnPinch && event.ctrlKey && event.type === 'wheel') {
return false; return false;
+2
View File
@@ -82,6 +82,8 @@ export interface WrapNodeProps<T = any> {
dragHandle?: string; dragHandle?: string;
zIndex: number; zIndex: number;
isParent: boolean; isParent: boolean;
noPanClassName: string;
noDragClassName: string;
} }
export type NodeHandleBounds = { export type NodeHandleBounds = {