From 8dd2b4f9e2ece77f5ffc075aab68ebd7774f722b Mon Sep 17 00:00:00 2001
From: moklick <info@moritzklack.com>
Date: Tue, 25 Feb 2025 10:57:17 +0100
Subject: [PATCH] chore(updateNodePositions): cleanup

---
 packages/react/src/store/index.ts | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/packages/react/src/store/index.ts b/packages/react/src/store/index.ts
index e3b5279a..19a885a2 100644
--- a/packages/react/src/store/index.ts
+++ b/packages/react/src/store/index.ts
@@ -152,10 +152,11 @@ const createStore = ({
       updateNodePositions: (nodeDragItems, dragging = false) => {
         const parentExpandChildren: ParentExpandChild[] = [];
         const changes = [];
+        const { nodeLookup, triggerNodeChanges } = get();
 
         for (const [id, dragItem] of nodeDragItems) {
           // we are using the nodelookup to be sure to use the current expandParent and parentId value
-          const node = get().nodeLookup.get(id);
+          const node = nodeLookup.get(id);
           const expandParent = !!(node?.expandParent && node?.parentId && dragItem?.position);
 
           const change: NodeChange = {
@@ -170,10 +171,10 @@ const createStore = ({
             dragging,
           };
 
-          if (expandParent) {
+          if (expandParent && node.parentId) {
             parentExpandChildren.push({
               id,
-              parentId: node.parentId!,
+              parentId: node.parentId,
               rect: {
                 ...dragItem.internals.positionAbsolute,
                 width: dragItem.measured.width!,
@@ -186,12 +187,12 @@ const createStore = ({
         }
 
         if (parentExpandChildren.length > 0) {
-          const { nodeLookup, parentLookup, nodeOrigin } = get();
+          const { parentLookup, nodeOrigin } = get();
           const parentExpandChanges = handleExpandParent(parentExpandChildren, nodeLookup, parentLookup, nodeOrigin);
           changes.push(...parentExpandChanges);
         }
 
-        get().triggerNodeChanges(changes);
+        triggerNodeChanges(changes);
       },
       triggerNodeChanges: (changes) => {
         const { onNodesChange, setNodes, nodes, hasDefaultNodes, debug } = get();