alighasami/xyflow
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #4874 from crimx/patch-1

Browse Source 
fix(system): safely handles non-html-element object
This commit is contained in:
Moritz Klack
2024-12-09 17:36:50 +01:00
committed by GitHub
parent 21b7e9542b d60331e6ba
commit 90d4726cd5
2 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.changeset/brown-pugs-pump.md
+5
View File
@@ -0,0 +1,5 @@
---
'@xyflow/system': patch
---
Refactor isInputDOMNode so that it handles non-html objects
packages/system/src/utils/dom.ts
+1 -1
View File
@@ -40,7 +40,7 @@ const inputTags = ['INPUT', 'SELECT', 'TEXTAREA'];
export function isInputDOMNode(event: KeyboardEvent): boolean { export function isInputDOMNode(event: KeyboardEvent): boolean {
// using composed path for handling shadow dom // using composed path for handling shadow dom
const target = (event.composedPath?.()?.[0] || event.target) as HTMLElement; const target = (event.composedPath?.()?.[0] || event.target) as HTMLElement;
const isInput = inputTags.includes(target?.nodeName) || target?.hasAttribute('contenteditable'); const isInput = inputTags.includes(target?.nodeName) || target?.hasAttribute?.('contenteditable');
// when an input field is focused we don't want to trigger deletion or movement of nodes // when an input field is focused we don't want to trigger deletion or movement of nodes
return isInput || !!target?.closest('.nokey'); return isInput || !!target?.closest('.nokey');