From 979fe7d56539414d03b79b77eea1b1c3d9ae3192 Mon Sep 17 00:00:00 2001
From: peterkogo <peter@xyflow.com>
Date: Thu, 11 Apr 2024 18:34:17 +0200
Subject: [PATCH] broken parent expand on resize but almost there

---
 .../NodeResizer/NodeResizeControl.tsx         | 40 ++++++++++++++++---
 packages/system/src/utils/store.ts            | 39 +++++++++---------
 2 files changed, 53 insertions(+), 26 deletions(-)

diff --git a/packages/react/src/additional-components/NodeResizer/NodeResizeControl.tsx b/packages/react/src/additional-components/NodeResizer/NodeResizeControl.tsx
index 4ee8ff4a..725639b2 100644
--- a/packages/react/src/additional-components/NodeResizer/NodeResizeControl.tsx
+++ b/packages/react/src/additional-components/NodeResizer/NodeResizeControl.tsx
@@ -9,11 +9,15 @@ import {
   type NodeChange,
   type NodeDimensionChange,
   type NodePositionChange,
+  handleParentExpand,
 } from '@xyflow/system';
 
 import { useStoreApi } from '../../hooks/useStore';
 import { useNodeId } from '../../contexts/NodeIdContext';
 import type { ResizeControlProps, ResizeControlLineProps } from './types';
+import { InternalNode } from '../../types';
+
+type InternalNodeWithParentExpand = InternalNode & { expandParent: true; parentId: string };
 
 function ResizeControl({
   nodeId,
@@ -62,20 +66,44 @@ function ResizeControl({
           };
         },
         onChange: (change: XYResizerChange, childChanges: XYResizerChildChange[]) => {
-          const { triggerNodeChanges } = store.getState();
+          const { triggerNodeChanges, nodeLookup } = store.getState();
 
           const changes: NodeChange[] = [];
+          const newPosition = { x: change.x, y: change.y };
 
-          if (change.x !== undefined && change.y !== undefined) {
-            const positionChange: NodePositionChange = {
-              id,
-              type: 'position',
+          const node = nodeLookup.get(id);
+          if (node && node.expandParent && node.parentId) {
+            const nodeWithChange = {
+              ...node,
               position: {
                 x: change.x,
                 y: change.y,
               },
-            };
+              width: change.width,
+              height: change.height,
+              measured: {
+                width: change.width ?? node.measured?.width,
+                height: change.height ?? node.measured?.height,
+              },
+            } as InternalNodeWithParentExpand;
 
+            const parentExpandChanges = handleParentExpand([nodeWithChange], nodeLookup);
+            if (parentExpandChanges.length > 0) {
+              newPosition.x = change.x && change.x < 0 ? 0 : change.x;
+              newPosition.y = change.y && change.y < 0 ? 0 : change.y;
+            } else {
+              console.log('there was no parent expand');
+            }
+            changes.push(...parentExpandChanges);
+          }
+
+          if (change.x !== undefined && change.y !== undefined) {
+            console.log(newPosition);
+            const positionChange: NodePositionChange = {
+              id,
+              type: 'position',
+              position: { ...newPosition } as { x: number; y: number },
+            };
             changes.push(positionChange);
           }
 
diff --git a/packages/system/src/utils/store.ts b/packages/system/src/utils/store.ts
index 0d7f2645..11b5e3c6 100644
--- a/packages/system/src/utils/store.ts
+++ b/packages/system/src/utils/store.ts
@@ -145,25 +145,25 @@ function calculateXYZPosition<NodeType extends NodeBase>(
   );
 }
 
+type NodeWithExpandParent<NodeType> = NodeType & { parentId: string; expandParent: true };
+
 export function handleParentExpand(
-  nodes: InternalNodeBase[],
+  nodes: NodeWithExpandParent<InternalNodeBase>[],
   nodeLookup: NodeLookup
 ): (NodeDimensionChange | NodePositionChange)[] {
   const changes: (NodeDimensionChange | NodePositionChange)[] = [];
   const chilNodeRects = new Map<string, Rect>();
 
-  nodes.forEach((node) => {
-    const parentId = node.parentId;
-    if (node.expandParent && parentId) {
-      const parentNode = nodeLookup.get(parentId);
-
-      if (parentNode) {
-        const parentRect = chilNodeRects.get(parentId) || nodeToRect(parentNode, node.origin);
-        const expandedRect = getBoundsOfRects(parentRect, nodeToRect(node, node.origin));
-        chilNodeRects.set(parentId, expandedRect);
-      }
+  for (const node of nodes) {
+    const parentNode = nodeLookup.get(node.parentId);
+    if (!parentNode) {
+      continue;
     }
-  });
+
+    const parentRect = chilNodeRects.get(node.parentId) || nodeToRect(parentNode, node.origin);
+    const expandedRect = getBoundsOfRects(parentRect, nodeToRect(node, node.origin));
+    chilNodeRects.set(node.parentId, expandedRect);
+  }
 
   if (chilNodeRects.size > 0) {
     chilNodeRects.forEach((rect, id) => {
@@ -193,9 +193,8 @@ export function handleParentExpand(
             height: dimensions.height + yChange,
           },
         });
-
-        // @todo we need to reset child node positions if < 0
-      } else if (dimensions.width < rect.width || dimensions.height < rect.height) {
+      }
+      if (dimensions.width < rect.width || dimensions.height < rect.height) {
         changes.push({
           id,
           type: 'dimensions',
@@ -229,7 +228,7 @@ export function updateNodeInternals<NodeType extends InternalNodeBase>(
   const style = window.getComputedStyle(viewportNode);
   const { m22: zoom } = new window.DOMMatrixReadOnly(style.transform);
   // in this array we collect nodes, that might trigger changes (like expanding parent)
-  const triggerChangeNodes: NodeType[] = [];
+  const parentExpandNodes: NodeWithExpandParent<NodeType>[] = [];
 
   updates.forEach((update) => {
     const node = nodeLookup.get(update.id);
@@ -275,16 +274,16 @@ export function updateNodeInternals<NodeType extends InternalNodeBase>(
             dimensions,
           });
 
-          if (newNode.expandParent) {
-            triggerChangeNodes.push(newNode);
+          if (newNode.expandParent && newNode.parentId) {
+            parentExpandNodes.push(newNode as NodeWithExpandParent<NodeType>);
           }
         }
       }
     }
   });
 
-  if (triggerChangeNodes.length > 0) {
-    const parentExpandChanges = handleParentExpand(triggerChangeNodes, nodeLookup);
+  if (parentExpandNodes.length > 0) {
+    const parentExpandChanges = handleParentExpand(parentExpandNodes, nodeLookup);
     changes.push(...parentExpandChanges);
   }