From 5954fa6cc4cdc0038d5c34010845bcb9288c3d55 Mon Sep 17 00:00:00 2001 From: peterkogo Date: Mon, 14 Oct 2024 11:44:44 +0200 Subject: [PATCH 1/2] remove non-null assertion while dragging --- packages/system/src/xydrag/utils.ts | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/packages/system/src/xydrag/utils.ts b/packages/system/src/xydrag/utils.ts index a668746a..0fc048e8 100644 --- a/packages/system/src/xydrag/utils.ts +++ b/packages/system/src/xydrag/utils.ts @@ -106,14 +106,16 @@ export function getEventHandlerParams({ return [nodesFromDragItems[0], nodesFromDragItems]; } - const node = nodeLookup.get(nodeId)!.internals.userNode; + const node = nodeLookup.get(nodeId)?.internals.userNode; return [ - { - ...node, - position: dragItems.get(nodeId)?.position || node.position, - dragging, - }, + !node + ? nodesFromDragItems[0] + : { + ...node, + position: dragItems.get(nodeId)?.position || node.position, + dragging, + }, nodesFromDragItems, ]; } From 2c590b90787aabce42de2b4108174bdf31ad6155 Mon Sep 17 00:00:00 2001 From: peterkogo Date: Mon, 14 Oct 2024 11:46:53 +0200 Subject: [PATCH 2/2] add changeset --- .changeset/new-rocks-mate.md | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 .changeset/new-rocks-mate.md diff --git a/.changeset/new-rocks-mate.md b/.changeset/new-rocks-mate.md new file mode 100644 index 00000000..e9285267 --- /dev/null +++ b/.changeset/new-rocks-mate.md @@ -0,0 +1,7 @@ +--- +'@xyflow/system': patch +'@xyflow/react': patch +'@xyflow/svelte': patch +--- + +Fixed rare crash while dragging