alighasami/xyflow
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #4100 from xyflow/svelte-unobserve-fix

Browse Source 
fix(svelte): resizeObserver.unobserve
This commit is contained in:
Moritz Klack
2024-04-03 16:55:35 +02:00
committed by GitHub
parent 3c2906fa2c 6be48fb6b4
commit 989bbf2ec6
1 changed files with 8 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/svelte/src/lib/components/NodeWrapper/NodeWrapper.svelte
+8 -11
View File
@@ -57,7 +57,7 @@
const nodeType = type || 'default'; const nodeType = type || 'default';
let nodeRef: HTMLDivElement; let nodeRef: HTMLDivElement;
let prevNodeRef: HTMLDivElement; let prevNodeRef: HTMLDivElement | null = null;
const nodeTypeValid = !!$nodeTypes[nodeType]; const nodeTypeValid = !!$nodeTypes[nodeType];
@@ -119,20 +119,17 @@
setContext('svelteflow__node_connectable', connectableStore); setContext('svelteflow__node_connectable', connectableStore);
$: { $: {
if (nodeRef) { if (resizeObserver && nodeRef !== prevNodeRef) {
if (!prevNodeRef) { prevNodeRef && resizeObserver.unobserve(prevNodeRef);
resizeObserver?.observe(nodeRef); nodeRef && resizeObserver.observe(nodeRef);
prevNodeRef = nodeRef; prevNodeRef = nodeRef;
} else if (prevNodeRef !== nodeRef || (!computedWidth && !computedHeight)) {
resizeObserver?.unobserve(prevNodeRef);
resizeObserver?.observe(nodeRef);
prevNodeRef = nodeRef;
}
} }
} }
onDestroy(() => { onDestroy(() => {
resizeObserver?.unobserve(nodeRef); if (prevNodeRef) {
resizeObserver?.unobserve(prevNodeRef);
}
}); });
function onSelectNodeHandler(event: MouseEvent | TouchEvent) { function onSelectNodeHandler(event: MouseEvent | TouchEvent) {