From 9bc76d19bb41cde4556e14a8a34538983fb73f30 Mon Sep 17 00:00:00 2001
From: moklick <info@moritzklack.com>
Date: Mon, 13 Feb 2023 13:03:11 +0100
Subject: [PATCH] fix(connections): fix connections with handles bigger than
 connec radius closes #2814

---
 .../core/src/components/Handle/handler.ts     | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/packages/core/src/components/Handle/handler.ts b/packages/core/src/components/Handle/handler.ts
index caed0dd3..46cc64e9 100644
--- a/packages/core/src/components/Handle/handler.ts
+++ b/packages/core/src/components/Handle/handler.ts
@@ -67,6 +67,7 @@ export function handlePointerDown({
   let autoPanStarted = false;
   let connection: Connection | null = null;
   let isValid = false;
+  let handleDomNode: Element | null = null;
 
   const handleLookup = getHandleLookup({
     nodes: getNodes(),
@@ -111,7 +112,7 @@ export function handlePointerDown({
       autoPanStarted = true;
     }
 
-    const { handleDomNode, ...result } = isValidHandle(
+    const result = isValidHandle(
       event,
       prevClosestHandle,
       connectionMode,
@@ -122,9 +123,13 @@ export function handlePointerDown({
       doc
     );
 
+    handleDomNode = result.handleDomNode;
+    connection = result.connection;
+    isValid = result.isValid;
+
     setState({
       connectionPosition:
-        prevClosestHandle && result.isValid
+        prevClosestHandle && isValid
           ? rendererPointToPoint(
               {
                 x: prevClosestHandle.x,
@@ -133,16 +138,13 @@ export function handlePointerDown({
               transform
             )
           : connectionPosition,
-      connectionStatus: getConnectionStatus(!!prevClosestHandle, result.isValid),
+      connectionStatus: getConnectionStatus(!!prevClosestHandle, isValid),
     });
 
-    if (!prevClosestHandle && !result.isValid) {
+    if (!prevClosestHandle && !isValid && !handleDomNode) {
       return resetRecentHandle(prevActiveHandle);
     }
 
-    connection = result.connection;
-    isValid = result.isValid;
-
     if (connection.source !== connection.target && handleDomNode) {
       resetRecentHandle(prevActiveHandle);
       prevActiveHandle = handleDomNode;
@@ -154,7 +156,7 @@ export function handlePointerDown({
   }
 
   function onPointerUp(event: MouseEvent | TouchEvent) {
-    if (prevClosestHandle && connection && isValid) {
+    if ((prevClosestHandle || handleDomNode) && connection && isValid) {
       onConnect?.(connection);
     }
 
@@ -172,6 +174,7 @@ export function handlePointerDown({
     autoPanStarted = false;
     isValid = false;
     connection = null;
+    handleDomNode = null;
 
     doc.removeEventListener('mousemove', onPointerMove as EventListener);
     doc.removeEventListener('mouseup', onPointerUp as EventListener);