From 9f538c6b7ceb8c1b5cca9c413f24ea19de86aad8 Mon Sep 17 00:00:00 2001
From: Peter <p.korcsak@googlemail.com>
Date: Tue, 28 Nov 2023 12:33:54 +0100
Subject: [PATCH] fix(svelte) split edges into internal/external. external
 edges dont require id, source, target anymore

---
 .../components/EdgeWrapper/EdgeWrapper.svelte |  2 +-
 .../lib/components/edges/BezierEdge.svelte    |  2 +-
 .../edges/InternalBezierEdge.svelte           | 29 ++++++++++++++++++
 .../edges/InternalSmoothStepEdge.svelte       | 29 ++++++++++++++++++
 .../components/edges/InternalStepEdge.svelte  | 30 +++++++++++++++++++
 .../edges/InternalStraightEdge.svelte         | 27 +++++++++++++++++
 .../components/edges/SmoothStepEdge.svelte    |  2 +-
 .../src/lib/components/edges/StepEdge.svelte  |  2 +-
 .../lib/components/edges/StraightEdge.svelte  |  2 +-
 .../svelte/src/lib/store/initial-store.ts     |  8 ++---
 10 files changed, 124 insertions(+), 9 deletions(-)
 create mode 100644 packages/svelte/src/lib/components/edges/InternalBezierEdge.svelte
 create mode 100644 packages/svelte/src/lib/components/edges/InternalSmoothStepEdge.svelte
 create mode 100644 packages/svelte/src/lib/components/edges/InternalStepEdge.svelte
 create mode 100644 packages/svelte/src/lib/components/edges/InternalStraightEdge.svelte

diff --git a/packages/svelte/src/lib/components/EdgeWrapper/EdgeWrapper.svelte b/packages/svelte/src/lib/components/EdgeWrapper/EdgeWrapper.svelte
index 7a8df68c..7f5b9bbd 100644
--- a/packages/svelte/src/lib/components/EdgeWrapper/EdgeWrapper.svelte
+++ b/packages/svelte/src/lib/components/EdgeWrapper/EdgeWrapper.svelte
@@ -6,7 +6,7 @@
   import { errorMessages, getMarkerId } from '@xyflow/system';
 
   import { useStore } from '$lib/store';
-  import BezierEdge from '$lib/components/edges/BezierEdge.svelte';
+  import BezierEdge from '$lib/components/edges/InternalBezierEdge.svelte';
   import type { EdgeLayouted, Edge } from '$lib/types';
   import { get } from 'svelte/store';
 
diff --git a/packages/svelte/src/lib/components/edges/BezierEdge.svelte b/packages/svelte/src/lib/components/edges/BezierEdge.svelte
index 60921eb6..56ccaf31 100644
--- a/packages/svelte/src/lib/components/edges/BezierEdge.svelte
+++ b/packages/svelte/src/lib/components/edges/BezierEdge.svelte
@@ -4,7 +4,7 @@
   import type { EdgeProps } from '$lib/types';
   import { BaseEdge } from '$lib/components/BaseEdge';
 
-  type $$Props = EdgeProps;
+  type $$Props = Partial<EdgeProps>;
 
   $: [path, labelX, labelY] = getBezierPath({
     sourceX: $$props.sourceX,
diff --git a/packages/svelte/src/lib/components/edges/InternalBezierEdge.svelte b/packages/svelte/src/lib/components/edges/InternalBezierEdge.svelte
new file mode 100644
index 00000000..a1ca0658
--- /dev/null
+++ b/packages/svelte/src/lib/components/edges/InternalBezierEdge.svelte
@@ -0,0 +1,29 @@
+<script lang="ts">
+  import { getBezierPath } from '@xyflow/system';
+
+  import type { EdgeProps } from '$lib/types';
+  import { BaseEdge } from '$lib/components/BaseEdge';
+
+  type $$Props = EdgeProps;
+
+  $: [path, labelX, labelY] = getBezierPath({
+    sourceX: $$props.sourceX,
+    sourceY: $$props.sourceY,
+    targetX: $$props.targetX,
+    targetY: $$props.targetY,
+    sourcePosition: $$props.sourcePosition,
+    targetPosition: $$props.targetPosition
+  });
+</script>
+
+<BaseEdge
+  {path}
+  {labelX}
+  {labelY}
+  label={$$props.label}
+  labelStyle={$$props.labelStyle}
+  markerStart={$$props.markerStart}
+  markerEnd={$$props.markerEnd}
+  interactionWidth={$$props.interactionWidth}
+  style={$$props.style}
+/>
diff --git a/packages/svelte/src/lib/components/edges/InternalSmoothStepEdge.svelte b/packages/svelte/src/lib/components/edges/InternalSmoothStepEdge.svelte
new file mode 100644
index 00000000..73324a89
--- /dev/null
+++ b/packages/svelte/src/lib/components/edges/InternalSmoothStepEdge.svelte
@@ -0,0 +1,29 @@
+<script lang="ts">
+  import { getSmoothStepPath } from '@xyflow/system';
+
+  import type { EdgeProps } from '$lib/types';
+  import { BaseEdge } from '$lib/components/BaseEdge';
+
+  type $$Props = EdgeProps;
+
+  $: [path, labelX, labelY] = getSmoothStepPath({
+    sourceX: $$props.sourceX,
+    sourceY: $$props.sourceY,
+    targetX: $$props.targetX,
+    targetY: $$props.targetY,
+    sourcePosition: $$props.sourcePosition,
+    targetPosition: $$props.targetPosition
+  });
+</script>
+
+<BaseEdge
+  {path}
+  {labelX}
+  {labelY}
+  label={$$props.label}
+  labelStyle={$$props.labelStyle}
+  markerStart={$$props.markerStart}
+  markerEnd={$$props.markerEnd}
+  interactionWidth={$$props.interactionWidth}
+  style={$$props.style}
+/>
diff --git a/packages/svelte/src/lib/components/edges/InternalStepEdge.svelte b/packages/svelte/src/lib/components/edges/InternalStepEdge.svelte
new file mode 100644
index 00000000..f793376b
--- /dev/null
+++ b/packages/svelte/src/lib/components/edges/InternalStepEdge.svelte
@@ -0,0 +1,30 @@
+<script lang="ts">
+  import { getSmoothStepPath } from '@xyflow/system';
+
+  import type { EdgeProps } from '$lib/types';
+  import { BaseEdge } from '$lib/components/BaseEdge';
+
+  type $$Props = EdgeProps;
+
+  $: [path, labelX, labelY] = getSmoothStepPath({
+    sourceX: $$props.sourceX,
+    sourceY: $$props.sourceY,
+    targetX: $$props.targetX,
+    targetY: $$props.targetY,
+    sourcePosition: $$props.sourcePosition,
+    targetPosition: $$props.targetPosition,
+    borderRadius: 0
+  });
+</script>
+
+<BaseEdge
+  {path}
+  {labelX}
+  {labelY}
+  label={$$props.label}
+  labelStyle={$$props.labelStyle}
+  markerStart={$$props.markerStart}
+  markerEnd={$$props.markerEnd}
+  interactionWidth={$$props.interactionWidth}
+  style={$$props.style}
+/>
diff --git a/packages/svelte/src/lib/components/edges/InternalStraightEdge.svelte b/packages/svelte/src/lib/components/edges/InternalStraightEdge.svelte
new file mode 100644
index 00000000..8cc984d7
--- /dev/null
+++ b/packages/svelte/src/lib/components/edges/InternalStraightEdge.svelte
@@ -0,0 +1,27 @@
+<script lang="ts">
+  import { getStraightPath } from '@xyflow/system';
+
+  import type { EdgeProps } from '$lib/types';
+  import { BaseEdge } from '$lib/components/BaseEdge';
+
+  type $$Props = EdgeProps;
+
+  $: [path, labelX, labelY] = getStraightPath({
+    sourceX: $$props.sourceX,
+    sourceY: $$props.sourceY,
+    targetX: $$props.targetX,
+    targetY: $$props.targetY
+  });
+</script>
+
+<BaseEdge
+  {path}
+  {labelX}
+  {labelY}
+  label={$$props.label}
+  labelStyle={$$props.labelStyle}
+  markerStart={$$props.markerStart}
+  markerEnd={$$props.markerEnd}
+  interactionWidth={$$props.interactionWidth}
+  style={$$props.style}
+/>
diff --git a/packages/svelte/src/lib/components/edges/SmoothStepEdge.svelte b/packages/svelte/src/lib/components/edges/SmoothStepEdge.svelte
index 30872b68..39acb6e6 100644
--- a/packages/svelte/src/lib/components/edges/SmoothStepEdge.svelte
+++ b/packages/svelte/src/lib/components/edges/SmoothStepEdge.svelte
@@ -4,7 +4,7 @@
   import type { EdgeProps } from '$lib/types';
   import { BaseEdge } from '$lib/components/BaseEdge';
 
-  type $$Props = EdgeProps;
+  type $$Props = Partial<EdgeProps>;
 
   $: [path, labelX, labelY] = getSmoothStepPath({
     sourceX: $$props.sourceX,
diff --git a/packages/svelte/src/lib/components/edges/StepEdge.svelte b/packages/svelte/src/lib/components/edges/StepEdge.svelte
index 65012595..ac6118ca 100644
--- a/packages/svelte/src/lib/components/edges/StepEdge.svelte
+++ b/packages/svelte/src/lib/components/edges/StepEdge.svelte
@@ -4,7 +4,7 @@
   import type { EdgeProps } from '$lib/types';
   import { BaseEdge } from '$lib/components/BaseEdge';
 
-  type $$Props = EdgeProps;
+  type $$Props = Partial<EdgeProps>;
 
   $: [path, labelX, labelY] = getSmoothStepPath({
     sourceX: $$props.sourceX,
diff --git a/packages/svelte/src/lib/components/edges/StraightEdge.svelte b/packages/svelte/src/lib/components/edges/StraightEdge.svelte
index 50f282ff..9e6c88da 100644
--- a/packages/svelte/src/lib/components/edges/StraightEdge.svelte
+++ b/packages/svelte/src/lib/components/edges/StraightEdge.svelte
@@ -4,7 +4,7 @@
   import type { EdgeProps } from '$lib/types';
   import { BaseEdge } from '$lib/components/BaseEdge';
 
-  type $$Props = EdgeProps;
+  type $$Props = Partial<EdgeProps>;
 
   $: [path, labelX, labelY] = getStraightPath({
     sourceX: $$props.sourceX,
diff --git a/packages/svelte/src/lib/store/initial-store.ts b/packages/svelte/src/lib/store/initial-store.ts
index dbbb17fc..bf0166ab 100644
--- a/packages/svelte/src/lib/store/initial-store.ts
+++ b/packages/svelte/src/lib/store/initial-store.ts
@@ -24,10 +24,10 @@ import DefaultNode from '$lib/components/nodes/DefaultNode.svelte';
 import InputNode from '$lib/components/nodes/InputNode.svelte';
 import OutputNode from '$lib/components/nodes/OutputNode.svelte';
 import GroupNode from '$lib/components/nodes/GroupNode.svelte';
-import BezierEdge from '$lib/components/edges/BezierEdge.svelte';
-import StraightEdge from '$lib/components/edges/StraightEdge.svelte';
-import SmoothStepEdge from '$lib/components/edges/SmoothStepEdge.svelte';
-import StepEdge from '$lib/components/edges/StepEdge.svelte';
+import BezierEdge from '$lib/components/edges/InternalBezierEdge.svelte';
+import StraightEdge from '$lib/components/edges/InternalStraightEdge.svelte';
+import SmoothStepEdge from '$lib/components/edges/InternalSmoothStepEdge.svelte';
+import StepEdge from '$lib/components/edges/InternalStepEdge.svelte';
 import type {
   NodeTypes,
   EdgeTypes,