Merge pull request #5482 from xyflow/fix-is-intersecting

Fix is intersecting

.changeset/gentle-chefs-travel.md

@@ -0,0 +1,6 @@
+---
+'@xyflow/react': patch
+'@xyflow/svelte': patch
+---
+
+Make isNodeIntersecting behave the same as getIntersectingNodes

packages/react/src/hooks/useReactFlow.ts

@@ -202,6 +202,11 @@ export function useReactFlow<NodeType extends Node = Node, EdgeType extends Edge
 
         return { deletedNodes: matchingNodes, deletedEdges: matchingEdges };
       },
+      /**
+       * Partial is defined as "the 2 nodes/areas are intersecting partially".
+       * If a is contained in b or b is contained in a, they are both
+       * considered fully intersecting.
+       */
       getIntersectingNodes: (nodeOrRect, partially = true, nodes) => {
         const isRect = isRectObject(nodeOrRect);
         const nodeRect = isRect ? nodeOrRect : getNodeRect(nodeOrRect);
@@ -240,7 +245,11 @@ export function useReactFlow<NodeType extends Node = Node, EdgeType extends Edge
         const overlappingArea = getOverlappingArea(nodeRect, area);
         const partiallyVisible = partially && overlappingArea > 0;
 
-        return partiallyVisible || overlappingArea >= nodeRect.width * nodeRect.height;
+        return (
+          partiallyVisible ||
+          overlappingArea >= area.width * area.height ||
+          overlappingArea >= nodeRect.width * nodeRect.height
+        );
       },
       updateNode,
       updateNodeData: (id, dataUpdate, options = { replace: false }) => {

packages/svelte/src/lib/hooks/useSvelteFlow.svelte.ts

@@ -390,6 +390,11 @@ export function useSvelteFlow<NodeType extends Node = Node, EdgeType extends Edg
 
       return Promise.resolve(true);
     },
+    /**
+     * Partial is defined as "the 2 nodes/areas are intersecting partially".
+     * If a is contained in b or b is contained in a, they are both
+     * considered fully intersecting.
+     */
     getIntersectingNodes: (
       nodeOrRect: NodeType | { id: NodeType['id'] } | Rect,
       partially = true,
@@ -434,7 +439,11 @@ export function useSvelteFlow<NodeType extends Node = Node, EdgeType extends Edg
       const overlappingArea = getOverlappingArea(nodeRect, area);
       const partiallyVisible = partially && overlappingArea > 0;
 
-      return partiallyVisible || overlappingArea >= nodeRect.width * nodeRect.height;
+      return (
+        partiallyVisible ||
+        overlappingArea >= area.width * area.height ||
+        overlappingArea >= nodeRect.width * nodeRect.height
+      );
     },
     deleteElements: async ({ nodes: nodesToRemove = [], edges: edgesToRemove = [] }) => {
       const { nodes: matchingNodes, edges: matchingEdges } = await getElementsToRemove<