From 03b8e1ef195fd98cfefd337f1e4a6a37b92a3f5a Mon Sep 17 00:00:00 2001 From: ysds Date: Sat, 24 Jan 2026 02:29:02 +0900 Subject: [PATCH 1/4] fix: ensure drag handlers update when nodes selection changes programmatically Fixes #4841 When nodes were programmatically selected (e.g., adding a new node with `selected: true`), the nodes selection rectangle would appear but dragging it would not work. Changes: - Consolidated duplicate effect hooks in useDrag into a single useIsomorphicLayoutEffect - Added `disabled` parameter to useDrag to allow external control - NodesSelection now passes `disabled: !shouldRender` to useDrag - Improved condition clarity with `shouldRender` variable This ensures drag handlers are properly set up when nodeRef.current becomes available, even when the selection state changes after the initial render. --- .../src/components/NodesSelection/index.tsx | 5 ++- packages/react/src/hooks/useDrag.ts | 35 +++++++++++-------- 2 files changed, 25 insertions(+), 15 deletions(-) diff --git a/packages/react/src/components/NodesSelection/index.tsx b/packages/react/src/components/NodesSelection/index.tsx index ecaef17b..de118a44 100644 --- a/packages/react/src/components/NodesSelection/index.tsx +++ b/packages/react/src/components/NodesSelection/index.tsx @@ -51,11 +51,14 @@ export function NodesSelection({ } }, [disableKeyboardA11y]); + const shouldRender = !userSelectionActive && width !== null && height !== null; + useDrag({ nodeRef, + disabled: !shouldRender, }); - if (userSelectionActive || !width || !height) { + if (!shouldRender) { return null; } diff --git a/packages/react/src/hooks/useDrag.ts b/packages/react/src/hooks/useDrag.ts index f7943f98..f33c1276 100644 --- a/packages/react/src/hooks/useDrag.ts +++ b/packages/react/src/hooks/useDrag.ts @@ -3,6 +3,7 @@ import { XYDrag, type XYDragInstance } from '@xyflow/system'; import { handleNodeClick } from '../components/Nodes/utils'; import { useStoreApi } from './useStore'; +import { useIsomorphicLayoutEffect } from './useIsomorphicLayoutEffect'; type UseDragParams = { nodeRef: RefObject; @@ -51,23 +52,29 @@ export function useDrag({ }); }, []); - useEffect(() => { + useIsomorphicLayoutEffect(() => { if (disabled) { xyDrag.current?.destroy(); - } else if (nodeRef.current) { - xyDrag.current?.update({ - noDragClassName, - handleSelector, - domNode: nodeRef.current, - isSelectable, - nodeId, - nodeClickDistance, - }); - return () => { - xyDrag.current?.destroy(); - }; + return; } - }, [noDragClassName, handleSelector, disabled, isSelectable, nodeRef, nodeId]); + + if (!nodeRef.current || !xyDrag.current) { + return; + } + + xyDrag.current.update({ + noDragClassName, + handleSelector, + domNode: nodeRef.current, + isSelectable, + nodeId, + nodeClickDistance, + }); + + return () => { + xyDrag.current?.destroy(); + }; + }, [noDragClassName, handleSelector, disabled, isSelectable, nodeRef, nodeId, nodeClickDistance]); return dragging; } From 382c654c315accca2005e39d477eed6649f12e40 Mon Sep 17 00:00:00 2001 From: ysds Date: Sat, 24 Jan 2026 03:01:29 +0900 Subject: [PATCH 2/4] chore(changeset): add changeset for drag handler fix --- .changeset/tender-ways-attend.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/tender-ways-attend.md diff --git a/.changeset/tender-ways-attend.md b/.changeset/tender-ways-attend.md new file mode 100644 index 00000000..59737884 --- /dev/null +++ b/.changeset/tender-ways-attend.md @@ -0,0 +1,5 @@ +--- +'@xyflow/react': patch +--- + +Consolidate drag handler effects in useDrag to fix programmatic selection issues From ee53f8baf7090a8e000eb28e97a6fd7bcceb7087 Mon Sep 17 00:00:00 2001 From: peterkogo Date: Fri, 6 Feb 2026 19:41:24 +0100 Subject: [PATCH 3/4] add reproduction of the bug --- examples/react/src/App/routes.ts | 6 +++ .../src/examples/NodeSelectionBug/index.tsx | 41 +++++++++++++++++++ 2 files changed, 47 insertions(+) create mode 100644 examples/react/src/examples/NodeSelectionBug/index.tsx diff --git a/examples/react/src/App/routes.ts b/examples/react/src/App/routes.ts index 055dc9e1..d5bbfe01 100644 --- a/examples/react/src/App/routes.ts +++ b/examples/react/src/App/routes.ts @@ -62,6 +62,7 @@ import MovingHandles from '../examples/MovingHandles'; import DetachedHandle from '../examples/DetachedHandle'; import ZIndexMode from '../examples/ZIndexMode'; import Middlewares from '../examples/Middlewares'; +import NodeSelectionBug from '../examples/NodeSelectionBug'; export interface IRoute { name: string; @@ -390,6 +391,11 @@ const routes: IRoute[] = [ path: 'z-index-mode', component: ZIndexMode, }, + { + name: 'Node Selection Bug', + path: 'node-selection-bug', + component: NodeSelectionBug, + }, ]; export default routes; diff --git a/examples/react/src/examples/NodeSelectionBug/index.tsx b/examples/react/src/examples/NodeSelectionBug/index.tsx new file mode 100644 index 00000000..a587cab3 --- /dev/null +++ b/examples/react/src/examples/NodeSelectionBug/index.tsx @@ -0,0 +1,41 @@ +import { Node, ReactFlow, useNodesState } from '@xyflow/react'; + +import '@xyflow/react/dist/style.css'; +import { useRef } from 'react'; + +export default function App() { + const [nodes, setNodes, onNodesChange] = useNodesState([ + { + id: '0', + position: { x: 0, y: 0 }, + data: { label: 'Rectangle Select Me First' }, + }, + ]); + const id = useRef(0); + return ( + <> + + + + ); +} From cb41f444eb51354c477681447c363084d507e953 Mon Sep 17 00:00:00 2001 From: peterkogo Date: Mon, 9 Feb 2026 07:57:41 +0100 Subject: [PATCH 4/4] simplify code & useEffect instead of uselayoutEffect --- packages/react/src/hooks/useDrag.ts | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/packages/react/src/hooks/useDrag.ts b/packages/react/src/hooks/useDrag.ts index f33c1276..6b4c7642 100644 --- a/packages/react/src/hooks/useDrag.ts +++ b/packages/react/src/hooks/useDrag.ts @@ -3,7 +3,6 @@ import { XYDrag, type XYDragInstance } from '@xyflow/system'; import { handleNodeClick } from '../components/Nodes/utils'; import { useStoreApi } from './useStore'; -import { useIsomorphicLayoutEffect } from './useIsomorphicLayoutEffect'; type UseDragParams = { nodeRef: RefObject; @@ -52,13 +51,8 @@ export function useDrag({ }); }, []); - useIsomorphicLayoutEffect(() => { - if (disabled) { - xyDrag.current?.destroy(); - return; - } - - if (!nodeRef.current || !xyDrag.current) { + useEffect(() => { + if (disabled || !nodeRef.current || !xyDrag.current) { return; }