Merge pull request #5547 from xyflow/fix/moveend

fix(panzoom): always call onMoveEnd when onMoveStart was called #5429

.changeset/ripe-paths-dream.md

@@ -0,0 +1,5 @@
+---
+'@xyflow/system': patch
+---
+
+Always call onMoveEnd when onMoveStart was called

packages/system/src/xypanzoom/eventhandler.ts

@@ -12,7 +12,7 @@ import {
   type OnDraggingChange,
   type OnTransformChange,
 } from '../types';
-import { isRightClickPan, isWrappedWithClass, transformToViewport, viewChanged, wheelDelta } from './utils';
+import { isRightClickPan, isWrappedWithClass, transformToViewport, wheelDelta } from './utils';
 import { isMacOs } from '../utils';
 import { ZoomPanValues } from './XYPanZoom';
 
@@ -128,9 +128,7 @@ export function createPanOnScrollHandler({
       zoomPanValues.isPanScrolling = true;
 
       onPanZoomStart?.(event, nextViewport);
-    }
+    } else {
-
-    if (zoomPanValues.isPanScrolling) {
       onPanZoom?.(event, nextViewport);
 
       zoomPanValues.panScrollTimeout = setTimeout(() => {
@@ -236,7 +234,7 @@ export function createPanZoomEndHandler({
 
     onDraggingChange(false);
 
-    if (onPanZoomEnd && viewChanged(zoomPanValues.prevViewport, event.transform)) {
+    if (onPanZoomEnd) {
       const viewport = transformToViewport(event.transform);
       zoomPanValues.prevViewport = viewport;
 

packages/system/src/xypanzoom/utils.ts

@@ -6,9 +6,6 @@ import { transition } from 'd3-transition';
 import { type D3SelectionInstance, type Viewport } from '../types';
 import { isMacOs } from '../utils';
 
-export const viewChanged = (prevViewport: Viewport, eventViewport: any): boolean =>
-  prevViewport.x !== eventViewport.x || prevViewport.y !== eventViewport.y || prevViewport.zoom !== eventViewport.k;
-
 export const transformToViewport = (transform: ZoomTransform): Viewport => ({
   x: transform.x,
   y: transform.y,